Message->parse() is incompatible with header()

[FGasper]

perl -MData::Dumper -MHTTP::Response -e'my $hdr = HTTP::Response->parse("HTTP/1.0 200 OK\r\na-b_c: haha\r\n\r\n"); print Dumper $hdr; print $hdr->header("a-b_c");'

^^ The above will show that haha isn’t printed. The Dumper output shows that the header is stored internaly as a-b_c, but when we go to fetch that value we get nothing because fetch() is looking for a-b-c.

I don’t see any outstanding issues about this. Without knowing why Message->parse() disables the underscore translation I‘m not sure what the proper fix would be. Maybe make header() search for the original as well as the hyphen-replaced version?

[oalders]

@vanHoesel thoughts on this?

[mikkoi]

Underscores are valid in header names but traditionally not used often. Please see: https://stackoverflow.com/questions/22856136/why-do-http-servers-forbid-underscores-in-http-header-names

The following row:

HTTP-Message/lib/HTTP/Headers.pm

Line 13 in 402059a

our $TRANSLATE_UNDERSCORE = 1 unless defined $TRANSLATE_UNDERSCORE;

Is this meant to be?

our $TRANSLATE_UNDERSCORE = 1 unless defined $ENV{TRANSLATE_UNDERSCORE};

If we make the above change and set environment variable TRANSLATE_UNDERSCORE to '', example works:

TRANSLATE_UNDERSCORE= perl -Ilib -MData::Dumper -MHTTP::Response -E 'my $hdr = HTTP::Response->parse("HTTP/1.0 200 OK\r\na-b_c: haha\r\n\r\n"); print Dumper $hdr; say "a-b_c:" . $hdr->header("a-b_c");'