You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Helpers: consider moving the helpers to a library that has to be included, rather than adding them into the generated code
benefits: deserializeError type doesn't get duplicated in each module, dead code warning isn't necessary for modules that don't use all the helpers
Fix use std::os::unix::ffi::OsStrExt; being added for XDR schemas that don't need it (schema that has something like typedef string FileName<>; but no objects use FileName)
or just don't worry about this? Fix the schema?
input parameter to deserialize method (signature like pub fn deserialize(&mut self, mut input: &mut &[u8]) -> Result<(), helpers::DeserializeError>: in some cases this needs to be mutable (mut input: &mut ...) and in some cases it doesn't. (input: &mut ...).
This leads to warnings if it's always marked as mutable when some methods don't need that. Better way to handle this?
use std::os::unix::ffi::OsStrExt;being added for XDR schemas that don't need it (schema that has something liketypedef string FileName<>;but no objects useFileName)inputparameter to deserialize method (signature likepub fn deserialize(&mut self, mut input: &mut &[u8]) -> Result<(), helpers::DeserializeError>: in some cases this needs to be mutable (mut input: &mut ...) and in some cases it doesn't. (input: &mut ...).