Skip to content

Run/fix DynamicPV tests in CI & remove redundant tests #189

Description

@wongma7

/kind bug

What happened?
Old TODO: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/conformance_test.go#L136

IIRC we are skipping the DynamicPV tests because of an issue in the framework where it would only wait 5 minutes for a volume to be created but that issue has been solved for a long time now.

Running them will allow us to refactor/get rid of some of the custom tests, for example 2/3 of the ones here https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/dynamic_provisioning_test.go#L55, and maybe reduce some of the code duplicated from upstream like driver struct https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/driver/driver.go#L23

(obviously this is blocked by CI being 100% broken at the moment)

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions