|
| 1 | +package agent |
| 2 | + |
| 3 | +import ( |
| 4 | + "os" |
| 5 | + "path/filepath" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/roborev-dev/roborev/internal/config" |
| 9 | + "github.com/stretchr/testify/assert" |
| 10 | + "github.com/stretchr/testify/require" |
| 11 | +) |
| 12 | + |
| 13 | +func TestIsConfiguredACPAgentName(t *testing.T) { |
| 14 | + t.Run("default ACP name", func(t *testing.T) { |
| 15 | + assert.True(t, isConfiguredACPAgentName(defaultACPName, nil, "/tmp/repo")) |
| 16 | + }) |
| 17 | + |
| 18 | + t.Run("matches configured name", func(t *testing.T) { |
| 19 | + cfg := &config.Config{ |
| 20 | + ACP: &config.ACPAgentConfig{ |
| 21 | + Name: "custom-acp", |
| 22 | + }, |
| 23 | + } |
| 24 | + assert.True(t, isConfiguredACPAgentName("custom-acp", cfg, "/tmp/repo")) |
| 25 | + }) |
| 26 | + |
| 27 | + t.Run("does not match different name", func(t *testing.T) { |
| 28 | + cfg := &config.Config{ |
| 29 | + ACP: &config.ACPAgentConfig{ |
| 30 | + Name: "custom-acp", |
| 31 | + }, |
| 32 | + } |
| 33 | + assert.False(t, isConfiguredACPAgentName("other-acp", cfg, "/tmp/repo")) |
| 34 | + }) |
| 35 | + |
| 36 | + t.Run("empty name returns false", func(t *testing.T) { |
| 37 | + cfg := &config.Config{ |
| 38 | + ACP: &config.ACPAgentConfig{ |
| 39 | + Name: "custom-acp", |
| 40 | + }, |
| 41 | + } |
| 42 | + assert.False(t, isConfiguredACPAgentName("", cfg, "/tmp/repo")) |
| 43 | + }) |
| 44 | + |
| 45 | + t.Run("nil config returns false for non-default name", func(t *testing.T) { |
| 46 | + assert.False(t, isConfiguredACPAgentName("custom-acp", nil, "/tmp/repo")) |
| 47 | + }) |
| 48 | + |
| 49 | + t.Run("repo config takes precedence", func(t *testing.T) { |
| 50 | + // Create a temp directory with .roborev.toml |
| 51 | + testDir := t.TempDir() |
| 52 | + configPath := filepath.Join(testDir, ".roborev.toml") |
| 53 | + content := `[acp] |
| 54 | +name = "repo-acp" |
| 55 | +` |
| 56 | + err := os.WriteFile(configPath, []byte(content), 0644) |
| 57 | + require.NoError(t, err) |
| 58 | + |
| 59 | + // With repo config, should match repo-acp |
| 60 | + assert.True(t, isConfiguredACPAgentName("repo-acp", &config.Config{}, testDir)) |
| 61 | + |
| 62 | + // Should not match different name |
| 63 | + assert.False(t, isConfiguredACPAgentName("other-acp", &config.Config{}, testDir)) |
| 64 | + }) |
| 65 | + |
| 66 | + t.Run("whitespace trimming", func(t *testing.T) { |
| 67 | + cfg := &config.Config{ |
| 68 | + ACP: &config.ACPAgentConfig{ |
| 69 | + Name: " custom-acp ", |
| 70 | + }, |
| 71 | + } |
| 72 | + // Should match with whitespace trimmed |
| 73 | + assert.True(t, isConfiguredACPAgentName("custom-acp", cfg, "/tmp/repo")) |
| 74 | + }) |
| 75 | + |
| 76 | + t.Run("configured name with whitespace", func(t *testing.T) { |
| 77 | + cfg := &config.Config{ |
| 78 | + ACP: &config.ACPAgentConfig{ |
| 79 | + Name: " custom-acp ", |
| 80 | + }, |
| 81 | + } |
| 82 | + // Should match rawName with whitespace |
| 83 | + assert.True(t, isConfiguredACPAgentName(" custom-acp ", cfg, "/tmp/repo")) |
| 84 | + }) |
| 85 | +} |
| 86 | + |
| 87 | +func TestDefaultACPAgentConfig(t *testing.T) { |
| 88 | + cfg := defaultACPAgentConfig() |
| 89 | + assert.Equal(t, defaultACPName, cfg.Name) |
| 90 | + assert.Equal(t, defaultACPCommand, cfg.Command) |
| 91 | + assert.Equal(t, defaultACPReadOnlyMode, cfg.ReadOnlyMode) |
| 92 | + assert.Equal(t, defaultACPAutoApproveMode, cfg.AutoApproveMode) |
| 93 | + assert.Equal(t, defaultACPReadOnlyMode, cfg.Mode) |
| 94 | + assert.Equal(t, defaultACPTimeoutSeconds, cfg.Timeout) |
| 95 | +} |
| 96 | + |
| 97 | +func TestConfiguredACPAgent(t *testing.T) { |
| 98 | + cfg := &config.Config{ |
| 99 | + ACP: &config.ACPAgentConfig{ |
| 100 | + Name: "custom-acp", |
| 101 | + Command: "custom-cmd", |
| 102 | + Model: "custom-model", |
| 103 | + }, |
| 104 | + } |
| 105 | + |
| 106 | + agent := configuredACPAgent("/tmp/repo", cfg) |
| 107 | + assert.Equal(t, defaultACPName, agent.agentName) |
| 108 | + assert.Equal(t, "custom-cmd", agent.Command) |
| 109 | + assert.Equal(t, "custom-model", agent.Model) |
| 110 | +} |
| 111 | + |
| 112 | +func TestGetAvailableWithConfigACPAgent(t *testing.T) { |
| 113 | + t.Run("resolves configured ACP agent name", func(t *testing.T) { |
| 114 | + cfg := &config.Config{ |
| 115 | + ACP: &config.ACPAgentConfig{ |
| 116 | + Name: "my-acp", |
| 117 | + Command: "echo", // Use echo which is always available |
| 118 | + }, |
| 119 | + } |
| 120 | + |
| 121 | + // When the requested name matches the configured ACP name |
| 122 | + agent, err := GetAvailableWithConfig("", "my-acp", cfg) |
| 123 | + require.NoError(t, err) |
| 124 | + // The agent name should be the canonical ACP name |
| 125 | + assert.Equal(t, defaultACPName, agent.Name()) |
| 126 | + }) |
| 127 | + |
| 128 | + t.Run("resolves default acp name with echo command", func(t *testing.T) { |
| 129 | + cfg := &config.Config{ |
| 130 | + ACP: &config.ACPAgentConfig{ |
| 131 | + Name: defaultACPName, |
| 132 | + Command: "echo", |
| 133 | + }, |
| 134 | + } |
| 135 | + |
| 136 | + agent, err := GetAvailableWithConfig("", defaultACPName, cfg) |
| 137 | + require.NoError(t, err) |
| 138 | + assert.Equal(t, defaultACPName, agent.Name()) |
| 139 | + }) |
| 140 | +} |
0 commit comments