Stop shipping full prompts to metadata-only job listings (#939)

## Summary

- The agent-hook daemon queries `GET /api/jobs` on every Stop and Bash PostToolUse hook event to count open failed reviews, and that listing serialized the full stored prompt of every job. On repos with a long review history each hook event moved tens of megabytes of JSON (35MB observed for one repo), pinning the hook daemon above 100% CPU on decode and ~350MB RSS, with the main daemon paying the matching encode cost. Only job metadata is ever read from these listings.
- Adds `omit_prompt=true` to `/api/jobs`, wired down to a storage-level projection (`WithoutPrompt()`) so the prompt TEXT column is never read from SQLite for metadata-only listings — not just stripped after hydration. Used by the agent-hook count query and fix/refine discovery. Measured live: the worst-repo hook query drops from 35.1MB to 978KB (97%). The param is additive, so newer clients degrade gracefully against older daemons; the TUI keeps the default behavior because it renders prompts for queued/running jobs.
- Exposes the standard `net/http/pprof` endpoints on both the main daemon and the agent-hook daemon (loopback/unix-socket listeners only), so the next regression like this can be profiled with one command instead of guessing from `ps`.
- Regenerates the OpenAPI clients, which also picked up previously uncommitted spec drift (shutdown and export-reviews endpoints). The new endpoint test uses the generated typed client rather than hand-rolled query strings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<sup>generated by a clanker</sup>

Co-authored-by: Marius van Niekerk <mariusvniekerk@users.noreply.github.com>

Author: mariusvniekerk

cmd/roborev/fix.go

@@ -776,8 +776,10 @@ func queryOpenJobs(
 	repoRoot, branch string,
 ) ([]storage.ReviewJob, error) {
 	jobs, err := withFixDaemonRetryContext(ctx, getDaemonEndpoint().BaseURL(), func(addr string) ([]storage.ReviewJob, error) {
+		// omit_prompt: discovery only needs job metadata; prompts would add
+		// megabytes of JSON on repos with a long review history.
 		queryURL := fmt.Sprintf(
-			"%s/api/jobs?status=done&repo=%s&closed=false&limit=0",
+			"%s/api/jobs?status=done&repo=%s&closed=false&limit=0&omit_prompt=true",
 			addr, url.QueryEscape(repoRoot),
 		)
 		if branch != "" {

internal/agenthook/daemon.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"net/http/pprof"
 	"os"
 	"os/signal"
 	"path/filepath"
@@ -105,6 +106,7 @@ func parseDaemonEndpoint(raw string) (kitdaemon.Endpoint, error) {
 }
 
 func registerRoutes(mux *http.ServeMux, state *StateStore, shutdown chan<- struct{}) {
+	registerPprof(mux)
 	mux.Handle(kitdaemon.DefaultPingPath, kitdaemon.NewPingHandler(kitdaemon.PingHandlerOptions{
 		Service: ServiceName,
 		Version: version.Version,
@@ -194,6 +196,17 @@ func registerRoutes(mux *http.ServeMux, state *StateStore, shutdown chan<- struc
 	})
 }
 
+// registerPprof exposes the standard pprof profiling endpoints. The daemon
+// listens only on a unix socket or loopback TCP, so the profiles stay local
+// to the machine's user.
+func registerPprof(mux *http.ServeMux) {
+	mux.HandleFunc("/debug/pprof/", pprof.Index)
+	mux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
+	mux.HandleFunc("/debug/pprof/profile", pprof.Profile)
+	mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
+	mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
+}
+
 func writeJSON(w http.ResponseWriter, v any) {
 	w.Header().Set("Content-Type", "application/json")
 	_ = json.NewEncoder(w).Encode(v)

internal/agenthook/daemon_test.go

@@ -38,3 +38,21 @@ func channelSignaled(ch <-chan struct{}) bool {
 		return false
 	}
 }
+
+func TestDaemonServesPprof(t *testing.T) {
+	assert := assert.New(t)
+	state := &StateStore{
+		path:     filepath.Join(t.TempDir(), "state.json"),
+		sessions: map[string]SessionState{},
+	}
+	mux := http.NewServeMux()
+	registerRoutes(mux, state, make(chan struct{}, 1))
+
+	index := httptest.NewRecorder()
+	mux.ServeHTTP(index, httptest.NewRequest(http.MethodGet, "/debug/pprof/", nil))
+	assert.Equal(http.StatusOK, index.Code)
+
+	heap := httptest.NewRecorder()
+	mux.ServeHTTP(heap, httptest.NewRequest(http.MethodGet, "/debug/pprof/heap", nil))
+	assert.Equal(http.StatusOK, heap.Code)
+}

internal/agenthook/state.go

@@ -1161,6 +1161,9 @@ func countOpenFailedReviews(ctx context.Context, repoRoot, branch, head, configu
 	values.Set("status", "done")
 	values.Set("closed", "false")
 	values.Set("limit", "10000")
+	// Only job metadata is needed to count verdicts; full prompts would add
+	// tens of megabytes of JSON per hook event on busy repos.
+	values.Set("omit_prompt", "true")
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, ep.BaseURL()+"/api/jobs?"+values.Encode(), nil)
 	if err != nil {
 		return 0, false

internal/agenthook/state_test.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/http/httptest"
+	"net/url"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -1991,3 +1992,24 @@ func TestRecordPostToolUseAmendPreservesEarlierPendingCommits(t *testing.T) {
 	assert.True(atLater.Triggered, "both pending commits count once reviews appear")
 	assert.Equal("commit", atLater.TriggeredBy)
 }
+
+func TestCountOpenFailedReviewsRequestsOmittedPrompts(t *testing.T) {
+	assert := assert.New(t)
+	repo := testutil.NewGitRepo(t)
+	head := repo.CommitFile("base.txt", "base\n", "base")
+
+	var gotQuery atomic.Value
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		gotQuery.Store(r.URL.Query())
+		assert.NoError(json.NewEncoder(w).Encode(jobsResponse{}))
+	}))
+	t.Cleanup(server.Close)
+
+	_, ok := countOpenFailedReviews(context.Background(), repo.Path(), "main", head, server.URL)
+
+	require.True(t, ok)
+	query, _ := gotQuery.Load().(url.Values)
+	require.NotNil(t, query)
+	assert.Equal("true", query.Get("omit_prompt"),
+		"hook count queries must not pull full prompts over the wire")
+}

internal/daemon/routes.go

@@ -3,6 +3,7 @@ package daemon
 import (
 	"encoding/json"
 	"net/http"
+	"net/http/pprof"
 	"reflect"
 
 	"github.com/danielgtaylor/huma/v2"
@@ -17,6 +18,14 @@ import (
 // all typed endpoints. The returned huma.API can be used to serve
 // the generated OpenAPI spec.
 func (s *Server) registerHumaAPI(mux *http.ServeMux) huma.API {
+	// pprof profiling endpoints; the daemon listens only on loopback (or a
+	// systemd-provided local socket), so the profiles stay local to the machine.
+	mux.HandleFunc("/debug/pprof/", pprof.Index)
+	mux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
+	mux.HandleFunc("/debug/pprof/profile", pprof.Profile)
+	mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
+	mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
+
 	cfg := huma.DefaultConfig("roborev", version.Version)
 	cfg.DocsPath = ""
 	cfg.SchemasPath = ""

internal/daemon/server.go

@@ -960,6 +960,17 @@ func formatDuration(d time.Duration) string {
 
 const limitNotProvided = -999999
 
+// stripJobPrompts clears the large prompt and diff payloads from listed jobs
+// for omit_prompt=true callers. Metadata-only consumers such as the agent hook
+// daemon poll job lists on every hook event; shipping full prompts to them
+// costs tens of megabytes of encode/decode per request.
+func stripJobPrompts(jobs []storage.ReviewJob) {
+	for i := range jobs {
+		jobs[i].Prompt = ""
+		jobs[i].DiffContent = nil
+	}
+}
+
 func (s *Server) humaListJobs(
 	ctx context.Context, input *ListJobsInput,
 ) (*ListJobsOutput, error) {
@@ -980,6 +991,9 @@ func (s *Server) humaListJobs(
 		job.Patch = nil
 		resp := &ListJobsOutput{}
 		resp.Body.Jobs = []storage.ReviewJob{*job}
+		if input.OmitPrompt == "true" {
+			stripJobPrompts(resp.Body.Jobs)
+		}
 		return resp, nil
 	}
 
@@ -1040,6 +1054,9 @@ func (s *Server) humaListJobs(
 	}
 
 	var listOpts []storage.ListJobsOption
+	if input.OmitPrompt == "true" {
+		listOpts = append(listOpts, storage.WithoutPrompt())
+	}
 	if input.GitRef != "" {
 		listOpts = append(
 			listOpts, storage.WithGitRef(input.GitRef),
@@ -1120,6 +1137,10 @@ func (s *Server) humaListJobs(
 		jobs = jobs[:limit]
 	}
 
+	if input.OmitPrompt == "true" {
+		stripJobPrompts(jobs)
+	}
+
 	attachPanelSummaries(s.db, jobs)
 
 	// Stats use same repo/branch filters but ignore closed

internal/daemon/server_jobs_test.go

@@ -1,6 +1,7 @@
 package daemon
 
 import (
+	"context"
 	"fmt"
 	"net/http"
 	"net/http/httptest"
@@ -17,6 +18,7 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"go.kenn.io/roborev/internal/config"
+	daemonclient "go.kenn.io/roborev/internal/daemon_client"
 	gitpkg "go.kenn.io/roborev/internal/git"
 	"go.kenn.io/roborev/internal/storage"
 	"go.kenn.io/roborev/internal/testenv"
@@ -2679,3 +2681,62 @@ func TestHandleEnqueueMinSeverity(t *testing.T) {
 		assert.Contains(t, w.Body.String(), "invalid min_severity")
 	})
 }
+
+func TestListJobsOmitPrompt(t *testing.T) {
+	assert := assert.New(t)
+	server, db, _ := newTestServer(t)
+
+	repo, err := db.GetOrCreateRepo("/test/omit-prompt-repo")
+	require.NoError(t, err)
+	diff := "diff --git a/f b/f"
+	_, err = db.EnqueueJob(storage.EnqueueOpts{
+		RepoID:      repo.ID,
+		GitRef:      "dirty",
+		Agent:       "test",
+		Prompt:      "a very large stored prompt",
+		DiffContent: diff,
+	})
+	require.NoError(t, err)
+
+	ts := httptest.NewServer(server.httpServer.Handler)
+	t.Cleanup(ts.Close)
+	client, err := daemonclient.NewClientWithResponses(ts.URL)
+	require.NoError(t, err)
+
+	ctx := context.Background()
+	repoFilter := []string{repo.RootPath}
+	omit := daemonclient.ListJobsParamsOmitPromptTrue
+
+	listJobs := func(t *testing.T, params *daemonclient.ListJobsParams) []daemonclient.ReviewJob {
+		t.Helper()
+		resp, err := client.ListJobsWithResponse(ctx, params)
+		require.NoError(t, err)
+		require.Equal(t, http.StatusOK, resp.StatusCode(), "body: %s", resp.Body)
+		require.NotNil(t, resp.JSON200)
+		require.NotNil(t, resp.JSON200.Jobs)
+		return *resp.JSON200.Jobs
+	}
+
+	t.Run("default includes prompt", func(t *testing.T) {
+		jobs := listJobs(t, &daemonclient.ListJobsParams{Repo: &repoFilter})
+		require.Len(t, jobs, 1)
+		require.NotNil(t, jobs[0].Prompt)
+		assert.Equal("a very large stored prompt", *jobs[0].Prompt)
+	})
+
+	t.Run("omit_prompt=true strips prompt and diff content", func(t *testing.T) {
+		jobs := listJobs(t, &daemonclient.ListJobsParams{Repo: &repoFilter, OmitPrompt: &omit})
+		require.Len(t, jobs, 1)
+		assert.Nil(jobs[0].Prompt)
+		assert.Nil(jobs[0].DiffContent)
+	})
+
+	t.Run("omit_prompt=true strips prompt on single-job lookup", func(t *testing.T) {
+		all := listJobs(t, &daemonclient.ListJobsParams{Repo: &repoFilter})
+		require.Len(t, all, 1)
+		jobs := listJobs(t, &daemonclient.ListJobsParams{Id: &all[0].Id, OmitPrompt: &omit})
+		require.Len(t, jobs, 1)
+		assert.Nil(jobs[0].Prompt)
+		assert.Nil(jobs[0].DiffContent)
+	})
+}

internal/daemon/server_test.go

@@ -697,3 +697,16 @@ func TestCostOptionsFromInput(t *testing.T) {
 	_, err = costOptionsFromInput(&GetCostInput{Since: "bogus"})
 	assert.Error(err)
 }
+
+func TestServerServesPprof(t *testing.T) {
+	assert := assert.New(t)
+	server, _, _ := newTestServer(t)
+
+	index := httptest.NewRecorder()
+	server.httpServer.Handler.ServeHTTP(index, httptest.NewRequest(http.MethodGet, "/debug/pprof/", nil))
+	assert.Equal(http.StatusOK, index.Code)
+
+	heap := httptest.NewRecorder()
+	server.httpServer.Handler.ServeHTTP(heap, httptest.NewRequest(http.MethodGet, "/debug/pprof/heap", nil))
+	assert.Equal(http.StatusOK, heap.Code)
+}

internal/daemon/types.go

@@ -87,6 +87,7 @@ type ListJobsInput struct {
 	ExcludeJobType     string   `query:"exclude_job_type" doc:"Exclude jobs of this type"`
 	HideClassifyJobs   string   `query:"hide_classify_jobs" doc:"Hide auto-design-router rows (job_type=classify and status=skipped)" enum:"true,false,"`
 	PanelRun           string   `query:"panel_run" doc:"Return all jobs (members + synthesis) of one panel run"`
+	OmitPrompt         string   `query:"omit_prompt" doc:"Omit prompt and diff content from returned jobs (metadata-only listing)" enum:"true,false,"`
 	RepoPrefix         string   `query:"repo_prefix" doc:"Filter repos by path prefix"`
 	Limit              int      `query:"limit" default:"-999999" doc:"Max results (default 50, 0=unlimited, max 10000)"`
 	Offset             int      `query:"offset" default:"-1" doc:"Skip N results (requires limit>0)"`