Improper static call suggestion with Laravel Idea helper code

[dcaswel]

Subject	Details
Plugin	Php Inspections (EA Extended) v5.0.0.0
Language level	PHP 8.2

Current behaviour

I have a Laravel app and I use the Laravel Idea plugin. That plugin creates 2 related helper files. One for static methods that came from a macro and one for non-static methods that came from a macro. In the screenshot, the restore method is one of those methods that comes from a macro. It actually doesn't make a lot of sense to run the restore method statically but the Php Inspections plugin is reading from the static helper file instead of the non-static one so I'm getting this warning saying that it should be called statically.

Expected behaviour

I would expect that it doesn't give this warning as the method is being used correctly.

Environment details

PhpStorm 2024.2.1
Build #PS-242.21829.154, built on August 29, 2024
Runtime version: 21.0.3+13-b509.11 aarch64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.lwawt.macosx.LWCToolkit
macOS 14.6.1
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation
Memory: 4096M
Cores: 12
Metal Rendering is ON
Registry:
debugger.new.tool.window.layout=true
run.processes.with.pty=TRUE
ide.experimental.ui=true
i18n.locale=
terminal.new.ui=true
Non-Bundled Plugins:
com.intellij.lang.puppet (242.20224.159)
com.jetbrains.space (242.21829.142)
String Manipulation (9.14.1)
com.intellij.ml.llm (242.21829.196)
org.jetbrains.plugins.gitlab (242.21829.162)
org.jetbrains.plugins.github (242.21829.162)
com.intellij.angularjs (242.20224.155)
com.jetbrains.lang.ejs (242.20224.155)
com.github.inxilpro.intellijalpine (v0.4.2)
com.kalessil.phpStorm.phpInspectionsEA (5.0.0.0)
ru.adelf.idea.dotenv (2024.2.1)
de.espend.idea.php.annotation (11.0.3)
com.laravel_idea.plugin (8.2.5.242)
dev.ekvedaras.laravelquery (4.0.4)
com.mallowigi (97.0.0)
dev.nx.console (1.31.0)

[ea-inspections-team]

Thank you for reporting @dcaswel!

Would it be possible for you to share all available method definitions (possibly simplified)?

We have limited exposure to Laravel development and need to understand if method resolving is working correctly or inspection itself needs improvements.

[designvoid]

This is a recurring/constant issue - would be great to see it resolved! :)

[dcaswel]

@ea-inspections-team I'm sorry that I didn't get back to you sooner. So it looks like Laravel may have stopped using macros in the framework code because that restore() method is not a macro anymore, it's a method in a trait and I'm not able to find other macro methods in the framework. Because of that, this has not been as much of an issue for me. That said, this would still be an issue for people using older versions of Laravel and macros are definitely still a thing in Laravel. So if a user creates their own macro, it will still have this same issue. An example for how a user would use a macro can be seen in this part of the documentation: https://laravel.com/docs/11.x/collections#extending-collections. Because it would seem that my version of Laravel no longer has those methods as macros, I wouldn't be able to give you a list of methods from a new Laravel install. However, it shouldn't be too hard to reproduce the issue by creating a new Laravel app, create a macro as explained in the docs, and then use the method from the macro. You will also need the Laravel Idea plugin and have it generate helper code since it's that helper code that the inspection is reading. I hope this helps.