Merge pull request #113 from lmichel/final-review

Final review

Author: lmichel

.github/workflows/preview.yml

@@ -16,7 +16,7 @@ env:
 on:
   push:
     branches:
-      - brigita_review
+      - final-review
       - pr-1.0
 
 jobs:

doc/MANGO.tex

@@ -252,11 +252,11 @@ \section{Model Overview}
 Identifiers should be unique within a collection, e.g. a data table, although 
 this feature is not required by the model.
 
-In addition to its identifier, \texttt{MangoObject} objects have 2 components:
+In addition to their identifier, \texttt{MangoObject} objects have 2 elements :
 
 \begin{itemize}[noitemsep,topsep=0pt,parsep=0pt,partopsep=0pt]
 
-  \item \texttt{queryOrigin} (origin of the \texttt{MangoObject}) : The structure of this class is based on
+  \item \texttt{queryOrigin} (reference to the origin of the \texttt{MangoObject}) : The structure of this class is based on
         the recommendations of the DCP interest group \footnote{https://ivoa.net/documents/DataOrigin/index.html}.
   \item \texttt{propertyDock} (place holder for all the \texttt{MangoObject} properties) :
         This is an open-ended collection.

doc/Makefile

@@ -7,7 +7,7 @@ DOCNAME = MANGO
 DOCVERSION = 1.0
 
 # Publication date, ISO format; update manually for "releases"
-DOCDATE = 2026-02-26
+DOCDATE = 2026-03-05
 
 # What is it you're writing: NOTE, WD, PR, REC, PEN, or EN
 DOCTYPE = PR

doc/ivoatexmeta.tex

@@ -1,7 +1,7 @@
 % GENERATED FILE -- edit this in the Makefile
 \newcommand{\ivoaDocversion}{1.0}
-\newcommand{\ivoaDocdate}{2026-02-26}
-\newcommand{\ivoaDocdatecode}{20260226}
+\newcommand{\ivoaDocdate}{2026-03-05}
+\newcommand{\ivoaDocdatecode}{20260305}
 \newcommand{\ivoaDoctype}{PR}
 \newcommand{\ivoaDocname}{MANGO}
 \renewcommand{\ivoaBaseURL}{https://www.ivoa.net/documents/MANGO}

doc/model.tex

@@ -178,7 +178,7 @@ \section{Model: mango }
 
 
   \label{sect:EpochPosition}
-    This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R}. At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:SpaceSys}. \item The time coordinate system is imported from \texttt{coords:TimeSys}. \end{itemize} It is recommended to use the \texttt{ObsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:SpaceSys}. There are 2 reasons for this: \begin{itemize} \item Using the epoch of \texttt{coords:SpaceSys} requires to work with the \texttt{coords:CustomRefLocation} class to carry the reference location. This class does not support the standard reference locations such as e.g. BARYCENTER. \item The observation date can be read in a column and therefore change with each data row. In this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EpochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
+    This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R}. At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:SpaceSys}. \item The time coordinate system is imported from \texttt{coords:TimeSys}. \end{itemize} It is recommended to use the \texttt{obsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:SpaceSys}. There are 2 reasons for this: \begin{itemize} \item The epoch of \texttt{coords:SpaceSys} is for the epoch of the reference location position, not for the measurement epoch. \item The observation date can be read in a column and therefore change with each data row. In this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EpochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
 
     \subsubsection{EpochPosition.longitude}
       \textbf{vodml-id: EpochPosition.longitude} \newline
@@ -220,7 +220,7 @@ \section{Model: mango }
       \textbf{vodml-id: EpochPosition.obsDate} \newline
       \textbf{type: \hyperref[sect:ivoa]{ivoa:datetime}} \newline
       \textbf{multiplicity: 1} \newline
-      Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system (see the above). Figure \ref{datetime} shows up the hierarchy of the primitive types representing the observation dates.
+      Observation date expressed within the common time system if present. Figure \ref{datetime} shows up the hierarchy of the primitive types representing the observation dates.
 
     \subsubsection{EpochPosition.pmCosLatApplied}
       \textbf{vodml-id: EpochPosition.pmCosLatApplied} \newline
@@ -402,13 +402,13 @@ \section{Model: mango }
       \textbf{vodml-id: MangoObject.mangoObjects} \newline
       \textbf{type: \hyperref[sect:AssociatedMangoObject]{mango:AssociatedMangoObject}} \newline
       \textbf{multiplicity: 0..*} \newline
-      Reference to particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.
+      Collection of particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.
 
     \subsubsection{MangoObject.queryOrigin}
       \textbf{vodml-id: MangoObject.queryOrigin} \newline
       \textbf{type: \hyperref[sect:origin.QueryOrigin]{mango:origin.QueryOrigin}} \newline
       \textbf{multiplicity: 0..1} \newline
-      Reference to the description of the origin of the \texttt{MangoObject}.
+      Reference to the description of the origin of the dataset to which the \texttt{MangoObject} belongs.
 
   \subsection{PhysicalProperty}
   \label{sect:PhysicalProperty}
@@ -586,7 +586,7 @@ \section{Package: error }
   %\end{center}
   %\end{figure}
 
-  The \texttt{error} package (fig \ref{fig:error}) groups the MANGO built-in error classes. All these classes are derived from \texttt{meas:Uncertainty} to make them reusable by \texttt{meas:Measure} instances. Mango errors all have an attribute that specifies the confidence level.
+  The \texttt{error} package (fig \ref{fig:error}) groups the MANGO built-in error classes. Mango errors all have an attribute that specifies the confidence level.
 
   \subsection{PErrorAsym1D}
   \label{sect:error.PErrorAsym1D}
@@ -654,7 +654,7 @@ \section{Package: error }
 
   \subsection{PropertyError (Abstract)}
   \label{sect:error.PropertyError}
-    Root (abstract) class of the errors that can be attached to a MANGO property. The class inherits from \texttt{meas:uncertainty} in order to be usable in the context of properties based on \texttt{Measures} classes.
+    Root (abstract) class of the errors that can be attached to a MANGO property.
 
     \subsubsection{PropertyError.confidenceLevel}
       \textbf{vodml-id: error.PropertyError.confidenceLevel} \newline

doc/model_toc.tex

@@ -23,13 +23,13 @@ \section{Model: mango}
     \textbf{vodml-id: MangoObject.mangoObjects} \newline
     \textbf{type: \hyperref[sect:AssociatedMangoObject]{mango:AssociatedMangoObject}} \newline
     \textbf{multiplicity: 0..*} \newline
-    Reference to particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.
+    Collection of particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.
 
     \subsubsection{MangoObject.queryOrigin}
     \textbf{vodml-id: MangoObject.queryOrigin} \newline
     \textbf{type: \hyperref[sect:origin.QueryOrigin]{mango:origin.QueryOrigin}} \newline
     \textbf{multiplicity: 0..1} \newline
-    Reference to the description of the origin of the \texttt{MangoObject}.
+    Reference to the description of the origin of the dataset to which the \texttt{MangoObject} belongs.
 
   \subsection{AssociatedMangoObject}
     \label{sect:AssociatedMangoObject}
@@ -133,7 +133,7 @@ \section{Epoch Position Properties}
     \label{fig:EpochPosition}
     \end{figure}
     \label{sect:EpochPosition}
-    This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R}. At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:SpaceSys}. \item The time coordinate system is imported from \texttt{coords:TimeSys}. \end{itemize} It is recommended to use the \texttt{ObsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:SpaceSys}. There are 2 reasons for this: \begin{itemize} \item Using the epoch of \texttt{coords:SpaceSys} requires to work with the \texttt{coords:CustomRefLocation} class to carry the reference location. This class does not support the standard reference locations such as e.g. BARYCENTER. \item The observation date can be read in a column and therefore change with each data row. In this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EpochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
+    This class (fig \ref{fig:EpochPosition}) is a flattened view of objects/concepts from the Astronomical Measurements Model \citep{2022ivoa.specQ1004R} that have been put together to form a consistent description of the position of an object moving over time. It consists of a celestial position, a proper motion, a radial velocity and a parallax and their associated errors encapsulated into the \texttt{EpochPositionErrors} class. The values of these properties are pulled from the underlying Astronomical Coordinates and Coordinate Systems model \citep{2022ivoa.spec.1004R}. At a high level the properties map as follows: \begin{itemize} \item celestial position -> \texttt{meas:Position} \item proper motion -> \texttt{meas:ProperMotion} \item radial velocity -> \texttt{meas.Velocity} \item parallax -> no suitable counterpart at this time \end{itemize} All components use the same coordinate systems for both time and space coordinates. \begin{itemize} \item Both position and proper motion reuse \texttt{coords:LonLatPoint} elements. \item The space coordinate system is imported from \texttt{coords:SpaceSys}. \item The time coordinate system is imported from \texttt{coords:TimeSys}. \end{itemize} It is recommended to use the \texttt{obsDate} field to store the epoch of the observation instead of the \texttt{epoch} field of \texttt{coords:SpaceSys}. There are 2 reasons for this: \begin{itemize} \item The epoch of \texttt{coords:SpaceSys} is for the epoch of the reference location position, not for the measurement epoch. \item The observation date can be read in a column and therefore change with each data row. In this case, it cannot be stored as an element of the space coordinate system but as an \texttt{EpochPosition} attribute. \end{itemize} All components have their own units which must be consistent with each other. This consistency is not enforced by the model. Possible correlations between \texttt{EpochPosition} parameters are handled by the \texttt{EpochPositionCorrelations} class. Errors along the different axes are grouped in the \texttt{EpochPositionErrors} class. In some cases the errors might conflict with the correlations: \begin{itemize} \item \texttt{Ellipse} errors on position or proper motion must not be used together with the \texttt{longitudeLatitude} (or \texttt{pmLongitudePmLatitude}) correlation fields. In fact, using elliptical errors implies a correlation between the two spatial axes which must not conflict with the correlations defined in \texttt{EpochPositionCorrelations}. \end{itemize}
 
     \subsubsection{EpochPosition.longitude}
     \textbf{vodml-id: EpochPosition.longitude} \newline
@@ -175,7 +175,7 @@ \section{Epoch Position Properties}
     \textbf{vodml-id: EpochPosition.obsDate} \newline
     \textbf{type: \hyperref[sect:ivoa]{ivoa:datetime}} \newline
     \textbf{multiplicity: 1} \newline
-    Observation date expressed within the common time system if present. This attribute, if set, supersedes the epoch possibly given with the spatial coordinate system (see the above). Figure \ref{datetime} shows up the hierarchy of the primitive types representing the observation dates.
+    Observation date expressed within the common time system if present. Figure \ref{datetime} shows up the hierarchy of the primitive types representing the observation dates.
 
     \subsubsection{EpochPosition.pmCosLatApplied}
     \textbf{vodml-id: EpochPosition.pmCosLatApplied} \newline
@@ -514,11 +514,11 @@ \section{Package: error}
     \caption{error package}
     \label{fig:error}
     \end{figure}
-    The \texttt{error} package (fig \ref{fig:error}) groups the MANGO built-in error classes. All these classes are derived from \texttt{meas:Uncertainty} to make them reusable by \texttt{meas:Measure} instances. Mango errors all have an attribute that specifies the confidence level.
+    The \texttt{error} package (fig \ref{fig:error}) groups the MANGO built-in error classes. Mango errors all have an attribute that specifies the confidence level.
 
   \subsection{PropertyError (Abstract)}
     \label{sect:error.PropertyError}
-    Root (abstract) class of the errors that can be attached to a MANGO property. The class inherits from \texttt{meas:uncertainty} in order to be usable in the context of properties based on \texttt{Measures} classes.
+    Root (abstract) class of the errors that can be attached to a MANGO property.
 
     \subsubsection{PropertyError.confidenceLevel}
     \textbf{vodml-id: error.PropertyError.confidenceLevel} \newline

doc/usecases.tex

@@ -199,7 +199,7 @@ \subsubsection{Client Use-cases}
     \item does this table contain sky positions, or HEALPix tiles, or both?
     What's the best way to represent it on the sky?
 
-    \item what is the meaning of such URL found out in a tables?
+    \item what is the meaning of the URL stored in a table column?
 \end{itemize}
 
 But there are some other cases like: