Skip to content

Commit 65bc19b

Browse files
author
Mohammed Taha Khan
committed
fix(admin): show clear error in View Changes modal on 403
1 parent f18b106 commit 65bc19b

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

  • invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/auditLogs

invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/auditLogs/ViewRecentChanges.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@ export class ViewRecentChanges extends Component {
8181
});
8282
} catch (error) {
8383
if (error === "UNMOUNTED") return;
84-
this.setState({ error: error, loading: false });
84+
this.setState({
85+
error:
86+
error.response?.data?.message ||
87+
error.message ||
88+
i18next.t("Unable to fetch revisions."),
89+
loading: false,
90+
});
8591
console.error(error);
8692
}
8793
}
@@ -107,9 +113,11 @@ export class ViewRecentChanges extends Component {
107113
/>
108114
</Modal.Content>
109115
)}
110-
<Modal.Content scrolling>
111-
<RevisionsDiffViewer diff={diff} />
112-
</Modal.Content>
116+
{!error && (
117+
<Modal.Content scrolling>
118+
<RevisionsDiffViewer diff={diff} />
119+
</Modal.Content>
120+
)}
113121
<Modal.Actions>
114122
<Grid>
115123
<Grid.Column floated="left" width={8} textAlign="left">

0 commit comments

Comments
 (0)