Merge pull request firecrawl#3624 from firecrawl/jonathan/monitoring-update-model

feat(monitoring): Add meaningfulChange to monitoring judgments

Author: developersdigest

apps/api/src/services/monitoring/diff-orchestrator.ts

@@ -20,7 +20,12 @@ type Judgment = {
   meaningful: boolean;
   confidence: "high" | "medium" | "low";
   reason: string;
-  fields: string[];
+  meaningfulChanges: Array<{
+    type: "added" | "removed" | "changed";
+    before: string | null;
+    after: string | null;
+    reason: string;
+  }>;
 };
 
 type MonitorPageDiffResult = {

apps/api/src/services/monitoring/judgeChange.test.ts

@@ -14,7 +14,7 @@ describe("judgeChange — input validation (no LLM call)", () => {
     });
     expect(result.meaningful).toBe(true);
     expect(result.confidence).toBe("low");
-    expect(result.fields).toEqual([]);
+    expect(result.meaningfulChanges).toEqual([]);
   });
 });
 

apps/api/src/services/monitoring/judgeChange.ts

@@ -24,7 +24,14 @@ const FAKE_JUDGMENT = {
   meaningful: true as const,
   confidence: "high" as const,
   reason: "test",
-  fields: [],
+  meaningfulChanges: [
+    {
+      type: "changed" as const,
+      before: "old test",
+      after: "new test",
+      reason: "The tracked value changed.",
+    },
+  ],
 };
 
 const FRESH_PAGE = {

apps/api/src/services/monitoring/meaningful-monitoring.test.ts

@@ -31,7 +31,12 @@ interface PageJudgment {
   meaningful: boolean;
   confidence: "high" | "medium" | "low";
   reason: string;
-  fields: string[];
+  meaningfulChanges: Array<{
+    type: "added" | "removed" | "changed";
+    before: string | null;
+    after: string | null;
+    reason: string;
+  }>;
 }
 
 async function sendMonitorPageWebhook(params: {

apps/api/src/services/monitoring/results.ts

@@ -280,7 +280,12 @@ export type MonitorCheckPageInsert = {
     meaningful: boolean;
     confidence: "high" | "medium" | "low";
     reason: string;
-    fields: string[];
+    meaningfulChanges: Array<{
+      type: "added" | "removed" | "changed";
+      before: string | null;
+      after: string | null;
+      reason: string;
+    }>;
   } | null;
 };
 

apps/api/src/services/monitoring/types.ts

@@ -15,7 +15,12 @@ type MonitoringEmailPage = {
     meaningful: boolean;
     confidence: "high" | "medium" | "low";
     reason: string;
-    fields: string[];
+    meaningfulChanges?: Array<{
+      type: "added" | "removed" | "changed";
+      before: string | null;
+      after: string | null;
+      reason: string;
+    }>;
   } | null;
   diffText?: string | null;
 };

apps/api/src/services/notification/monitoring_email.ts

@@ -123,7 +123,12 @@ interface MonitorPageJudgment {
   meaningful: boolean;
   confidence: "high" | "medium" | "low";
   reason: string;
-  fields: string[];
+  meaningfulChanges: Array<{
+    type: "added" | "removed" | "changed";
+    before: string | null;
+    after: string | null;
+    reason: string;
+  }>;
 }
 
 interface MonitorPageDiff {

apps/api/src/services/webhook/types.ts

@@ -744,7 +744,12 @@ export interface MonitorPageJudgment {
   meaningful: boolean;
   confidence: "high" | "medium" | "low";
   reason: string;
-  fields: string[];
+  meaningfulChanges: Array<{
+    type: "added" | "removed" | "changed";
+    before: string | null;
+    after: string | null;
+    reason: string;
+  }>;
 }
 
 export interface MonitorCheck {