Switch to build_csv_rows to yield via find_each to dedupe (#2469)

Author: julianguyen

app/models/application_record.rb

@@ -4,19 +4,16 @@ class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 
   def self.build_csv_rows(objects)
-    return [] if objects.blank?
+    return if objects.blank?
 
     klass = objects.klass
-    data = [["#{klass.name.underscore}_info"]]
     attributes = if klass.const_defined?(:USER_DATA_ATTRIBUTES)
                    klass.const_get(:USER_DATA_ATTRIBUTES)
                  else
                    klass.column_names
                  end
-    data << attributes
-    objects.each do |object|
-      data << attributes.map { |attribute| object.send(attribute.to_sym) }
-    end
-    data
+    yield ["#{klass.name.underscore}_info"]
+    yield attributes
+    objects.find_each { |object| yield attributes.map { |attribute| object.send(attribute.to_sym) } }
   end
 end

app/models/user.rb

@@ -187,19 +187,19 @@ def build_csv_data
     yield ['user_info']
     yield USER_DATA_ATTRIBUTES
     yield USER_DATA_ATTRIBUTES.map { |attribute| send(attribute.to_sym) }
-    Group.build_csv_rows(groups).each { |row| yield row }
-    GroupMember.build_csv_rows(group_members).each { |row| yield row }
-    Category.build_csv_rows(categories).each { |row| yield row }
-    Medication.build_csv_rows(medications).each { |row| yield row }
-    Strategy.build_csv_rows(strategies).each { |row| yield row }
-    Moment.build_csv_rows(moments).each { |row| yield row }
-    Notification.build_csv_rows(notifications).each { |row| yield row }
-    Mood.build_csv_rows(moods).each { |row| yield row }
-    CarePlanContact.build_csv_rows(care_plan_contacts).each { |row| yield row }
-    Allyship.build_csv_rows(allyships).each { |row| yield row }
-    MeetingMember.build_csv_rows(meeting_members).each { |row| yield row }
-    build_comment_csv_data.each { |row| yield row }
-    build_led_group_meeting_csv_data.each { |row| yield row }
+    Group.build_csv_rows(groups) { |row| yield row }
+    GroupMember.build_csv_rows(group_members) { |row| yield row }
+    Category.build_csv_rows(categories) { |row| yield row }
+    Medication.build_csv_rows(medications) { |row| yield row }
+    Strategy.build_csv_rows(strategies) { |row| yield row }
+    Moment.build_csv_rows(moments) { |row| yield row }
+    Notification.build_csv_rows(notifications) { |row| yield row }
+    Mood.build_csv_rows(moods) { |row| yield row }
+    CarePlanContact.build_csv_rows(care_plan_contacts) { |row| yield row }
+    Allyship.build_csv_rows(allyships) { |row| yield row }
+    MeetingMember.build_csv_rows(meeting_members) { |row| yield row }
+    build_comment_csv_data { |row| yield row }
+    build_led_group_meeting_csv_data { |row| yield row }
   end
 
   def generate_data_request
@@ -250,28 +250,25 @@ def delete_stale_data_file
   private
 
   def build_comment_csv_data
-    moment_ids = moments.map(&:id)
-    strategy_ids = strategies.map(&:id)
-    data = []
-    data += Comment.build_csv_rows(
+    moment_ids = Moment.where(user_id: id).pluck(:id)
+    strategy_ids = Strategy.where(user_id: id).pluck(:id)
+    Comment.build_csv_rows(
       Comment.where(commentable_type: 'Moment', commentable_id: moment_ids)
-    )
-    data += Comment.build_csv_rows(
+    ) { |row| yield row }
+    Comment.build_csv_rows(
       Comment.where(commentable_type: 'Strategy', commentable_id: strategy_ids)
-    )
-    data
+    ) { |row| yield row }
   end
 
   def build_led_group_meeting_csv_data
-    leader_group_ids = group_members.where(leader: true).pluck(:group_id)
-    return [] if leader_group_ids.empty?
+    leader_group_ids = GroupMember.where(user_id: id, leader: true).pluck(:group_id)
+    return if leader_group_ids.empty?
 
     leader_meetings = Meeting.where(group_id: leader_group_ids)
-    data = Meeting.build_csv_rows(leader_meetings)
-    data += Comment.build_csv_rows(
+    Meeting.build_csv_rows(leader_meetings) { |row| yield row }
+    Comment.build_csv_rows(
       Comment.where(commentable_type: 'Meeting', commentable_id: leader_meetings.pluck(:id))
-    )
-    data
+    ) { |row| yield row }
   end
 
   def oauth_provided?

app/models/users/data_request.rb

@@ -20,20 +20,6 @@ class DataRequest < ApplicationRecord
       deleted: 4
     }.freeze
 
-    ASSOCIATIONS_TO_EXPORT = %i[
-      allyships
-      group_members
-      groups
-      categories
-      medications
-      strategies
-      moments
-      notifications
-      moods
-      care_plan_contacts
-      meeting_members
-    ].freeze
-
     DEFAULT_FILE_PATH = Rails.root.join('tmp/csv_data')
 
     belongs_to :user, class_name: '::User'
@@ -71,7 +57,7 @@ def enqueue_download_request
     end
 
     def create_csv
-      user = User.includes(*ASSOCIATIONS_TO_EXPORT).find(user_id)
+      user = User.find(user_id)
       begin
         require 'csv'
         require 'zlib'