fix: prevent Mixer tab hang and stale preview in direct assignment mode

Move loadOutputAssignment out of the mandatory load chain to avoid a
permanent hang when a malformed packet drops the MSP callback. The tab
now renders immediately with the JS fallback and updates once firmware
responds (2 s timeout guard for safety).

Add invalidateDirectAssignment() so that local motor/servo rule changes
(preset load, add/remove rules, motor wizard) fall back to the JS
algorithm rather than showing stale cached firmware data.

Add LED and PINIO output type rendering in getOutputTableDirect() and
clear directAssignments in flush() for clean reconnect state.

Author: sensei-hacker

js/outputMapping.js

@@ -52,6 +52,12 @@ var OutputMappingCollection = function () {
         directAssignments = [];
     }
 
+    // Discard cached data to force JS fallback on the next render — used when local
+    // motor/servo rules change before being saved, so firmware data is stale.
+    self.invalidateDirectAssignment = function() {
+        directAssignments = [];
+    }
+
     self.setDirectAssignment = function(outputIndex, type, number) {
         directAssignments.push({ outputIndex, type, number });
     }
@@ -74,6 +80,10 @@ var OutputMappingCollection = function () {
                 outputMap[displayIndex] = 'Motor ' + entry.number;
             } else if (entry.type === 2) {
                 outputMap[displayIndex] = 'Servo ' + entry.number;
+            } else if (entry.type === 3) {
+                outputMap[displayIndex] = 'Led';
+            } else if (entry.type === 4) {
+                outputMap[displayIndex] = 'USER' + entry.number;
             }
         }
 
@@ -207,6 +217,7 @@ var OutputMappingCollection = function () {
 
     self.flush = function () {
         data = [];
+        directAssignments = [];
     };
 
     self.put = function (element) {

tabs/mixer.js

@@ -41,7 +41,6 @@ mixerTab.initialize = function (callback, scrollPosition) {
         mspHelper.loadMotorMixRules,
         mspHelper.loadOutputMappingExt,
         mspHelper.loadTimerOutputModes,
-        mspHelper.loadOutputAssignment,
         mspHelper.loadLogicConditions,
         mspHelper.loadEzTune,
     ]);
@@ -670,6 +669,7 @@ mixerTab.initialize = function (callback, scrollPosition) {
             }
 
             renderMotorMixRules();
+            FC.OUTPUT_MAPPING.invalidateDirectAssignment();
             renderOutputMapping();
 
             motorWizardModal.close();
@@ -795,6 +795,7 @@ mixerTab.initialize = function (callback, scrollPosition) {
             FC.MIXER_CONFIG.hasFlaps = (currentMixerPreset.hasFlaps === true) ? true : false;
             renderServoMixRules();
             renderMotorMixRules();
+            FC.OUTPUT_MAPPING.invalidateDirectAssignment();
             renderOutputMapping();
             updateRefreshButtonStatus();
         });
@@ -813,12 +814,14 @@ mixerTab.initialize = function (callback, scrollPosition) {
         $servoMixTableBody.on('click', "[data-role='role-servo-delete']", function (event) {
             FC.SERVO_RULES.drop($(event.currentTarget).attr("data-index"));
             renderServoMixRules();
+            FC.OUTPUT_MAPPING.invalidateDirectAssignment();
             renderOutputMapping();
         });
 
         $motorMixTableBody.on('click', "[data-role='role-motor-delete']", function (event) {
             FC.MOTOR_RULES.drop($(event.currentTarget).attr("data-index"));
             renderMotorMixRules();
+            FC.OUTPUT_MAPPING.invalidateDirectAssignment();
             renderOutputMapping();
         });
 
@@ -830,6 +833,7 @@ mixerTab.initialize = function (callback, scrollPosition) {
             if (FC.SERVO_RULES.hasFreeSlots()) {
                 FC.SERVO_RULES.put(new ServoMixRule(FC.SERVO_RULES.getNextUnusedIndex(), 0, 100, 0));
                 renderServoMixRules();
+                FC.OUTPUT_MAPPING.invalidateDirectAssignment();
                 renderOutputMapping();
             }
         });
@@ -838,6 +842,7 @@ mixerTab.initialize = function (callback, scrollPosition) {
             if (FC.MOTOR_RULES.hasFreeSlots()) {
                 FC.MOTOR_RULES.put(new MotorMixRule(1, 0, 0, 0));
                 renderMotorMixRules();
+                FC.OUTPUT_MAPPING.invalidateDirectAssignment();
                 renderOutputMapping();
             }
         });
@@ -855,6 +860,20 @@ mixerTab.initialize = function (callback, scrollPosition) {
         renderOutputMapping();
         renderTimerOverride();
 
+        // Attempt to enhance output preview with firmware-authoritative assignments.
+        // Tab is already functional above; this re-renders if/when firmware responds.
+        // The settled guard handles the edge case of a malformed packet causing no callback.
+        {
+            let settled = false;
+            const onOutputAssignmentLoaded = function() {
+                if (settled) return;
+                settled = true;
+                renderOutputMapping();
+            };
+            mspHelper.loadOutputAssignment(onOutputAssignmentLoaded);
+            setTimeout(onOutputAssignmentLoaded, 2000);
+        }
+
         FC.LOGIC_CONDITIONS.init($('#logic-wrapper'));
 
         i18n.localize();;