fix_ball_node

Author: obucklin

src/compas_timber/connections/ball_node.py

@@ -70,31 +70,27 @@ def generated_elements(self):
 
     @property
     def elements(self):
-        return self.beams + [self.generated_elements]
+        return list(self.beams) + self.generated_elements
 
     @property
     def interactions(self):
         for beam in self.beams:
             yield (beam, self.fastener)
 
     @classmethod
-    def create(cls, model, *elements, **kwargs):
-        """Creates an instance of the BallNodeJoint and creates the new connection in `model`.
+    def from_element_list(cls, elements, **kwargs):
+        """Creates an instance of the BallNodeJoint.
 
         This differs fom the generic `Joint.create()` method in that it passes the `beams` to
         the constructor of the BallNodeJoint as a list instead of as separate arguments.
 
-        `beams` are expected to have been added to `model` before calling this method.
-
         This code does not verify that the given beams are adjacent and/or lie in a topology which allows connecting
         them. This is the responsibility of the calling code.
 
         A `ValueError` is raised if `beams` contains less than two `Beam` objects.
 
         Parameters
         ----------
-        model : :class:`~compas_timber.model.TimberModel`
-            The model to which the beams and this joing belong.
         beams : list(:class:`~compas_timber.parts.Beam`)
             A list containing beams that whould be joined together
 
@@ -104,10 +100,8 @@ def create(cls, model, *elements, **kwargs):
             The instance of the created joint.
 
         """
-        elements = list(elements)
-        joint = cls(elements, **kwargs)
-        model.add_joint(joint)
-        return joint
+        return cls(elements, **kwargs)
+
 
     @property
     def node_point(self):

src/compas_timber/connections/joint.py

@@ -185,6 +185,31 @@ def create(cls, model, *elements, **kwargs):
 
         """
 
-        joint = cls(*elements, **kwargs)
+        joint = cls.from_element_list(elements, **kwargs)
         model.add_joint(joint)
         return joint
+
+
+    @classmethod
+    def from_element_list(cls, elements, **kwargs):
+        """Creates an instance of this joint from a list of elements. This should be overridden when a joint type takes a list of elements.
+
+        This code does not verify that the given elements are adjacent and/or lie in a topology which allows connecting
+        them. This is the responsibility of the calling code.
+
+        Parameters
+        ----------
+        *elements : :class:`~compas_model.elements.Element`
+            The elements to be connected by this joint. The number of elements must comply with the `Joint` class's
+            `MIN_ELEMENT_COUNT` and `MAX_ELEMENT_COUNT` attributes.
+        **kwargs : dict
+            Additional keyword arguments that are passed to the joint's constructor.
+
+        Returns
+        -------
+        :class:`compas_timber.connections.Joint`
+            The instance of the created joint.
+
+        """
+
+        return cls(*elements, **kwargs)

src/compas_timber/elements/fasteners/ball_node_fastener.py

@@ -153,7 +153,7 @@ def interface_plate(self):
         """Generate a plate from outline_points, thickness, and holes."""
         if not self.base_interface.outline_points:
             return None
-        outline_points = correct_polyline_direction(self.base_interface.outline_points, Vector(0, 0, 1))
+        outline_points = correct_polyline_direction(self.base_interface.outline_points, Vector(0, 0, 1), clockwise=True)
         outline = NurbsCurve.from_points(outline_points, degree=1)
         holes = self.base_interface.holes
         thickness = self.base_interface.thickness