stuff more

Author: S1ro1

src/libkernelbot/leaderboard_db.py

@@ -1220,7 +1220,6 @@ def is_user_rate_limited(self, user_id: int, leaderboard_id: int, gpu_type: str)
                 return False, None
 
             rate_limit_seconds = row[0]
-            print(f"GPU type: {gpu_type}, Rate limit: {rate_limit_seconds}")
             self.cursor.execute(
                 """
                 SELECT s.submission_time

tests/test_leaderboard_db.py

@@ -867,14 +867,16 @@ def test_is_user_rate_limited_recent_submission(database, submit_leaderboard):
     """Test is_user_rate_limited returns True when user submitted recently"""
     with database as db:
         db.set_leaderboard_gpu_rate_limit("submit-leaderboard", "A100", 3600)
-        db.create_submission(
+        sub_id = db.create_submission(
             "submit-leaderboard",
             "file.py",
             5,
             "code",
             datetime.datetime.now(tz=datetime.timezone.utc),
             user_name="user",
         )
+        # Create a run with A100 GPU - required since rate limit query joins with runs table
+        _create_submission_run(db, sub_id, runner="A100", score=1.0)
         lb_id = db.get_leaderboard_id("submit-leaderboard")
         is_limited, reason = db.is_user_rate_limited(5, lb_id, "A100")
         assert is_limited is True
@@ -899,14 +901,16 @@ def test_is_user_rate_limited_different_user(database, submit_leaderboard):
     """Test is_user_rate_limited only applies to the specific user"""
     with database as db:
         db.set_leaderboard_gpu_rate_limit("submit-leaderboard", "A100", 3600)
-        db.create_submission(
+        sub_id = db.create_submission(
             "submit-leaderboard",
             "file.py",
             5,
             "code",
             datetime.datetime.now(tz=datetime.timezone.utc),
             user_name="user5",
         )
+        # Create a run with A100 GPU - required since rate limit query joins with runs table
+        _create_submission_run(db, sub_id, runner="A100", score=1.0)
         lb_id = db.get_leaderboard_id("submit-leaderboard")
         # User 6 should not be rate limited
         is_limited, reason = db.is_user_rate_limited(6, lb_id, "A100")
@@ -937,14 +941,16 @@ def test_is_user_allowed_to_submit_blocked(database, submit_leaderboard):
     """Test is_user_allowed_to_submit returns False when user submitted recently"""
     with database as db:
         db.set_leaderboard_gpu_rate_limit("submit-leaderboard", "A100", 3600)
-        db.create_submission(
+        sub_id = db.create_submission(
             "submit-leaderboard",
             "file.py",
             5,
             "code",
             datetime.datetime.now(tz=datetime.timezone.utc),
             user_name="user",
         )
+        # Create a run with A100 GPU - required since rate limit query joins with runs table
+        _create_submission_run(db, sub_id, runner="A100", score=1.0)
         allowed, reason = db.is_user_allowed_to_submit(5, "submit-leaderboard", ["A100"])
         assert allowed is False
         assert reason is not None
@@ -956,14 +962,16 @@ def test_is_user_allowed_to_submit_multiple_gpus_one_blocked(database, submit_le
     with database as db:
         # Set rate limit only on A100
         db.set_leaderboard_gpu_rate_limit("submit-leaderboard", "A100", 3600)
-        db.create_submission(
+        sub_id = db.create_submission(
             "submit-leaderboard",
             "file.py",
             5,
             "code",
             datetime.datetime.now(tz=datetime.timezone.utc),
             user_name="user",
         )
+        # Create a run with A100 GPU - required since rate limit query joins with runs table
+        _create_submission_run(db, sub_id, runner="A100", score=1.0)
         # Both GPUs requested, A100 is rate limited
         allowed, reason = db.is_user_allowed_to_submit(5, "submit-leaderboard", ["A100", "H100"])
         assert allowed is False