enable & fix paralleltest linter

Author: chopraanmol1

.golangci.yml

@@ -9,6 +9,7 @@ linters:
     - staticcheck
     - unused
     - modernize
+    - paralleltest
   exclusions:
     generated: lax
     paths:

backoff_test.go

@@ -8,6 +8,8 @@ import (
 )
 
 func TestExponentialBackoffNextTime(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 0*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, exponentialBackoff.Next(0))
@@ -17,6 +19,8 @@ func TestExponentialBackoffNextTime(t *testing.T) {
 }
 
 func TestExponentialBackoffWithInvalidJitter(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, -1*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, exponentialBackoff.Next(0))
@@ -26,45 +30,59 @@ func TestExponentialBackoffWithInvalidJitter(t *testing.T) {
 }
 
 func TestExponentialBackoffMaxTimeoutCrossed(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 0*time.Millisecond)
 
 	assert.Equal(t, 1000*time.Millisecond, exponentialBackoff.Next(4))
 }
 
 func TestExponentialBackoffMaxTimeoutReached(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1600*time.Millisecond, 2.0, 0*time.Millisecond)
 
 	assert.Equal(t, 1600*time.Millisecond, exponentialBackoff.Next(4))
 }
 
 func TestExponentialBackoffWhenRetryIsLessThanZero(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 0*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, exponentialBackoff.Next(-1))
 }
 
 func TestExponentialBackoffJitter0(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 0*time.Millisecond)
 	for range 10000 {
 		assert.Equal(t, 200*time.Millisecond, exponentialBackoff.Next(1))
 	}
 }
 
 func TestExponentialBackoffJitter1(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 1*time.Millisecond)
 	for range 10000 {
 		assert.True(t, 200*time.Millisecond <= exponentialBackoff.Next(1) && exponentialBackoff.Next(1) <= 201*time.Millisecond)
 	}
 }
 
 func TestExponentialBackoffJitter50(t *testing.T) {
+	t.Parallel()
+
 	exponentialBackoff := NewExponentialBackoff(100*time.Millisecond, 1000*time.Millisecond, 2.0, 50*time.Millisecond)
 	for range 10000 {
 		assert.True(t, 200*time.Millisecond <= exponentialBackoff.Next(1) && exponentialBackoff.Next(1) <= 250*time.Millisecond)
 	}
 }
 
 func TestConstantBackoffNextTime(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, 0*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, constantBackoff.Next(0))
@@ -74,6 +92,8 @@ func TestConstantBackoffNextTime(t *testing.T) {
 }
 
 func TestConstantBackoffWithInvalidJitter(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, -1*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, constantBackoff.Next(0))
@@ -83,26 +103,34 @@ func TestConstantBackoffWithInvalidJitter(t *testing.T) {
 }
 
 func TestConstantBackoffWhenRetryIsLessThanZero(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, 0*time.Millisecond)
 
 	assert.Equal(t, 100*time.Millisecond, constantBackoff.Next(-1))
 }
 
 func TestConstantBackoffJitter0(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, 0*time.Millisecond)
 	for i := range 10000 {
 		assert.Equal(t, 100*time.Millisecond, constantBackoff.Next(i))
 	}
 }
 
 func TestConstantBackoffJitter1(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, 1*time.Millisecond)
 	for i := range 10000 {
 		assert.True(t, 100*time.Millisecond <= constantBackoff.Next(i) && constantBackoff.Next(1) <= 101*time.Millisecond)
 	}
 }
 
 func TestConstantBackoffJitter50(t *testing.T) {
+	t.Parallel()
+
 	constantBackoff := NewConstantBackoff(100*time.Millisecond, 50*time.Millisecond)
 	for i := range 10000 {
 		assert.True(t, 100*time.Millisecond <= constantBackoff.Next(i) && constantBackoff.Next(1) <= 150*time.Millisecond)

httpclient/client_test.go

@@ -218,6 +218,8 @@ func TestHTTPClientPatchSuccess(t *testing.T) {
 }
 
 func TestHTTPClientGetRetriesOnFailure(t *testing.T) {
+	t.Parallel()
+
 	count := 0
 	noOfRetries := 3
 	noOfCalls := noOfRetries + 1
@@ -543,6 +545,8 @@ func TestCustomHTTPClientHeaderSuccess(t *testing.T) {
 }
 
 func TestHTTPClientContextTimeout(t *testing.T) {
+	t.Parallel()
+
 	client := NewClient(WithHTTPTimeout(1000 * time.Millisecond))
 
 	dummyHandler := func(w http.ResponseWriter, r *http.Request) {
@@ -584,6 +588,8 @@ func respBody(t *testing.T, response *http.Response) string {
 }
 
 func TestHTTPClientDoContextCancelledDuringRetry(t *testing.T) {
+	t.Parallel()
+
 	noOfRetries := 3
 	backoffInterval := 100 * time.Millisecond
 	maximumJitterInterval := 10 * time.Millisecond
@@ -622,6 +628,8 @@ func TestHTTPClientDoContextCancelledDuringRetry(t *testing.T) {
 }
 
 func TestHTTPClientDoContextCancelledBeforeRetry(t *testing.T) {
+	t.Parallel()
+
 	client := NewClient(
 		WithHTTPTimeout(10*time.Millisecond),
 		WithRetryCount(3),
@@ -654,6 +662,8 @@ func TestHTTPClientDoContextCancelledBeforeRetry(t *testing.T) {
 }
 
 func TestHTTPClientDoContextTimeoutDuringRetry(t *testing.T) {
+	t.Parallel()
+
 	noOfRetries := 3
 	backoffInterval := 100 * time.Millisecond
 	maximumJitterInterval := 10 * time.Millisecond
@@ -688,6 +698,8 @@ func TestHTTPClientDoContextTimeoutDuringRetry(t *testing.T) {
 }
 
 func TestHTTPClientMultiRetryOnTimeout(t *testing.T) {
+	t.Parallel()
+
 	noOfRetries := 3
 	backoffInterval := 4 * time.Millisecond
 	maximumJitterInterval := 2 * time.Millisecond

httpclient/options_test.go

@@ -11,6 +11,8 @@ import (
 )
 
 func TestOptionsAreSet(t *testing.T) {
+	t.Parallel()
+
 	backoffInterval := 1 * time.Millisecond
 	maximumJitterInterval := 1 * time.Millisecond
 	noOfRetries := 3
@@ -33,6 +35,8 @@ func TestOptionsAreSet(t *testing.T) {
 }
 
 func TestOptionsHaveDefaults(t *testing.T) {
+	t.Parallel()
+
 	retrier := heimdall.NewNoRetrier()
 	httpTimeout := 30 * time.Second
 	http.DefaultClient.Timeout = httpTimeout

hystrix/hystrix_client.go

@@ -223,8 +223,9 @@ func (hhc *Client) Do(request *http.Request) (*http.Response, error) {
 	return response, nil
 }
 
-func (hhc *Client) hystrixDo(request *http.Request) (response *http.Response, err error) {
-	err = hystrix.DoC(request.Context(), hhc.hystrixCommandName, func(_ context.Context) error {
+func (hhc *Client) hystrixDo(request *http.Request) (*http.Response, error) {
+	var response *http.Response
+	err := hystrix.DoC(request.Context(), hhc.hystrixCommandName, func(_ context.Context) error {
 		resp, doErr := hhc.client.Do(request)
 		if doErr != nil {
 			return doErr