Skip to content

Commit 8d982ba

Browse files
authored
fix(delight): pre-read sampled files to eliminate view/read tool denials (#48989)
1 parent a9ee388 commit 8d982ba

2 files changed

Lines changed: 13 additions & 15 deletions

File tree

.github/workflows/delight.lock.yml

Lines changed: 3 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/delight.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ pre-agent-steps:
6161
# Load historical memory (eliminates agent memory-read turns)
6262
cat memory/delight/previous-findings.json 2>/dev/null > /tmp/gh-aw/agent/previous-findings.json || echo "[]" > /tmp/gh-aw/agent/previous-findings.json
6363
cat memory/delight/improvement-themes.json 2>/dev/null > /tmp/gh-aw/agent/improvement-themes.json || echo "[]" > /tmp/gh-aw/agent/improvement-themes.json
64+
# Pre-read file contents (eliminates view/read tool denials)
65+
xargs -a /tmp/gh-aw/agent/doc-samples.txt cat > /tmp/gh-aw/agent/doc-samples-content.txt 2>/dev/null || echo "(no doc samples found)" > /tmp/gh-aw/agent/doc-samples-content.txt
66+
xargs -a /tmp/gh-aw/agent/workflow-samples.txt cat > /tmp/gh-aw/agent/workflow-samples-content.txt 2>/dev/null || echo "(no workflow samples found)" > /tmp/gh-aw/agent/workflow-samples-content.txt
67+
xargs -a /tmp/gh-aw/agent/validation-sample.txt cat > /tmp/gh-aw/agent/validation-sample-content.txt 2>/dev/null || echo "(no validation sample found)" > /tmp/gh-aw/agent/validation-sample-content.txt
6468
strict: true
6569
timeout-minutes: 30
6670
tools:
@@ -70,9 +74,6 @@ tools:
7074
- ./gh-aw --help
7175
- ./gh-aw * --help
7276
- cat /tmp/gh-aw/agent/*
73-
- xargs -a /tmp/gh-aw/agent/doc-samples.txt cat
74-
- xargs -a /tmp/gh-aw/agent/workflow-samples.txt cat
75-
- xargs -a /tmp/gh-aw/agent/validation-sample.txt cat
7677
- cat docs/src/content/docs/*.md
7778
- cat docs/src/content/docs/*.mdx
7879
- cat .github/workflows/*.md
@@ -164,11 +165,11 @@ Apply these principles when evaluating user experience in an enterprise context:
164165

165166
**Select 1-2 high-impact documentation files:**
166167

167-
The following files have been pre-sampled for this run:
168+
The following files have been pre-sampled and pre-loaded for this run:
168169

169170
```bash
170171
cat /tmp/gh-aw/agent/doc-samples.txt
171-
xargs -a /tmp/gh-aw/agent/doc-samples.txt cat
172+
cat /tmp/gh-aw/agent/doc-samples-content.txt
172173
```
173174

174175
**Evaluate each file for:**
@@ -220,11 +221,11 @@ For each selected command, run `./gh-aw [command] --help` and evaluate:
220221

221222
**Select 1-2 workflows with custom messages:**
222223

223-
The following workflows have been pre-sampled for this run:
224+
The following workflows have been pre-sampled and pre-loaded for this run:
224225

225226
```bash
226227
cat /tmp/gh-aw/agent/workflow-samples.txt
227-
xargs -a /tmp/gh-aw/agent/workflow-samples.txt cat
228+
cat /tmp/gh-aw/agent/workflow-samples-content.txt
228229
```
229230

230231
For each selected workflow, review the messages section:
@@ -248,11 +249,11 @@ For each selected workflow, review the messages section:
248249

249250
**Select 1 validation file for review:**
250251

251-
The following file has been pre-sampled for this run:
252+
The following file has been pre-sampled and pre-loaded for this run:
252253

253254
```bash
254255
cat /tmp/gh-aw/agent/validation-sample.txt
255-
xargs -a /tmp/gh-aw/agent/validation-sample.txt cat
256+
cat /tmp/gh-aw/agent/validation-sample-content.txt
256257
```
257258

258259
Review error messages in the selected file:

0 commit comments

Comments
 (0)