Commit c5e8562
committed
fix(perf-detection): handle missing description field in MN+1 DB span detector
Spans processed by the segment consumer may not always include a
`description` key. Accessing `db_span["description"]` raised KeyError
causing the entire performance problem detection to fail (SENTRY-5QVD,
210K+ events). Changed both callsites to use `.get("description", "")`.
Also downgrade `logger.exception` to `logger.warning` for
`DetectorGroup.DoesNotExist` in `_get_detector_for_group` — this is an
expected condition for legacy groups that predate DetectorGroup
associations, and the code already handles it gracefully by falling
through to alternative detector lookups (SENTRY-5R4N, 24K events, 4K
users). Using `logger.exception` was generating noisy error-level
log events with full tracebacks for a known benign case.
Fixes SENTRY-5QVD
Ref SENTRY-5R4N1 parent 3f50dd4 commit c5e8562
2 files changed
Lines changed: 3 additions & 3 deletions
File tree
- src/sentry
- issue_detection/detectors
- workflow_engine/processors
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
258 | | - | |
| 258 | + | |
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
| 283 | + | |
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| |||
0 commit comments