Skip to content

Commit c4feb6a

Browse files
committed
Re-enable debug-symbols build system stuff
1 parent 3678379 commit c4feb6a

1 file changed

Lines changed: 19 additions & 24 deletions

File tree

modules/sentry-cocoa.SConscript

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -393,25 +393,20 @@ def DeploySentryCocoa(self, target_dir):
393393
)
394394
Clean(commands, Dir(target_framework))
395395

396-
# GAP: Unlike Sentry-Dynamic, the SentryObjC-Dynamic artifact ships without
397-
# dSYM bundles, so no debug symbols are deployed for the Cocoa SDK binary.
398-
# Looks like a packaging gap.
399-
# TODO: Raise this issue in the upstream project.
400-
401396
# Debug symbols
402-
# commands.append(
403-
# env.Copy(
404-
# Dir(target_dir_path / "dSYMs" / "Sentry-ios-arm64.framework.dSYM"),
405-
# Dir(source_xcframework / "ios-arm64" / "dSYMs" / "Sentry.framework.dSYM"),
406-
# )
407-
# )
408-
409-
# commands.append(
410-
# env.Copy(
411-
# Dir(target_dir_path / "dSYMs" / "Sentry-ios-arm64_x86_64-simulator.framework.dSYM"),
412-
# Dir(source_xcframework / "ios-arm64_x86_64-simulator" / "dSYMs" / "Sentry.framework.dSYM")
413-
# )
414-
# )
397+
commands.append(
398+
env.Copy(
399+
Dir(target_dir_path / "dSYMs" / "SentryObjC-ios-arm64.framework.dSYM"),
400+
Dir(source_xcframework / "ios-arm64" / "dSYMs" / "SentryObjC.framework.dSYM"),
401+
)
402+
)
403+
404+
commands.append(
405+
env.Copy(
406+
Dir(target_dir_path / "dSYMs" / "SentryObjC-ios-arm64_x86_64-simulator.framework.dSYM"),
407+
Dir(source_xcframework / "ios-arm64_x86_64-simulator" / "dSYMs" / "SentryObjC.framework.dSYM")
408+
)
409+
)
415410

416411
elif platform == "macos":
417412
source_framework = source_xcframework / "macos-arm64_x86_64/SentryObjC.framework"
@@ -447,12 +442,12 @@ def DeploySentryCocoa(self, target_dir):
447442
)
448443

449444
# Debug symbols
450-
# commands.append(
451-
# env.Copy(
452-
# Dir(target_dir_path / "dSYMs" / "libSentry.dylib.dSYM"),
453-
# Dir(source_xcframework / "macos-arm64_x86_64" / "dSYMs" / "Sentry.framework.dSYM")
454-
# )
455-
# )
445+
commands.append(
446+
env.Copy(
447+
Dir(target_dir_path / "dSYMs" / "libSentry.dylib.dSYM"),
448+
Dir(source_xcframework / "macos-arm64_x86_64" / "dSYMs" / "SentryObjC.framework.dSYM")
449+
)
450+
)
456451

457452
else:
458453
print("ERROR: Unexpected platform: ", platform)

0 commit comments

Comments
 (0)