-
-
Notifications
You must be signed in to change notification settings - Fork 40
Expand file tree
/
Copy pathSentryOpenTelemetryVersionCheckTask.kt
More file actions
238 lines (221 loc) · 9.57 KB
/
Copy pathSentryOpenTelemetryVersionCheckTask.kt
File metadata and controls
238 lines (221 loc) · 9.57 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
package io.sentry.android.gradle.tasks
import io.sentry.android.gradle.extensions.SentryPluginExtension
import io.sentry.android.gradle.telemetry.SentryTelemetryService
import io.sentry.android.gradle.telemetry.withSentryTelemetry
import io.sentry.android.gradle.util.SemVer
import org.gradle.api.DefaultTask
import org.gradle.api.GradleException
import org.gradle.api.Project
import org.gradle.api.artifacts.component.ModuleComponentSelector
import org.gradle.api.artifacts.result.ResolvedComponentResult
import org.gradle.api.artifacts.result.ResolvedDependencyResult
import org.gradle.api.provider.Property
import org.gradle.api.provider.Provider
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.Internal
import org.gradle.api.tasks.TaskAction
import org.gradle.api.tasks.TaskProvider
/**
* Fails the build when the OpenTelemetry versions resolved on the runtime classpath were downgraded
* below what the Sentry OpenTelemetry integration requires.
*
* Sentry's `sentry-opentelemetry-*` artifacts declare the exact OpenTelemetry versions they were
* built and tested against. When another dependency management mechanism (most commonly
* `io.spring.dependency-management` / the Spring Boot BOM) forces a lower OpenTelemetry version,
* running against those downgraded versions can cause `ClassNotFoundException` /
* `NoSuchMethodError` at runtime. We detect that downgrade here and fail fast with actionable
* guidance instead of letting it blow up at runtime.
*/
abstract class SentryOpenTelemetryVersionCheckTask : DefaultTask() {
@get:Internal abstract val rootComponent: Property<ResolvedComponentResult>
@get:Input abstract val docsUrl: Property<String>
@get:Input abstract val springDependencyManagementApplied: Property<Boolean>
@get:Input abstract val hasSentryOpenTelemetryDependency: Property<Boolean>
@get:Input abstract val verifyEnabled: Property<Boolean>
init {
description =
"Checks that the resolved OpenTelemetry versions are compatible with the Sentry " +
"OpenTelemetry integration"
group = "verification"
// Reference task-owned properties only (not the extension/project) so the task stays
// configuration-cache compatible.
@Suppress("LeakingThis")
onlyIf { verifyEnabled.get() && hasSentryOpenTelemetryDependency.get() }
}
@TaskAction
fun action() {
val mismatches = collectDowngrades(rootComponent.get())
if (mismatches.isNotEmpty()) {
throw GradleException(
buildMessage(mismatches, docsUrl.get(), springDependencyManagementApplied.get())
)
}
}
companion object {
private const val SENTRY_GROUP = "io.sentry"
private const val SENTRY_OPENTELEMETRY_ARTIFACT_PREFIX = "sentry-opentelemetry-"
private const val OTEL_GROUP = "io.opentelemetry"
private const val SPRING_DEPENDENCY_MANAGEMENT_PLUGIN_ID = "io.spring.dependency-management"
internal data class VersionMismatch(
val module: String,
val requested: String,
val resolved: String,
)
/**
* Walks the resolved dependency graph and returns, for every OpenTelemetry module that a
* `sentry-opentelemetry-*` artifact depends on, the ones whose resolved version is lower than
* the version Sentry requested.
*/
internal fun collectDowngrades(root: ResolvedComponentResult): List<VersionMismatch> {
val mismatches = linkedMapOf<String, VersionMismatch>()
val visited = mutableSetOf<Any>()
val stack = ArrayDeque<ResolvedComponentResult>()
stack.addLast(root)
while (stack.isNotEmpty()) {
val component = stack.removeLast()
if (!visited.add(component.id)) {
continue
}
val fromSentryOpenTelemetry = component.isSentryOpenTelemetryArtifact()
for (dependency in component.dependencies) {
if (dependency !is ResolvedDependencyResult) {
continue
}
if (fromSentryOpenTelemetry) {
val requested = dependency.requested
if (requested is ModuleComponentSelector && requested.isOpenTelemetry()) {
val resolvedVersion = dependency.selected.moduleVersion?.version
if (resolvedVersion != null && isDowngrade(requested.version, resolvedVersion)) {
val module = "${requested.group}:${requested.module}"
mismatches.putIfAbsent(
module,
VersionMismatch(module, requested.version, resolvedVersion),
)
}
}
}
stack.addLast(dependency.selected)
}
}
return mismatches.values.toList()
}
private fun ResolvedComponentResult.isSentryOpenTelemetryArtifact(): Boolean {
val moduleVersion = moduleVersion ?: return false
return moduleVersion.group == SENTRY_GROUP &&
moduleVersion.name.startsWith(SENTRY_OPENTELEMETRY_ARTIFACT_PREFIX)
}
// Matches every OpenTelemetry group (io.opentelemetry, io.opentelemetry.instrumentation,
// io.opentelemetry.semconv, ...) so any OTel module a sentry-opentelemetry-* artifact declares
// is covered as that set grows. We only ever inspect edges declared by Sentry's own artifacts,
// so this never flags unrelated OpenTelemetry usage.
private fun ModuleComponentSelector.isOpenTelemetry(): Boolean =
group == OTEL_GROUP || group.startsWith("$OTEL_GROUP.")
private fun isDowngrade(requested: String, resolved: String): Boolean {
// A blank requested version means it was declared without a concrete version (e.g. managed
// elsewhere); there is nothing to compare against, so don't flag it.
if (requested.isBlank() || requested == resolved) {
return false
}
return try {
SemVer.parse(resolved) < SemVer.parse(requested)
} catch (e: IllegalArgumentException) {
// Non-semver version strings can't be compared reliably; err on the side of not failing.
false
}
}
internal fun buildMessage(
mismatches: List<VersionMismatch>,
docsUrl: String,
springDependencyManagementApplied: Boolean,
): String {
val details =
mismatches.joinToString(separator = "\n") { mismatch ->
" - ${mismatch.module}: Sentry requires ${mismatch.requested} " +
"but ${mismatch.resolved} was resolved"
}
val fix =
if (springDependencyManagementApplied) {
// io.spring.dependency-management enforces its managed versions via a resolution strategy
// that overrides Gradle platform() constraints, so the BOM has to be imported through the
// plugin's own API to win.
"""
|To fix this, import the Sentry OpenTelemetry BOM through io.spring.dependency-management so
|its versions win dependency resolution:
|
| dependencyManagement {
| imports {
| mavenBom("io.sentry:sentry-opentelemetry-bom:<sentryVersion>")
| }
| }
"""
.trimMargin()
} else {
"""
|To fix this, add the Sentry OpenTelemetry BOM as a platform dependency so its versions win
|dependency resolution:
|
| dependencies {
| implementation(platform("io.sentry:sentry-opentelemetry-bom:<sentryVersion>"))
| }
"""
.trimMargin()
}
return """
|Sentry detected that OpenTelemetry was downgraded below the version its integration requires.
|
|The Sentry OpenTelemetry integration was built against specific OpenTelemetry versions,
|but the following were downgraded by another dependency management mechanism:
|
|$details
|
|Running with these downgraded OpenTelemetry versions can cause
|ClassNotFoundException / NoSuchMethodError at runtime.
|
|$fix
|
|See $docsUrl for details.
|
|You can disable this check with:
|
| sentry {
| autoInstallation.verifyOpenTelemetryVersions = false
| }
"""
.trimMargin()
}
fun register(
project: Project,
extension: SentryPluginExtension,
sentryTelemetryProvider: Provider<SentryTelemetryService>,
configurationName: String,
docsUrl: String,
): TaskProvider<SentryOpenTelemetryVersionCheckTask> {
return project.tasks.register(
"verifySentryOpenTelemetryVersions",
SentryOpenTelemetryVersionCheckTask::class.java,
) { task ->
val configuration = project.configurations.getByName(configurationName)
task.rootComponent.set(configuration.incoming.resolutionResult.rootComponent)
task.docsUrl.set(docsUrl)
// Resolved lazily (at end of configuration) so it reflects the final plugin set regardless
// of the order plugins are applied in the consumer's build.
task.springDependencyManagementApplied.set(
project.provider {
project.pluginManager.hasPlugin(SPRING_DEPENDENCY_MANAGEMENT_PLUGIN_ID)
}
)
// Cheap declared-dependency check (no graph resolution) so we skip entirely for the common
// case of projects that don't use Sentry OpenTelemetry at all.
task.hasSentryOpenTelemetryDependency.set(
project.provider {
configuration.allDependencies.any {
it.group == SENTRY_GROUP && it.name.startsWith(SENTRY_OPENTELEMETRY_ARTIFACT_PREFIX)
}
}
)
task.verifyEnabled.set(extension.autoInstallation.verifyOpenTelemetryVersions)
task.withSentryTelemetry(extension, sentryTelemetryProvider)
}
}
}
}