fix: resolve MyPy type checking and pre-commit issues - Add proper type annotations for all functions - Fix Sequence to list conversion for SQLModel results - Add FastAPI import for proper typing - Fix end-of-file and formatting issues

Author: alvidofaisal

backend/app/api/routes/analytics.py

@@ -52,12 +52,13 @@ class ItemAnalyticsTrends(pydantic.BaseModel):
 @router.get("/user-summary", response_model=UserAnalyticsSummary)
 def get_user_summary(
     session: SessionDep,
+) -> (
+    UserAnalyticsSummary
 ):  # get_current_active_superuser is imported but not used here yet
     with tracer.start_as_current_span("user_summary_endpoint"):
-        users_list: list[User]
         with tracer.start_as_current_span("fetch_all_users_sql"):
             statement = select(User)
-            users_list = session.exec(statement).all()
+            users_list = list(session.exec(statement).all())
 
         if not users_list:
             return UserAnalyticsSummary(
@@ -134,12 +135,11 @@ def get_user_summary(
 
 
 @router.get("/item-trends", response_model=ItemAnalyticsTrends)
-def get_item_trends(session: SessionDep):
+def get_item_trends(session: SessionDep) -> ItemAnalyticsTrends:
     with tracer.start_as_current_span("item_trends_endpoint"):
-        items_list: list[Item]
         with tracer.start_as_current_span("fetch_all_items_sql"):
             statement = select(Item)
-            items_list = session.exec(statement).all()
+            items_list = list(session.exec(statement).all())
 
         if not items_list:
             return ItemAnalyticsTrends(

backend/app/core/telemetry.py

@@ -1,5 +1,6 @@
 import os
 
+from fastapi import FastAPI
 from opentelemetry import trace
 from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
 from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor
@@ -12,7 +13,7 @@
 from app.core.db import engine  # Assuming engine is in app.core.db
 
 
-def init_telemetry(app):
+def init_telemetry(app: FastAPI) -> None:
     # Set service name, try from settings or default
     service_name = getattr(settings, "OTEL_SERVICE_NAME", "fastapi-application")
 

backend/pyproject.toml

@@ -35,7 +35,7 @@ dev-dependencies = [
     "pytest<8.0.0,>=7.4.3",
     "mypy<2.0.0,>=1.8.0",
     "ruff<1.0.0,>=0.2.2",
-    "pre-commit<4.0.0,>=3.6.2",
+    "pre-commit>=3.6.2,<4.0.0",
     "types-passlib<2.0.0.0,>=1.7.7.20240106",
     "coverage<8.0.0,>=7.4.3",
 ]

development.md

@@ -204,4 +204,4 @@ Adminer: http://localhost.tiangolo.com:8080
 
 Traefik UI: http://localhost.tiangolo.com:8090
 
-MailCatcher: http://localhost.tiangolo.com:1080
+MailCatcher: http://localhost.tiangolo.com:1080

frontend/.gitignore

@@ -27,4 +27,4 @@ openapi.json
 /playwright-report/
 /blob-report/
 /playwright/.cache/
-/playwright/.auth/
+/playwright/.auth/