refactor: replace backface culling map with full property backup in ColoringStruct

Author: isaccunha

vtkext/private/module/vtkF3DMetaImporter.h

@@ -90,9 +90,11 @@ class vtkF3DMetaImporter : public vtkF3DImporter
       this->Actor->vtkProp3D::ShallowCopy(originalActor);
       this->Actor->SetMapper(this->Mapper);
       this->Mapper->InterpolateScalarsBeforeMappingOn();
+      this->OriginalProperty->DeepCopy(originalActor->GetProperty());
     }
     vtkNew<vtkActor> Actor;
     vtkNew<vtkPolyDataMapper> Mapper;
+    vtkNew<vtkProperty> OriginalProperty;
     vtkActor* OriginalActor;
   };
 

vtkext/private/module/vtkF3DRenderer.cxx

@@ -285,7 +285,6 @@ void vtkF3DRenderer::ReleaseGraphicsResources(vtkWindow* w)
 void vtkF3DRenderer::Initialize()
 {
   this->OriginalLightIntensities.clear();
-  this->OriginalBackfaceCulling.clear();
   this->RemoveAllViewProps();
   this->RemoveAllLights();
 
@@ -2506,6 +2505,20 @@ void vtkF3DRenderer::ConfigureActorsProperties()
 
   for (const auto& coloring : this->Importer->GetColoringActorsAndMappers())
   {
+    vtkProperty* prop = coloring.Actor->GetProperty();
+    vtkProperty* origProp = coloring.OriginalActor->GetProperty();
+
+    if (setBackfaceCulling)
+    {
+      prop->SetBackfaceCulling(backfaceCulling);
+      origProp->SetBackfaceCulling(backfaceCulling);
+    }
+    else
+    {
+      prop->SetBackfaceCulling(coloring.OriginalProperty->GetBackfaceCulling());
+      origProp->SetBackfaceCulling(coloring.OriginalProperty->GetBackfaceCulling());
+    }
+
     if (this->EdgeVisible.has_value())
     {
       coloring.Actor->GetProperty()->SetEdgeVisibility(this->EdgeVisible.value());
@@ -2523,25 +2536,6 @@ void vtkF3DRenderer::ConfigureActorsProperties()
       coloring.Actor->GetProperty()->SetPointSize(this->PointSize.value());
       coloring.OriginalActor->GetProperty()->SetPointSize(this->PointSize.value());
     }
-    
-    vtkProperty* prop = coloring.Actor->GetProperty();
-    vtkProperty* origProp = coloring.OriginalActor->GetProperty();
-    auto it = this->OriginalBackfaceCulling.find(prop);
-    if (it == this->OriginalBackfaceCulling.end())
-    {
-      this->OriginalBackfaceCulling[prop] = (prop->GetBackfaceCulling() != 0);
-    }
-
-    if (setBackfaceCulling)
-    {
-      prop->SetBackfaceCulling(backfaceCulling);
-      origProp->SetBackfaceCulling(backfaceCulling);
-    }
-    else
-    {
-      prop->SetBackfaceCulling(this->OriginalBackfaceCulling[prop]);
-      origProp->SetBackfaceCulling(this->OriginalBackfaceCulling[prop]);
-    }
 
     if (surfaceColor)
     {

vtkext/private/module/vtkF3DRenderer.h

@@ -798,7 +798,6 @@ class vtkF3DRenderer : public vtkOpenGLRenderer
   std::string CachePath;
 
   std::optional<std::string> BackfaceType;
-  std::map<vtkProperty*, bool> OriginalBackfaceCulling;
 
   std::optional<std::string> FinalShader;