Show error message when creation of customization failed on server

When the server fails to create a customization and replies with an
error, show this error to the user as error message and don't show
the message that it was successful.

Only show success message when the server replied with 200.

Fixes #356

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Author: bhufmann

vscode-trace-common/src/messages/vscode-messages.ts

@@ -11,6 +11,7 @@ export const VSCODE_MESSAGES = {
     EXPERIMENT_SELECTED: 'experimentSelected',
     EXPERIMENT_UPDATED: 'experimentUpdated',
     EXPERIMENT_CLOSED: 'experimentClosed',
+    INFO: 'info',
     NEW_STATUS: 'newStatus',
     OPENED_TRACES_UPDATED: 'openedTracesUpdated',
     OPEN_OVERVIEW: 'open-overview',
@@ -63,6 +64,7 @@ export const setTspClient: NotificationType<any> = { method: VSCODE_MESSAGES.SET
 export const connectionStatus: NotificationType<any> = { method: VSCODE_MESSAGES.CONNECTION_STATUS };
 
 export const alert: NotificationType<any> = { method: VSCODE_MESSAGES.ALERT };
+export const info: NotificationType<any> = { method: VSCODE_MESSAGES.INFO };
 export const newStatus: NotificationType<any> = { method: VSCODE_MESSAGES.NEW_STATUS };
 export const removeStatus: NotificationType<any> = { method: VSCODE_MESSAGES.REMOVE_STATUS };
 

vscode-trace-extension/src/json-editor/json-editor.ts

@@ -317,7 +317,6 @@ export class JsonConfigEditor {
                       );
 
                 if (submit === 'Yes') {
-                    vscode.window.showInformationMessage('Configuration submitted successfully');
                     return validation.content;
                 }
 

vscode-trace-extension/src/trace-explorer/available-views/trace-explorer-available-views-webview-provider.ts

@@ -9,7 +9,9 @@ import {
     connectionStatus,
     outputAdded,
     experimentSelected,
-    setTspClient
+    setTspClient,
+    alert,
+    info
 } from 'vscode-trace-common/lib/messages/vscode-messages';
 import { ClientType, getTspClientUrl } from 'vscode-trace-extension/src/utils/backend-tsp-client-provider';
 import { TraceViewerPanel } from '../../trace-viewer-panel/trace-viewer-webview-panel';
@@ -66,6 +68,14 @@ export class TraceExplorerAvailableViewsProvider extends AbstractTraceExplorerPr
         }
     };
 
+    private readonly _onVscodeAlert = (text: any): void => {
+        vscode.window.showErrorMessage(text);
+    };
+
+    private readonly _onVscodeInfo = (text: any): void => {
+        vscode.window.showInformationMessage(text);
+    };
+
     protected init(
         _webviewView: vscode.WebviewView,
         _context: vscode.WebviewViewResolveContext,
@@ -82,6 +92,8 @@ export class TraceExplorerAvailableViewsProvider extends AbstractTraceExplorerPr
         this._disposables.push(
             this._messenger.onNotification<any>(experimentSelected, this._onVscodeExperimentSelected, options)
         );
+        this._disposables.push(this._messenger.onNotification<string>(alert, this._onVscodeAlert, options));
+        this._disposables.push(this._messenger.onNotification<string>(info, this._onVscodeInfo, options));
         signalManager().on('EXPERIMENT_SELECTED', this._onExperimentSelected);
     }
 

vscode-trace-webviews/src/common/vscode-message-manager.ts

@@ -8,12 +8,14 @@ import { Experiment } from 'tsp-typescript-client/lib/models/experiment';
 import { MarkerSet } from 'tsp-typescript-client/lib/models/markerset';
 import { HOST_EXTENSION, MessageParticipant, MessengerAPI } from 'vscode-messenger-common';
 import {
+    alert,
     closeTrace,
     contextMenuItemClicked,
     deleteTrace,
     experimentClosed,
     experimentSelected,
     experimentUpdated,
+    info,
     markerCategoryContext,
     markerSetsContext,
     newStatus,
@@ -73,6 +75,14 @@ export class VsCodeMessageManager extends Messages.MessageManager implements Sta
         this._messenger.sendNotification(connectionStatus, _receiver ?? HOST_EXTENSION, { status });
     }
 
+    notifyError(message: string, _receiver?: MessageParticipant | undefined): void {
+        this._messenger.sendNotification(alert, _receiver ?? HOST_EXTENSION, message);
+    }
+
+    notifyInfo(message: string, _receiver?: MessageParticipant | undefined): void {
+        this._messenger.sendNotification(info, _receiver ?? HOST_EXTENSION, message);
+    }
+
     /**************************************************************************
      * Trace Explorer React APP
      *************************************************************************/

vscode-trace-webviews/src/trace-explorer/available-views/vscode-trace-explorer-views-widget.tsx

@@ -108,8 +108,22 @@ class TraceExplorerViewsWidget extends React.Component<{}, AvailableViewsAppStat
         const { name, description, sourceTypeId, parameters } = userConfig;
 
         const options = new OutputConfigurationQuery(name, description, sourceTypeId, parameters);
-        await tsp.createDerivedOutput(experiment.UUID, output.id, options);
-        return;
+        const response = await tsp.createDerivedOutput(experiment.UUID, output.id, options);
+        if (!response.isOk()) {
+            const errorResponse = response.getErrorResponse();
+            let message: string = `Customization failed (${response.getStatusCode()}): '${response.getStatusMessage()}'`;
+            if (errorResponse) {
+                message = `Customization failed (${response.getStatusCode()}): '${errorResponse.title}'`;
+                // TODO Remove workaround when following fix is available
+                // https://github.com/eclipse-cdt-cloud/tsp-typescript-client/issues/148
+                if ('detail' in errorResponse) {
+                    message = message + `. Details: '${errorResponse.detail}'`;
+                }
+            }
+            this._signalHandler.notifyError(message);
+            return;
+        }
+        this._signalHandler.notifyInfo('Configuration submitted successfully');
     };
 
     public render(): React.ReactNode {