Skip to content

Commit bb75633

Browse files
ReubenBondCopilot
andcommitted
fix(telemetry): fully qualify RPC method attribute
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 29ff950 commit bb75633

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/Orleans.Core/Diagnostics/ActivityPropagationGrainCallFilter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected static async Task Process(IGrainCallContext context, Activity activity
5252
// RPC attributes from https://opentelemetry.io/docs/specs/semconv/rpc/
5353
activity.SetTag(ActivityTagKeys.RpcSystem, RpcSystem);
5454
activity.SetTag(ActivityTagKeys.RpcService, context.InterfaceName);
55-
activity.SetTag(ActivityTagKeys.RpcMethod, context.MethodName);
55+
activity.SetTag(ActivityTagKeys.RpcMethod, $"{context.InterfaceName}/{context.MethodName}");
5656

5757
if (activity.IsAllDataRequested)
5858
{

test/Orleans.Runtime.Tests/GrainCallTraceContextPropagationTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,9 @@ public async Task GrainCallUsesCurrentRpcSemanticConventionKeys()
115115
Assert.NotNull(activity);
116116
Assert.Equal("orleans", activity.GetTagItem("rpc.system.name"));
117117
Assert.Equal(typeof(ITraceContextPropagationGrain).FullName, activity.GetTagItem("orleans.rpc.service"));
118-
Assert.Equal(nameof(ITraceContextPropagationGrain.GetTraceContextInfo), activity.GetTagItem("rpc.method"));
118+
Assert.Equal(
119+
$"{typeof(ITraceContextPropagationGrain).FullName}/{nameof(ITraceContextPropagationGrain.GetTraceContextInfo)}",
120+
activity.GetTagItem("rpc.method"));
119121
Assert.Null(activity.GetTagItem("rpc.system"));
120122
Assert.Null(activity.GetTagItem("rpc.service"));
121123
Assert.NotNull(activity.GetTagItem("orleans.rpc.target_id"));

0 commit comments

Comments
 (0)