internal res object tests

some, need more.

Author: dormando

proxy_internal.c

@@ -231,6 +231,7 @@ static inline int _mcplib_internal_run(LIBEVENT_THREAD *t, mcp_request_t *rq, mc
     r->cmd = rq->pr.command;
     // Always return OK from here as this is signalling an internal error.
     r->status = MCMC_OK;
+    // TODO: r->mode = inherit the noreply/quiet mode.
 
     return 0;
 }

t/proxyinternal.lua

@@ -21,13 +21,26 @@ function mcp_config_routes(zones)
     fg:ready({ n = "internal", f = function(rctx)
         return function(r)
             local k = r:key()
+            local cmd = r:command()
             if string.find(k, "^/sub/") then
                 return rctx:enqueue_and_wait(r, hsub)
             else
                 if k == "log" then
                     local res = rctx:enqueue_and_wait(r, h)
                     mcp.log_req(r, res, "testing")
                     return res
+                elseif cmd == mcp.CMD_MG and k == "response/hit" then
+                    local res = rctx:enqueue_and_wait(r, h)
+                    return string.format("SERVER_ERROR res:hit = %q\r\n", res:hit())
+                elseif cmd == mcp.CMD_MG and k == "response/code" then
+                    local res = rctx:enqueue_and_wait(r, h)
+                    return string.format("SERVER_ERROR res:code = %q\r\n", res:code())
+                elseif cmd == mcp.CMD_MG and k == "response/line" then
+                    local res = rctx:enqueue_and_wait(r, h)
+                    return string.format("SERVER_ERROR res:line = %q\r\n", res:line())
+                elseif cmd == mcp.CMD_MG and k == "response/vlen" then
+                    local res = rctx:enqueue_and_wait(r, h)
+                    return string.format("SERVER_ERROR res:vlen = %q\r\n", res:vlen())
                 else
                     return rctx:enqueue_and_wait(r, h)
                 end

t/proxyinternal.t

@@ -40,12 +40,74 @@ $ps->autoflush(1);
 $t->set_c($ps);
 
 {
+    test_res();
     test_basics();
     test_fetch_extstore();
     test_pipe_extstore();
     test_etc();
 }
 
+# ensure the result objects still function for internal RES.
+# NOTE: could cuddle the mode with P or L flags but I wanted to seed the item
+# for each individual test.
+sub test_res {
+    subtest 'response/hit' => sub {
+        $t->c_send("mg response/hit v t\r\n");
+        $t->c_recv("SERVER_ERROR res:hit = false\r\n");
+
+        $t->c_send("ms response/hit 2\r\nhi\r\n");
+        $t->c_recv("HD\r\n", "seeding hit response");
+
+        $t->c_send("mg response/hit v t\r\n");
+        $t->c_recv("SERVER_ERROR res:hit = true\r\n");
+
+        $t->clear();
+    };
+
+    # NOTE: if this test fails it may be because MCMC_CODE numbers changed
+    subtest 'response/code' => sub {
+        $t->c_send("mg response/code v t\r\n");
+        $t->c_recv("SERVER_ERROR res:code = 17\r\n");
+
+        $t->c_send("ms response/code 2\r\nhi\r\n");
+        $t->c_recv("HD\r\n", "seeding response");
+
+        $t->c_send("mg response/code v t\r\n");
+        $t->c_recv("SERVER_ERROR res:code = 15\r\n");
+
+        $t->clear();
+    };
+
+    subtest 'response/line' => sub {
+        $t->c_send("mg response/line v t\r\n");
+        $t->c_recv("SERVER_ERROR res:line = nil\r\n");
+
+        $t->c_send("ms response/line 2\r\nhi\r\n");
+        $t->c_recv("HD\r\n", "seeding response");
+
+        $t->c_send("mg response/line v t s h\r\n");
+        $t->c_recv("SERVER_ERROR res:line = \"t-1 s2 h0\"\r\n");
+
+        $t->clear();
+    };
+
+    subtest 'response/line' => sub {
+        $t->c_send("mg response/vlen v t\r\n");
+        $t->c_recv("SERVER_ERROR res:vlen = 0\r\n");
+
+        $t->c_send("ms response/vlen 5\r\nhello\r\n");
+        $t->c_recv("HD\r\n", "seeding response");
+
+        $t->c_send("mg response/vlen v t\r\n");
+        $t->c_recv("SERVER_ERROR res:vlen = 5\r\n");
+
+        $t->clear();
+    };
+
+    # TODO: test quiet and noreply.
+
+}
+
 sub test_basics {
     subtest 'ms/mg' => sub {
         $t->c_send("ms /b/a 2\r\nhi\r\n");