Skip to content

Commit 917933a

Browse files
authored
Merge pull request #253 from dmzz-yyhyy/code_clean
代码清理
2 parents 89c7101 + f8173c5 commit 917933a

19 files changed

Lines changed: 48 additions & 50 deletions

File tree

app/build.gradle.kts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import org.jetbrains.kotlin.compose.compiler.gradle.ComposeFeatureFlag
1+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
2+
import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
23

34
plugins {
45
alias(libs.plugins.android.application)
@@ -19,7 +20,7 @@ android {
1920
minSdk = 24
2021
targetSdk = 36
2122
// 版本号为x.y.z则versionCode为x*1000000+y*10000+z*1000+debug版本号(开发需要时迭代, 三位数)
22-
versionCode = 1_01_01_008
23+
versionCode = 1_01_01_009
2324
versionName = "1.1.1"
2425

2526
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
@@ -47,11 +48,8 @@ android {
4748
}
4849
compileOptions {
4950
isCoreLibraryDesugaringEnabled = true
50-
sourceCompatibility = JavaVersion.VERSION_1_8
51-
targetCompatibility = JavaVersion.VERSION_1_8
52-
}
53-
kotlinOptions {
54-
jvmTarget = "1.8"
51+
sourceCompatibility = JavaVersion.VERSION_17
52+
targetCompatibility = JavaVersion.VERSION_17
5553
}
5654
buildFeatures {
5755
compose = true
@@ -67,11 +65,13 @@ android {
6765
}
6866
composeCompiler {
6967
includeSourceInformation = true
68+
}
69+
}
7070

71-
featureFlags = setOf(
72-
ComposeFeatureFlag.StrongSkipping.disabled(),
73-
ComposeFeatureFlag.OptimizeNonSkippingGroups
74-
)
71+
tasks.withType<KotlinJvmCompile>().configureEach {
72+
compilerOptions {
73+
jvmTarget.set(JvmTarget.JVM_17)
74+
freeCompilerArgs.add("-opt-in=kotlin.RequiresOptIn")
7575
}
7676
}
7777

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/data/download/DownloadType.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import androidx.annotation.DrawableRes
44
import indi.dmzz_yyhyy.lightnovelreader.R
55

66
enum class DownloadType(
7-
@DrawableRes val icon: Int,
7+
@field:DrawableRes val icon: Int,
88
val typeName: String
99
) {
1010
EPUB_EXPORT(R.drawable.output_24px, "导出为EPUB"),

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/data/format/FormatRepository.kt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import indi.dmzz_yyhyy.lightnovelreader.data.exploration.ExplorationDisplayBook
99
import indi.dmzz_yyhyy.lightnovelreader.data.local.room.dao.FormattingRuleDao
1010
import indi.dmzz_yyhyy.lightnovelreader.data.local.room.entity.FormattingRuleEntity
1111
import indi.dmzz_yyhyy.lightnovelreader.data.text.TextProcessor
12-
import indi.dmzz_yyhyy.lightnovelreader.utils.debugPrint
1312
import kotlinx.coroutines.CoroutineScope
1413
import kotlinx.coroutines.Dispatchers
1514
import kotlinx.coroutines.launch
@@ -25,11 +24,8 @@ class FormatRepository @Inject constructor(
2524
private val processorMap = mutableMapOf<Int, SnapshotStateList<FormattingRule>>()
2625

2726
init {
28-
println("fuck u!!!!")
2927
CoroutineScope(Dispatchers.IO).launch {
3028
formattingRuleDao.getAllBookRuleEntityFlow().collect { formattingRuleEntities ->
31-
println("wdasdasad")
32-
println(formattingRuleEntities)
3329
processorMap.values.forEach { it.clear() }
3430
for (formattingRule in formattingRuleEntities) {
3531
if (!processorMap.contains(formattingRule.bookId))
@@ -45,7 +41,6 @@ class FormatRepository @Inject constructor(
4541
)
4642
)
4743
}
48-
println(processorMap)
4944
}
5045
}
5146
}
@@ -157,7 +152,7 @@ class FormatRepository @Inject constructor(
157152
fun getStateBookFormattingRules(bookId: Int): List<FormattingRule> {
158153
if (!processorMap.contains(bookId))
159154
processorMap[bookId] = mutableStateListOf()
160-
return processorMap[bookId]!!.debugPrint()
155+
return processorMap[bookId]!!
161156
}
162157

163158
override fun processText(text: String): String = text

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/data/logging/LoggerRepository.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import kotlin.coroutines.cancellation.CancellationException
2424

2525
@Singleton
2626
class LoggerRepository @Inject constructor(
27-
@ApplicationContext private val context: Context,
27+
@param:ApplicationContext @field:ApplicationContext private val context: Context,
2828
) {
2929
private val coroutineScope = CoroutineScope(Dispatchers.IO)
3030
private val logsDir = File(context.cacheDir, "logs")

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/data/update/UpdateCheckRepository.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import javax.inject.Singleton
2727

2828
@Singleton
2929
class UpdateCheckRepository @Inject constructor(
30-
@ApplicationContext private val context: Context,
30+
@param:ApplicationContext @field:ApplicationContext private val context: Context,
3131
private val userDataRepository: UserDataRepository,
3232
private val ketch: Ketch
3333
) {

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/data/web/exploration/filter/SliderFilter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ abstract class SliderFilter(
77
val description: String,
88
defaultValue: Float,
99
val valueRange: ClosedFloatingPointRange<Float>,
10-
@IntRange(from = 0) val steps: Int = 0,
10+
@field:IntRange(from = 0) val steps: Int = 0,
1111
private val onChange: () -> Unit
1212
) : Filter() {
1313
abstract var enabled: Boolean

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/theme/LightNovelReaderTheme.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ fun LightNovelReaderTheme(
9292
}
9393

9494
val (language, variant) = appLocale.split("-")
95-
LocaleUtil.set(context, language = language, variant = variant)
95+
LocaleUtil.set(language = language, variant = variant)
9696

9797
CompositionLocalProvider(LocalAppTheme provides appTheme) {
9898
MaterialTheme(

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/ui/book/detail/BookInfoBottomSheet.kt

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package indi.dmzz_yyhyy.lightnovelreader.ui.book.detail
22

3+
import android.content.ClipData
34
import android.widget.Toast
45
import androidx.compose.animation.AnimatedVisibility
56
import androidx.compose.foundation.ExperimentalFoundationApi
@@ -17,9 +18,12 @@ import androidx.compose.material3.ModalBottomSheet
1718
import androidx.compose.material3.SheetState
1819
import androidx.compose.material3.Text
1920
import androidx.compose.runtime.Composable
21+
import androidx.compose.runtime.rememberCoroutineScope
2022
import androidx.compose.ui.Alignment
2123
import androidx.compose.ui.Modifier
2224
import androidx.compose.ui.graphics.painter.Painter
25+
import androidx.compose.ui.platform.ClipEntry
26+
import androidx.compose.ui.platform.LocalClipboard
2327
import androidx.compose.ui.platform.LocalClipboardManager
2428
import androidx.compose.ui.platform.LocalContext
2529
import androidx.compose.ui.res.painterResource
@@ -32,6 +36,7 @@ import indi.dmzz_yyhyy.lightnovelreader.R
3236
import indi.dmzz_yyhyy.lightnovelreader.data.book.BookInformation
3337
import indi.dmzz_yyhyy.lightnovelreader.data.book.BookVolumes
3438
import indi.dmzz_yyhyy.lightnovelreader.theme.AppTypography
39+
import kotlinx.coroutines.launch
3540
import java.text.NumberFormat
3641
import java.time.format.DateTimeFormatter
3742

@@ -44,6 +49,8 @@ fun BookInfoBottomSheet(
4449
isVisible: Boolean,
4550
onDismissRequest: () -> Unit,
4651
) {
52+
val coroutineScope = rememberCoroutineScope()
53+
4754
@Composable
4855
fun InfoItem(
4956
title: String? = "",
@@ -81,7 +88,7 @@ fun BookInfoBottomSheet(
8188
verticalAlignment = Alignment.CenterVertically
8289
) {
8390
val context = LocalContext.current
84-
val clipboardManager = LocalClipboardManager.current
91+
val clipboard = LocalClipboard.current
8592

8693
Text(
8794
text = content,
@@ -91,9 +98,13 @@ fun BookInfoBottomSheet(
9198
.combinedClickable(
9299
onClick = {},
93100
onLongClick = {
94-
clipboardManager.setText(AnnotatedString(content))
95-
Toast.makeText(context, "内容已复制", Toast.LENGTH_SHORT)
96-
.show()
101+
coroutineScope.launch {
102+
val clipData = ClipData.newPlainText("content", content)
103+
val clipEntry = ClipEntry(clipData = clipData)
104+
clipboard.setClipEntry(clipEntry = clipEntry)
105+
Toast.makeText(context, "内容已复制", Toast.LENGTH_SHORT)
106+
.show()
107+
}
97108
},
98109
)
99110
)

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/ui/dialog/SliderValueDialogViewModel.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ class SliderValueDialogViewModel @Inject constructor(
1919

2020
fun init(floatUserDataPath: String): Flow<Float> {
2121
floatUserData = userDataRepository.floatUserData(floatUserDataPath)
22-
println(floatUserDataPath)
23-
val value = floatUserData!!.getFlowWithDefault(Float.NaN).onEach { println("value got $it") }
22+
val value = floatUserData!!.getFlowWithDefault(Float.NaN)
2423
return value
2524
}
2625

@@ -29,7 +28,6 @@ class SliderValueDialogViewModel @Inject constructor(
2928
return
3029
}
3130
CoroutineScope(Dispatchers.IO).launch {
32-
println("SET VALUE $value")
3331
floatUserData?.asynchronousSet(value)
3432
}
3533
}

app/src/main/kotlin/indi/dmzz_yyhyy/lightnovelreader/utils/ImageDownloader.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class ImageDownloader(
6464
return btData
6565
} catch (e: Exception) {
6666
e.printStackTrace()
67-
println(strUrl)
6867
}
6968
return null
7069
}

0 commit comments

Comments
 (0)