Skip to content

Commit a04559c

Browse files
author
Yasser Toruno
committed
remove valkey from test matrix
valkey installation can just be decided based on python version
1 parent 3a648cb commit a04559c

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

.github/workflows/test.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,13 @@ on: [push]
55
jobs:
66
python-tests:
77
runs-on: ubuntu-latest
8-
name: Python ${{ matrix.python-version }} - Django ${{ matrix.django-version }}${{ matrix.valkey && ' (valkey)' || '' }}
8+
name: Python ${{ matrix.python-version }} - Django ${{ matrix.django-version }}
99

1010
strategy:
1111
fail-fast: false
1212
matrix:
1313
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
1414
django-version: ["4.2", "5.2", "6.0"]
15-
valkey: [false, true]
1615
exclude:
1716
# -------------------------------------------------
1817
# django 6.0 requires python >=3.12
@@ -33,11 +32,6 @@ jobs:
3332
# -------------------------------------------------
3433
- python-version: "3.14"
3534
django-version: "4.2"
36-
# -------------------------------------------------
37-
# valkey requires python >=3.10
38-
# -------------------------------------------------
39-
- python-version: "3.9"
40-
valkey: true
4135
services:
4236
redis:
4337
image: redis:7.4.1
@@ -66,7 +60,7 @@ jobs:
6660

6761
- name: Install package and dependencies
6862
run: |
69-
if [ "${{ matrix.valkey }}" = "false" ]; then
63+
if [ "${{ matrix.python-version }}" = "3.9" ]; then
7064
pip install .[dev]
7165
else
7266
pip install .[dev,valkey]
@@ -95,5 +89,5 @@ jobs:
9589
with:
9690
token: ${{ secrets.CODECOV_TOKEN }}
9791
flags: >
98-
unittests,python-${{ matrix.python-version }},django-${{ matrix.django-version }}${{ matrix.valkey && ',valkey' || '' }}
99-
fail_ci_if_error: true
92+
unittests,python-${{ matrix.python-version }},django-${{ matrix.django-version }}
93+
fail_ci_if_error: true

0 commit comments

Comments
 (0)