File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -41,6 +41,8 @@ def self.correct?(version)
4141
4242 sig { override . params ( version : VersionParameter ) . void }
4343 def initialize ( version )
44+ raise BadRequirementError , "Malformed version string - string is nil" if version . nil?
45+
4446 @version_string = T . let ( version . to_s , String )
4547 @token_bucket = T . let ( Dependabot ::Maven ::VersionParser . parse ( version_string ) , Dependabot ::Maven ::TokenBucket )
4648 end
Original file line number Diff line number Diff line change 3838
3939 context "with a malformed version string" do
4040 let ( :version_string ) { "-" }
41- let ( :err_msg ) { "Malformed version string #{ version_string } " }
4241
43- it "raises an exception" do
44- expect { version } . to raise_error ( ArgumentError , err_msg )
45- end
42+ it { is_expected . to be ( false ) }
4643 end
4744 end
4845
8582 it { is_expected . to eq ( "1.0.0_pre1" ) }
8683 end
8784
88- context "with a null version" do
85+ context "with a blank version" do
8986 let ( :version_string ) { nil }
90- let ( :err_msg ) { "Malformed version string #{ version_string } " }
87+ let ( :err_msg ) { "Malformed version string - string is nil " }
9188
9289 it "raises an exception" do
93- expect { version } . to raise_error ( ArgumentError , err_msg )
90+ expect { version } . to raise_error ( Dependabot :: BadRequirementError , err_msg )
9491 end
9592 end
9693
9794 context "with a malformed version string" do
9895 let ( :version_string ) { "-" }
99- let ( :err_msg ) { "Malformed version string #{ version_string } " }
96+ let ( :err_msg ) { "Malformed version string - #{ version_string } " }
10097
10198 it "raises an exception" do
102- expect { version } . to raise_error ( ArgumentError , err_msg )
99+ expect { version } . to raise_error ( Dependabot :: BadRequirementError , err_msg )
103100 end
104101 end
105102 end
You can’t perform that action at this time.
0 commit comments