fix: don't request tag chip feeds until onboarding is complete (#6330)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: capJavert

packages/shared/src/hooks/feed/useFeeds.spec.tsx

@@ -14,6 +14,13 @@ import {
 import { mockGraphQL } from '../../../__tests__/helpers/graphql';
 import { BootApp } from '../../lib/boot';
 import { GrowthBookProvider } from '../../components/GrowthBookProvider';
+import { useOnboardingActions } from '../auth/useOnboardingActions';
+
+jest.mock('../auth/useOnboardingActions', () => ({
+  useOnboardingActions: jest.fn(),
+}));
+
+const mockUseOnboardingActions = useOnboardingActions as jest.Mock;
 
 const client = new QueryClient();
 const noop = jest.fn();
@@ -82,6 +89,7 @@ const feeds = [
 describe('useFeeds hook', () => {
   beforeEach(() => {
     client.clear();
+    mockUseOnboardingActions.mockReturnValue({ isOnboardingComplete: true });
 
     mockGraphQL({
       request: {
@@ -251,4 +259,34 @@ describe('useFeeds hook', () => {
       result.current.feeds!.edges.find((f) => f.node.id === 'cf1'),
     ).toBeFalsy();
   });
+
+  it('should not request tag chip feeds until onboarding is complete', async () => {
+    mockUseOnboardingActions.mockReturnValue({ isOnboardingComplete: false });
+
+    let withoutChipsCalled = false;
+    mockGraphQL({
+      request: {
+        query: FEED_LIST_QUERY,
+        variables: {
+          includeTagChipFeeds: false,
+        },
+      },
+      result: () => {
+        withoutChipsCalled = true;
+
+        return {
+          data: {
+            feedList: {
+              pageInfo: { endCursor: expect.any(String), hasNextPage: false },
+              edges: feeds,
+            },
+          },
+        };
+      },
+    });
+
+    renderHook(() => useFeeds(), { wrapper: Wrapper });
+
+    await waitFor(() => expect(withoutChipsCalled).toBe(true));
+  });
 });

packages/shared/src/hooks/feed/useFeeds.ts

@@ -17,6 +17,7 @@ import {
   FeedChipsVariant,
   featureFeedChips,
 } from '../../lib/featureManagement';
+import { useOnboardingActions } from '../auth/useOnboardingActions';
 
 export type CreateFeedProps = {
   name: string;
@@ -38,13 +39,18 @@ export const useFeeds = (): UseFeeds => {
   const queryClient = useQueryClient();
   const { displayToast } = useToastNotification();
   const { user, feeds: bootFeeds } = useAuthContext();
-  const queryKey = generateQueryKey(RequestKey.Feeds, user);
+  const { isOnboardingComplete } = useOnboardingActions();
 
   const { value: feedChipsVariant } = useConditionalFeature({
     feature: featureFeedChips,
     shouldEvaluate: !!user,
   });
-  const includeTagChipFeeds = feedChipsVariant === FeedChipsVariant.V2;
+  const includeTagChipFeeds =
+    feedChipsVariant === FeedChipsVariant.V2 && isOnboardingComplete;
+
+  const queryKey = generateQueryKey(RequestKey.Feeds, user, {
+    includeTagChipFeeds,
+  });
 
   const initialData: FeedList['feedList'] | undefined = useMemo(() => {
     if (!bootFeeds) {