fix(install): fail the PowerShell installer when the version check exits non-zero (#2391)

Author: Wirasm

packages/docs-web/public/install.ps1

@@ -284,6 +284,11 @@ function Main {
         Write-Info "Verifying installation..."
         try {
             $versionOutput = & $destBinary version 2>&1
+            if ($LASTEXITCODE -ne 0) {
+                Write-Err "Installed binary failed its version check (exit $LASTEXITCODE):"
+                Write-Host $versionOutput
+                exit 1
+            }
             Write-Host $versionOutput
             Write-Ok "Installation complete!"
         } catch {

scripts/install.ps1

@@ -284,6 +284,11 @@ function Main {
         Write-Info "Verifying installation..."
         try {
             $versionOutput = & $destBinary version 2>&1
+            if ($LASTEXITCODE -ne 0) {
+                Write-Err "Installed binary failed its version check (exit $LASTEXITCODE):"
+                Write-Host $versionOutput
+                exit 1
+            }
             Write-Host $versionOutput
             Write-Ok "Installation complete!"
         } catch {

scripts/test-install.sh

@@ -20,6 +20,24 @@ assert_equals() {
   [ "$expected" = "$actual" ] || fail "$description: expected $expected, got $actual"
 }
 
+assert_powershell_version_guard() {
+  local powershell_installer="$1"
+
+  awk '
+    /# --- Verify installation ---/ { in_verification = 1; next }
+    /# --- Getting started ---/ { exit }
+    !in_verification { next }
+    /\$versionOutput = & \$destBinary version 2>&1/ { invoked = 1; next }
+    invoked && /if \(\$LASTEXITCODE -ne 0\)/ { guarded = 1; next }
+    guarded && /exit 1/ { exits_on_failure = 1; next }
+    exits_on_failure && /Write-Ok "Installation complete!"/ { reports_success = 1 }
+    END {
+      exit !(invoked && guarded && exits_on_failure && reports_success)
+    }
+  ' "$powershell_installer" \
+    || fail "PowerShell installer must fail a non-zero version check before reporting success"
+}
+
 make_platform_mocks() {
   local os="$1"
   local arch="$2"
@@ -137,6 +155,7 @@ cmp -s "$installer" "$repo_root/packages/docs-web/public/install" \
 # PATH-corrupting installer to Windows users while the repo copy was fixed. #2339.
 cmp -s "$repo_root/scripts/install.ps1" "$repo_root/packages/docs-web/public/install.ps1" \
   || fail "public install.ps1 mirror differs from scripts/install.ps1"
+assert_powershell_version_guard "$repo_root/scripts/install.ps1"
 
 mock_dir="$tmp_dir/install-mocks"
 install_dir="$tmp_dir/install-bin"