Skip to content

Commit 753d33a

Browse files
author
nicosammito
committed
feat: update parameter instance lookup to use parameterDefinition id in DFlowReferenceSuggestions hook
1 parent 402f760 commit 753d33a

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/components/d-flow-suggestion/DFlowReferenceSuggestions.hook.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ const useRefObjects = (flowId: Flow['id']): Array<ExtendedReferenceValue> => {
151151
return flow.nodes.nodes.flatMap((node) => {
152152
const functionDefinition = functionService.getById(node?.functionDefinition?.id)
153153
if (!functionDefinition) return []
154-
155154
const nodeValues =
156155
node?.parameters?.nodes?.map((p) => p?.value!).filter(Boolean) ?? []
157156

@@ -162,12 +161,14 @@ const useRefObjects = (flowId: Flow['id']): Array<ExtendedReferenceValue> => {
162161
const pType = dataTypeService.getDataType(dataTypeIdentifier)
163162
if (!pType || pType.variant !== "NODE") return []
164163

165-
const paramInstance = node?.parameters?.nodes?.find((p) => p?.id === paramDef?.id)
164+
165+
const paramInstance = node?.parameters?.nodes?.find((p) => p?.parameterDefinition?.id === paramDef?.id)
166166
if (!paramInstance?.value || paramInstance.value.__typename !== "NodeFunctionIdWrapper") return []
167167

168168
const paramNodeContext = nodeContexts?.find(
169169
(context) => paramInstance?.value?.__typename === "NodeFunctionIdWrapper" && context.nodeFunctionId === paramInstance.value?.id
170170
)
171+
171172
if (!paramNodeContext) return []
172173

173174
const inputTypeRules =
@@ -288,7 +289,7 @@ const useNodeContext = (
288289
if (current.parameters && def.parameterDefinitions) {
289290
for (const pDef of def.parameterDefinitions) {
290291
const pType = dataTypeService.getDataType(pDef.dataTypeIdentifier!!);
291-
const paramInstance = current.parameters?.nodes?.find((p) => p?.id === pDef.id);
292+
const paramInstance = current.parameters?.nodes?.find((p) => p?.parameterDefinition?.id === pDef.id);
292293

293294
if (pType?.variant === "NODE") {
294295
if (paramInstance?.value && paramInstance.value.__typename === "NodeFunctionIdWrapper") {

0 commit comments

Comments
 (0)