fix(tui): guard both no-op cases for thinking toggle when thinking is off

Author: oldschoola

packages/coding-agent/src/modes/controllers/input-controller.ts

@@ -1525,8 +1525,9 @@ export class InputController {
 	toggleThinkingBlockVisibility(): void {
 		// When thinking is "off", thinking blocks are always hidden (some
 		// providers return them regardless). The toggle is meaningless in
-		// that state — inform the user instead of silently no-op'ing.
-		if (this.ctx.effectiveHideThinkingBlock && !this.ctx.hideThinkingBlock) {
+		// that state regardless of the persisted preference — inform the
+		// user instead of silently flipping the persisted value.
+		if (this.ctx.effectiveHideThinkingBlock) {
 			this.ctx.showStatus("Thinking is off — enable thinking to show blocks");
 			return;
 		}

packages/coding-agent/test/input-controller-thinking-visibility.test.ts

@@ -74,4 +74,35 @@ describe("InputController thinking visibility", () => {
 		expect(resetDisplay).not.toHaveBeenCalled();
 		expect(showStatus).toHaveBeenCalledWith("Thinking is off — enable thinking to show blocks");
 	});
+	it("refuses to toggle when thinking is off even if hideThinkingBlock is already true", () => {
+		// The persisted preference may already be true from a prior session
+		// where thinking was on. With thinking off, effectiveHideThinkingBlock
+		// is true regardless, so any toggle is a no-op — guard it rather than
+		// flipping the persisted preference back to false.
+		const assistant = new AssistantMessageComponent();
+		const setHideThinkingBlock = vi.spyOn(assistant, "setHideThinkingBlock");
+		const set = vi.fn();
+		const showStatus = vi.fn();
+		const resetDisplay = vi.fn();
+		const ctx = {
+			hideThinkingBlock: true,
+			effectiveHideThinkingBlock: true, // thinking is off → effective is true
+			settings: { set },
+			session: { agent: { hideThinkingSummary: false } },
+			chatContainer: { children: [assistant], clear: vi.fn(), addChild: vi.fn() },
+			streamingComponent: undefined,
+			streamingMessage: undefined,
+			showStatus,
+			ui: { resetDisplay },
+		} as unknown as InteractiveModeContext;
+
+		new InputController(ctx).toggleThinkingBlockVisibility();
+
+		// Persisted preference unchanged, no component updates, no reset.
+		expect(ctx.hideThinkingBlock).toBe(true);
+		expect(set).not.toHaveBeenCalled();
+		expect(setHideThinkingBlock).not.toHaveBeenCalled();
+		expect(resetDisplay).not.toHaveBeenCalled();
+		expect(showStatus).toHaveBeenCalledWith("Thinking is off — enable thinking to show blocks");
+	});
 });