Fix code.pyret.org CI: use chrome-for-testing chromedriver directly

Joe says: npm finally updated enough that we got bit by a configuration
warning I should have fixed a while ago

Claude says:

The Selenium tests were all failing with "Server terminated early with
status 1". The cause was the chromedriver binary install, not Selenium:
selenium-webdriver 3.6.0 launches chromedriver 149 and creates a W3C
session fine. That error is what Selenium reports when the `chromedrive
npm package's launcher shim can't start its real binary.

The binary wasn't installing correctly because the install relied on
`npm install chromedriver --chromedriver_filepath=...`, which npm 11 no
flags as an unknown config that "will stop working", and because the
`chromedriver` npm package is pinned to 146 while Chrome is auto-fetche
at latest-stable (149).

chrome-for-testing already ships a chromedriver matching the Chrome we
download, so use it directly:
- Workflow: unzip the chromedriver from the same release and export
  CHROMEDRIVER_BINARY; drop the npm chromedriver-install step entirely.
- util.js: CHROMEDRIVER_BINARY and GOOGLE_CHROME_BINARY were mutually
  exclusive (if/else if), so selecting a driver binary left Chrome's
  location unset. Make them independent.

Driver and browser now always come from the same release, with no
deprecated npm flag. Verified locally with Chrome+chromedriver 149 and
selenium-webdriver 3.6.0: a real headless session loads a page.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: jpolitz

.github/workflows/code.pyret.org-test.yml

@@ -35,24 +35,24 @@ jobs:
         export CHROME_VERSION=$(curl -s https://googlechromelabs.github.io/chrome-for-testing/LATEST_RELEASE_STABLE)
         echo "Chrome version: $CHROME_VERSION"
         
-        # Download Chrome and ChromeDriver
+        # Download Chrome and the exactly-matching ChromeDriver from the same release
         curl -L https://storage.googleapis.com/chrome-for-testing-public/$CHROME_VERSION/linux64/chrome-linux64.zip -o chrome-linux64.zip
         curl -L https://storage.googleapis.com/chrome-for-testing-public/$CHROME_VERSION/linux64/chromedriver-linux64.zip -o chromedriver-linux64.zip
-        
-        # Extract Chrome
+
+        # Extract Chrome and ChromeDriver
         unzip chrome-linux64.zip
-        
-        # Set Chrome binary path for tests
-        echo "GOOGLE_CHROME_BINARY=./chrome-linux64/chrome" >> $GITHUB_ENV
+        unzip chromedriver-linux64.zip
+
+        # Point the tests at both binaries. We use the chrome-for-testing
+        # chromedriver directly (via CHROMEDRIVER_BINARY) instead of the
+        # `chromedriver` npm package so the driver always matches Chrome and we
+        # don't depend on npm's deprecated --chromedriver_filepath config.
+        echo "GOOGLE_CHROME_BINARY=$PWD/chrome-linux64/chrome" >> $GITHUB_ENV
+        echo "CHROMEDRIVER_BINARY=$PWD/chromedriver-linux64/chromedriver" >> $GITHUB_ENV
 
     - name: Install dependencies
       run: npm ci --ignore-scripts
 
-    - name: Install ChromeDriver with specific binary
-      run: |
-        npm install chromedriver --chromedriver_filepath=$PWD/chromedriver-linux64.zip
-        npm install -g chromedriver --chromedriver_filepath=$PWD/chromedriver-linux64.zip
-
     - name: Add node_modules/.bin to PATH
       run: echo "$PWD/node_modules/.bin" >> $GITHUB_PATH
 

code.pyret.org/test-util/util.js

@@ -10,8 +10,12 @@ let PATH_TO_CHROME;
 if (process.env.CHROMEDRIVER_BINARY) {
   // Note(Ben): Use `env CHROMDRIVER_BINARY=/snap/bin/chromium.chromedriver npm run mocha`
   // Based on https://stackoverflow.com/a/53971573
+  // This selects the ChromeDriver binary; it is independent of which Chrome
+  // browser binary we use (GOOGLE_CHROME_BINARY), so it must not be an else-if.
   chrome.setDefaultService(new chrome.ServiceBuilder(process.env.CHROMEDRIVER_BINARY).build());
-} else if (process.env.GOOGLE_CHROME_BINARY) {
+}
+
+if (process.env.GOOGLE_CHROME_BINARY) {
   // Used by Travis
   PATH_TO_CHROME = process.env.GOOGLE_CHROME_BINARY;
 }