fix(scripts): preserve optional-repo semantic on wkhtmltopdf-openemr

Rabbit-flagged regression in this PR. The previous code at
startFarm.sh:68 and restartFarm.sh:32 had a comment marking
`wkhtmltopdf-openemr` as optional. The unguarded `cd ~/...`
silently failed when the directory was absent, so the subsequent
`git pull` failed too -- but the script kept going. That silent
failure WAS the "skip if absent" semantic.

Adding `|| exit 1` (the SC2164 fix) turned the documented-optional
repo into a hard requirement: a fresh host without the
wkhtmltopdf checkout would exit before starting any docker
containers.

The build-tests suite (openemr#147/openemr#148) only covers demo_build.sh, so
this regression wouldn't surface in CI -- the docker/scripts/*
orchestration scripts run on the production EC2 host and were
explicitly out-of-scope when openemr#146 was planned. Rabbit's review
was the only layer that caught this.

Fix: wrap both sites with `if [ -d ~/wkhtmltopdf-openemr ]`
guards. Keeps the cd-failure-is-fatal semantic (so a stale dir
without git history still exits loudly), but skips the block
entirely when the optional repo isn't there.

Refs: openemr#146 (issue), openemr#150 (this PR)

Assisted-by: Claude Code

Author: bradymiller

docker/scripts/restartFarm.sh

@@ -30,10 +30,16 @@ cd ~/ || exit 1
 cp ~/translations_development_openemr/languageTranslations_utf8.sql ~/html/translations/
 
 # update optional wkhtmltopdf-openemr
-cd ~/wkhtmltopdf-openemr || exit 1
-git fetch origin
-git pull origin master
-cd ~/ || exit 1
+# Comment marks this repo as optional. Pre-cd-guard code tolerated a
+# missing directory because the unguarded `cd` silently failed; preserve
+# that "skip if absent" semantic explicitly now that cd is hard-exit on
+# failure.
+if [ -d ~/wkhtmltopdf-openemr ]; then
+  cd ~/wkhtmltopdf-openemr || exit 1
+  git fetch origin
+  git pull origin master
+  cd ~/ || exit 1
+fi
 
 # rebuild simple website and copy translations to website
 cp -r ~/demo_farm_openemr/docker/html/* ~/html/

docker/scripts/startFarm.sh

@@ -66,10 +66,16 @@ git pull origin master
 cd ~/ || exit 1
 
 # update optional wkhtmltopdf-openemr
-cd ~/wkhtmltopdf-openemr || exit 1
-git fetch origin
-git pull origin master
-cd ~/ || exit 1
+# Comment + the install-instructions header above mark this repo as
+# optional. Pre-cd-guard code tolerated a missing directory because the
+# unguarded `cd` silently failed; preserve that "skip if absent"
+# semantic explicitly now that cd is hard-exit on failure.
+if [ -d ~/wkhtmltopdf-openemr ]; then
+  cd ~/wkhtmltopdf-openemr || exit 1
+  git fetch origin
+  git pull origin master
+  cd ~/ || exit 1
+fi
 
 # rebuild simple website and copy translations to website
 cp -r ~/demo_farm_openemr/docker/html/* ~/html/