how do I add libasan flags with genie

[chriscamacho]

when running with the GL backend I see no potential leaks

When running with the Vulkan backend I see some potential leaks I'd like to investigate further (at least one of these is either a false positive or not a bgfx issue...) BGFX's own leak detection does not report these.

==15228==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 72704 byte(s) in 1 object(s) allocated from:
    #0 0x7f3e7c1e61b7 in __interceptor_malloc (/usr/lib/libasan.so.6+0xaf1b7)
    #1 0x7f3e60c74a25  (<unknown module>)
    #2 0x7f3e60c642aa  (<unknown module>)

Direct leak of 192 byte(s) in 2 object(s) allocated from:
    #0 0x7f3e7c1e61b7 in __interceptor_malloc (/usr/lib/libasan.so.6+0xaf1b7)
    #1 0x7f3e613cc467  (<unknown module>)

Direct leak of 128 byte(s) in 4 object(s) allocated from:
    #0 0x7f3e7c1e61b7 in __interceptor_malloc (/usr/lib/libasan.so.6+0xaf1b7)
    #1 0x7f3e7a894135  (/usr/lib/libxcb.so.1+0xf135)

Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x7f3e7c1e61b7 in __interceptor_malloc (/usr/lib/libasan.so.6+0xaf1b7)
    #1 0x7f3e705185cc  (<unknown module>)

Indirect leak of 4923 byte(s) in 7 object(s) allocated from:
    #0 0x7f3e7c1e61b7 in __interceptor_malloc (/usr/lib/libasan.so.6+0xaf1b7)
    #1 0x7f3e613cc467  (<unknown module>)

SUMMARY: AddressSanitizer: 77955 byte(s) leaked in 15 allocation(s).

This is not a "run away" leak as regardless of how long the application runs the size of the potential leak is always the same.

I'd like to be able to temporarily compile all the debug libs with the following

INSTR:= -fsanitize=address,leak,undefined,pointer-compare,pointer-subtract
INSTR+= -fno-omit-frame-pointer -g 

how may I best do this ?

[pezcode]

Take a look at scripts/bgfx.lua, you probably want to add those flags to buildoptions or linkoptions for the right configuration. If you want to hide this behind a togglable option, you can add one in genie.lua and then check _OPTIONS.

[chriscamacho]

thanks I'll take a look, will let you know if I find owt...

…

On Sat, 10 Apr 2021 at 15:21, pezcode ***@***.***> wrote: Take a look at scripts/bgfx.lua, you probably want to add those flags to buildoptions or linkoptions for the right configuration. If you want to hide this behind a togglable option, you can add one in genie.lua and then check _OPTIONS. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2465 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFO4SOVLIKRYA5M7APBUY3TIBNHVANCNFSM42WFSAKQ> .

-- blog bedroomcoders.co.uk <http://bedroomcoders.co.uk> Free source code and tutorials! Disclaimer: By sending an email to ANY of my addresses you are agreeing that: 1. I am by definition, "the intended recipient" 2. All information in the email is mine to do with as I see fit and make such financial profit, political mileage, or good joke as it lends itself to. In particular, I may quote it where I please. 3. I may take the contents as representing the views of your company. 4. This overrides any disclaimer or statement of confidentiality that may be included on your message.

[chriscamacho]

I added the flags in, which did show me where in 1 place I was sending a vec3 to a uniform causing a stack issue (with a local variable) which was basically harmless, but I might turn my vec3's in my maths routines into vec4's (add a padding float) so that was interesting...

however I'm still seeing potential leaks in an unknown module

I added in the flags like this

		configuration { "linux-*" }
			buildoptions {
				"-fPIC",
                                "-fsanitize=address,leak,undefined,pointer-compare,pointer-subtract -fno-omit-frame-pointer -g"
			}
			links {
				"X11",
				"GL",
				"pthread",
			}
                        linkoptions {
                                "-fsanitize=address,leak,undefined,pointer-compare,pointer-subtract -fno-omit-frame-pointer -g"
                        }

would this also add the flags to the bx and bximg compile ? maybe the potential issue is lower down (although that said it only happens with the Vulkan renderer)

any ideas would be most appreciated I don't think this is actually a major issue (certainly not a show stopper) but I would like to know what's going on!

[pezcode]

You can add those flags as a global define to genie.lua, or if you want to restrict it just to those libraries in their respective repos' scripts folder.

It could be the Vulkan validation layers that are leaking stuff. You can turn those off with the vkconfig utility, or by defining BGFX_CONFIG_DEBUG=0.

[chriscamacho]

You can add those flags as a global define to genie.lua
not sure what you mean by that, in any case would it behave any different ? it would be nice to get instrumentation properly working with the whole of bgfx its really very useful!

do you mean run

BGFX_CONFIG_DEBUG=0 ./my_app

or is this some kind of make parameter ?

[pezcode]

Adding it like here doesn't do anything?

[pezcode]

what I meant was to run genie with that env var set nevermind, it's a bit more tricky

[chriscamacho]

i added instrumentation flags to my app but linked to the release bgfx libs and still see these potential issues so I don't think its specific to debug, I'll try adding the flags in genie.lua and see if that works....

[chriscamacho]

nope adding the options in genie.lua and running genie has no effect grepping shows nothing

I can even add a flag "arrgh" which you'd think would break the build but has no effect, are you sure these files are even used by genie ???

I'm running genie like this

../bx/tools/bin/linux/genie --gcc=linux-gcc --platform=x64 --os=linux --cc=gcc --with-tools gmake

[chriscamacho]

I had a look at this again, but can't get bgfx built with the flags I need to investigate further, there is an issue with the Vulkan renderer that's not seen with the OpenGL renderer, but I can't raise any kind of a bug report or even attempt a fix as I just can't seem to get the build system to do a simple thing like add some compile and link flags...