Merge pull request #3706 from betagouv/import-purchases-bug

🐛 Permet d'importer des fichier sans `local_definition`

Author: alemangui

api/tests/files/good_purchase_import_no_local_def.csv

@@ -0,0 +1,3 @@
+canteen siret,description,fournisseur,date,prix HT,famille,caractéristiques
+82399356058716,"Pommes, rouges",Le bon traiteur ,2022-05-02,90.11, PRODUITS_LAITIERS ,"BIO"
+82399356058716,"Pommes, vertes",Le bon traiteur ,2022-05-03,910.11, PRODUITS_LAITIERS ,"BIO"

api/tests/test_import_purchases.py

@@ -46,6 +46,26 @@ def test_import_good_purchases(self):
         filehash_md5 = hashlib.md5(filebytes).hexdigest()
         self.assertEqual(Purchase.objects.first().import_source, filehash_md5)
 
+    @authenticate
+    def test_import_with_no_local_definition(self):
+        """
+        Tests that can import a file without local definition
+        """
+        CanteenFactory.create(siret="82399356058716", managers=[authenticate.user])
+        with open("./api/tests/files/good_purchase_import_no_local_def.csv") as purchase_file:
+            response = self.client.post(reverse("import_purchases"), {"file": purchase_file})
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(Purchase.objects.count(), 2)
+        purchase = Purchase.objects.filter(description="Pommes, rouges").first()
+        self.assertEqual(purchase.canteen.siret, "82399356058716")
+        self.assertEqual(purchase.description, "Pommes, rouges")
+        self.assertEqual(purchase.provider, "Le bon traiteur")
+        self.assertEqual(purchase.price_ht, Decimal("90.11"))
+        self.assertEqual(purchase.date, date(2022, 5, 2))
+        self.assertEqual(purchase.family, Purchase.Family.PRODUITS_LAITIERS)
+        self.assertEqual(purchase.characteristics, [Purchase.Characteristic.BIO])
+        self.assertEqual(purchase.local_definition, None)
+
     @authenticate
     def test_import_purchases_different_separators(self):
         """

api/views/purchaseimport.py

@@ -190,11 +190,7 @@ def _create_purchase_for_canteen(self, siret, row):
         family = row.pop(0)
         characteristics = row.pop(0)
         characteristics = [c.strip() for c in characteristics.split(",")]
-        local_definition = row.pop(0)
-        if "LOCAL" in characteristics and not local_definition:
-            raise ValidationError(
-                {"local_definition": "La définition de local est obligatoire pour les produits locaux"}
-            )
+        local_definition = ImportPurchasesView._get_local_definition(row, characteristics)
 
         purchase = Purchase(
             canteen=canteen,
@@ -204,12 +200,27 @@ def _create_purchase_for_canteen(self, siret, row):
             price_ht=price,
             family=family.strip(),
             characteristics=characteristics,
-            local_definition=local_definition.strip(),
+            local_definition=local_definition,
             import_source=self.tmp_id,
         )
         purchase.full_clean()
         self.purchases.append(purchase)
 
+    # Factored out because _create_purchase_for_canteen was too complex for flake8 validation
+    @staticmethod
+    def _get_local_definition(row, characteristics):
+        local_definition = None
+        if "LOCAL" in characteristics:
+            try:
+                local_definition = row.pop(0)
+                if not local_definition:
+                    raise IndexError
+            except IndexError:
+                raise ValidationError(
+                    {"local_definition": "La définition de local est obligatoire pour les produits locaux"}
+                )
+        return local_definition.strip() if local_definition else None
+
     def _get_success_response(self):
         return JsonResponse(
             {