Prefill group as Cc on group summary quick ticket creation

The group summary "Quick ticket creation" portlet passed the group via
a hidden AddGroupCc field, which only added the group as a Cc watcher
after the ticket was created (in Display.html) and never prefilled the
visible Cc field on the create form. So clicking Create landed on a
create form with an empty Cc field.

The ticket create Cc field now accepts groups directly via group:NAME
tokens, so prefill it with the group like the user summary portlet does
with Requestors. This makes the group visible in the Cc field and flows
it through the normal watcher processing, so the special AddGroupCc
handling in Create.html and Display.html is no longer needed.

Author: sunnavy

devel/docs/UPGRADING-6.0

@@ -194,6 +194,16 @@ been moved to the .main-container element. If you've customized CSS styles
 targeting body with id like C<body#comp-Ticket-Display>, update them to
 C<.main-container#comp-Ticket-Display> or just C<#comp-Ticket-Display>.
 
+=item *
+
+The group summary "Quick ticket creation" portlet no longer submits the
+group to C</Ticket/Create.html> via a hidden C<AddGroupCc> field. The ticket
+create Cc field now accepts groups directly, so the portlet prefills C<Cc>
+with a C<group:NAME> token instead, and the special C<AddGroupCc> handling
+has been removed from C</Ticket/Create.html> and C</Ticket/Display.html>. If
+you have a link or customization that passes C<AddGroupCc> to the create
+form, change it to pass C<Cc=group:NAME> (or C<Cc=group:ID>).
+
 =back
 
 =head1 DEPRECATED CODE

share/html/Group/Elements/Portlets/CreateTicket

@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <&| /Widgets/TitleBox, title => loc('Quick ticket creation'), class => "group create-ticket" &>
 <form name="CreateTicket" action="<%RT->Config->Get('WebPath')%>/Ticket/Create.html">
-<input type="hidden" name="AddGroupCc" value="<%$Group->Id%>">
+<input type="hidden" name="Cc" value="<% $group_cc %>">
   <div class="row mt-2">
     <div class="col-auto label">
       <&|/l&>Create a ticket with this group as Cc in Queue</&>
@@ -61,6 +61,11 @@
   </div>
 </form>
 </&>
+<%INIT>
+# A group name containing the field delimiter (comma) can't round-trip as a
+# "group:NAME" token, so fall back to the id in that case.
+my $group_cc = $Group->Name =~ /,/ ? 'group:' . $Group->Id : 'group:' . $Group->Name;
+</%INIT>
 <%ARGS>
 $Group
 </%ARGS>

share/html/Ticket/Create.html

@@ -59,10 +59,6 @@
   <input type="hidden" class="hidden" name="Token" value="<% $ARGS{'Token'} %>" />
   <input type="hidden" name="QueueChanged" value="0" />
 
-% if ( $ARGS{'AddGroupCc'} ){
-<input type="hidden" class="hidden" name="AddGroupCc" value="<% $ARGS{'AddGroupCc'} %>" />
-% }
-
 % if ( $ARGS{'ChangedField'} ) {
 %   for my $field ( ref $ARGS{ChangedField} eq 'ARRAY' ? @{ $ARGS{ChangedField} } : $ARGS{ChangedField} ) {
   <input type="hidden" class="hidden" name="ChangedField" value="<% $field %>" />
@@ -333,5 +329,4 @@
 $MemberOf => undef
 $QuoteTransaction => undef
 $CloneTicket => undef
-$AddGroupCc => undef
 </%ARGS>

share/html/Ticket/Display.html

@@ -186,26 +186,6 @@
 
 $title = loc("#[_1]: [_2]", $TicketObj->Id, $TicketObj->Subject || '');
 
-if ( $ARGS{'id'} and $ARGS{'id'} eq 'new' ) {
-    if ( $ARGS{'AddGroupCc'} ){
-        my $group = RT::Group->new($session{'CurrentUser'});
-        my ($ret, $msg) = $group->LoadUserDefinedGroup($ARGS{'AddGroupCc'});
-
-        unless ( $ret ){
-            RT::Logger->warn("Unable to load group " . $ARGS{'AddGroupCc'} . ", $msg. Not adding as Cc.");
-            return;
-        }
-
-        ( $ret, $msg ) = $TicketObj->AddWatcher(
-            Type        => 'Cc',
-            PrincipalId => $group->Id
-        );
-
-        RT::Logger->warn("Unable to add group " . $group->Name . ": " . $group->Id . " as a Cc: $msg")
-            unless $ret;
-    }
-}
-
 $m->callback(
     CallbackName => 'BeforeDisplay',
     TicketObj => \$TicketObj,