Skip to content

Commit 5c8cec3

Browse files
committed
ci: remove dead/no-op -Dmaven.javadoc.skip=true flags (4 occurrences)
The build job's flag (package phase) is removed too: javadoc was verified to build clean and is now validated by the build + verify jobs. The vmlens/PIT/JMH ones were dead no-ops (test/test-compile/exec:java never reach the package phase). streambuffer is Java-8 (<source>8>) so javadoc stays in classpath mode — no skip needed anywhere. https://claude.ai/code/session_01EQJCrQGmxCBf8WTCDuFE3X
1 parent 5b9caf2 commit 5c8cec3

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/publish.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
distribution: temurin
5858
cache: maven
5959
- name: Build
60-
run: mvn --batch-mode --no-transfer-progress -DskipTests -Dmaven.javadoc.skip=true package
60+
run: mvn --batch-mode --no-transfer-progress -DskipTests package
6161
- uses: actions/upload-artifact@v7
6262
with: { name: jars, path: target/*.jar }
6363

@@ -94,7 +94,7 @@ jobs:
9494
- uses: actions/setup-java@v5
9595
with: { java-version: '21', distribution: temurin, cache: maven }
9696
- name: Test under vmlens
97-
run: mvn --batch-mode --no-transfer-progress -Pvmlens test -Dmaven.javadoc.skip=true
97+
run: mvn --batch-mode --no-transfer-progress -Pvmlens test
9898
- uses: actions/upload-artifact@v7
9999
if: always()
100100
with:
@@ -130,7 +130,7 @@ jobs:
130130
files: target/site/jacoco/jacoco.xml
131131
continue-on-error: true
132132
- name: Run PIT mutation tests
133-
run: mvn --batch-mode --no-transfer-progress test-compile org.pitest:pitest-maven:mutationCoverage -Dmaven.javadoc.skip=true
133+
run: mvn --batch-mode --no-transfer-progress test-compile org.pitest:pitest-maven:mutationCoverage
134134
- name: Extract PIT survivors
135135
if: always()
136136
run: |
@@ -151,7 +151,6 @@ jobs:
151151
-Dexec.mainClass=org.openjdk.jmh.Main
152152
-Dexec.classpathScope=test
153153
-Dexec.args="StreamBufferThroughputBenchmark -wi 2 -i 3 -f 0 -rf json -rff target/jmh-results.json"
154-
-Dmaven.javadoc.skip=true
155154
continue-on-error: true
156155
- uses: actions/upload-artifact@v7
157156
if: always()

0 commit comments

Comments
 (0)