Merge pull request #403 from WolfgangHG/jbossparent52

jboss-parent 52, redefine minimum java version and checkstyle version

Author: rhusar

build/ftest-base/pom.xml

@@ -332,7 +332,7 @@
            Run this profile only in combination with the profile "jakartaee11" so that arquillian-extension-warp is built using the JakartaEE11 api:
            mvn clean install -Pjakartaee11,glassfish-jakartaee11-managed
 
-           GlassFish 8 does not support Java 17
+           GlassFish 8 does not support Java 17, but requires Java 21.
 	    -->
       <id>glassfish-jakartaee11-managed</id>
       <activation>
@@ -342,6 +342,10 @@
         </property>
       </activation>
       <properties>
+        <!-- Enforce Java 21. Instead of defining a rule for the maven-enforcer plugin ourselves, we can use the plugin definition from jboss-parent
+             and just have to set this property. -->
+        <jdk.min.version>21</jdk.min.version>
+
         <arquillian.launch.glassfish>true</arquillian.launch.glassfish>
         <arquillian.container.home>${project.build.directory}/glassfish8</arquillian.container.home>
         <arquillian.container.distribution>org.glassfish.main.distributions:glassfish:zip:${version.glassfish8}
@@ -352,31 +356,6 @@
         </arquillian.container.linux.executepermission.file>
       </properties>
 
-      <!--This profile requires Java 21 to run, as this is required by GlassFish 8 -->
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-enforcer-plugin</artifactId>
-            <executions>
-              <execution>
-                <id>enforce-java</id>
-                <goals>
-                  <goal>enforce</goal>
-                </goals>
-                <configuration>
-                  <rules>
-                    <requireJavaVersion>
-                      <version>21</version>
-                    </requireJavaVersion>
-                  </rules>
-                </configuration>
-              </execution>
-            </executions>
-          </plugin>
-        </plugins>
-      </build>
-
       <dependencies>
         <dependency>
           <groupId>ee.omnifish.arquillian</groupId>

pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.jboss</groupId>
     <artifactId>jboss-parent</artifactId>
-    <version>51</version>
+    <version>52</version>
   </parent>
 
   <!-- Model Version -->
@@ -70,6 +70,11 @@
   <properties>
     <!-- JBoss Parent -->
     <maven.compiler.release>17</maven.compiler.release>
+    <!-- Also redefine the JDK version for the maven-enforcer-plugin: jboss-parent 52 sets it to "25". -->
+    <jdk.min.version>${maven.compiler.release}</jdk.min.version>
+    <!-- jboss-parent 52 uses 13.x of "com.puppycrawl.tools:checkstyle", which requires Java 21. So switch back to the older version.
+         The dependeny is only defined in jboss-parent, so dependabot should not send updates. -->
+    <version.checkstyle>12.3.1</version.checkstyle>
 
     <!-- Arquillian -->
     <version.arquillian_core>1.10.0.Final</version.arquillian_core>