Numerous redundant constants between `cea.technologies` and `cea.optimization`

[martin-mosteiro]

What happened?

There are numerous repeated constants in cea.technologies and cea.optimization, e.g.:

From cea.technologies.constants:

# Heat pump
HP_MAX_SIZE = 20.0E6  # max thermal design size [Wth]
HP_MIN_SIZE = 1.0E6  # min thermal design size [Wth]
HP_ETA_EX = 0.6  # exergetic efficiency of WSHP [L. Girardin et al., 2010]_
HP_DELTA_T_COND = 2.0  # pinch for condenser [K]
HP_DELTA_T_EVAP = 2.0  # pinch for evaporator [K]
HP_MAX_T_COND = 140 + KELVIN_CONVERSION  # max temperature at condenser [K]
HP_AUXRATIO = 0.83  # Wdot_comp / Wdot_total (circulating pumps)

From cea.optimization.constants:

# Heat pump
HP_MAX_SIZE = 20.0E6  # max thermal design size [Wth]
HP_MIN_SIZE = 1.0E6  # min thermal design size [Wth]
HP_ETA_EX = 0.6  # exergetic efficiency of WSHP [L. Girardin et al., 2010]_
HP_ETA_EX_COOL = 0.3  # https://www.sciencedirect.com/science/article/pii/S1164023502000833
HP_DELTA_T_COND = 2.0  # pinch for condenser [K]
HP_DELTA_T_EVAP = 2.0  # pinch for evaporator [K]
HP_MAX_T_COND = 140 + KELVIN_CONVERSION  # max temperature at condenser [K]
HP_AUXRATIO = 0.83  # Wdot_comp / Wdot_total (circulating pumps)
HP_COP_MAX = 8.5  # maximum achieved by 3for2 21.05.18
HP_COP_MIN = 2.7  # COP of typical air-to-air unit

Should these technology-related constants be merged into a single constants? We could keep technology-related constants in the cea.technologies.constants directory and just import them in the optimization scripts where needed. Otherwise we can have a situation where one constant is changed in technologies but not in optimization, and the results become inconsistent.

How can we reproduce this?

Go read the cea.technologies.constants and cea.optimization.constants files

Operating System

Windows

CEA Version

4

Additional information (optional)

No response

[reyery]

Yeah I think the duplicates should just be in cea.technologies.constants, since the domain of the constants feels like it is more llike technology than optimisation.

[martin-mosteiro]

I agree!