[MNG-7983] Update to Slf4j 2.x

[jira-importer]

Guillaume Nodet opened MNG-7983 and commented

---

Remote Links:

• GitHub Pull Request #1358
  

Backported to: 4.0.0-alpha-12

0 votes, 5 watchers

[jira-importer]

Guillaume Nodet commented

It's not so easy, as  https://jira.qos.ch/browse/SLF4J-394 which was needed for maven to colorise the levels is broken with slf4j-simple 2.x.

We could re-implement the logger completely...

[jira-importer]

Matt Nelson commented

gnodet Michael Osipov Could 3.9.x also be updated to slf4j 2.x? I have an internal plugin and one of that plugin's dependencies that were uplifted to slf4j 2.x which started throwing NoSuchMethodError.

java.lang.NoSuchMethodError: 'org.slf4j.spi.LoggingEventBuilder org.slf4j.Logger.atInfo()'

[jira-importer]

Michael Osipov commented

As for me, I cannot tell the implications and such upgrade would require 3.10.0. ceki@apache.org, what is your opinion here?

[jira-importer]

Ceki Gülcü commented

Michael Osipov  Looking at #1358 (comment) I think the migration should be hassle free.

[jira-importer]

Michael Osipov commented

Ceki Gülcü, thanks for the confirmation. I will the ultimate decision to the RM, but from my point of view this must be 3.10.0 after all ITs for our plugins pass.

[jira-importer]

Ceki Gülcü commented

Michael Osipov I should add that slf4j 2.0.x requires Java 8 which should be fine for Maven 3.9+

[jira-importer]

Guillaume Nodet commented

I'm reluctant on that one. This will break any plugin / extension that somehow rely on the SLF4j provider loading mechanism.

[jira-importer]

Michael Osipov commented

gnodet, how so?

[jira-importer]

Guillaume Nodet commented

I was first thinking of a plugin which has various libraries that rely on actually configuring the slf4j provider. But those would require not loading slf4j from maven in order to load their own provider, so they would not really be affected.

[jira-importer]

Matt Nelson commented

Is there going to be a 3.10.x? Having trouble finding the link, but I vaguely remember either a mailing list post or a jira comment that I interpreted as there may not be a 3.10.x.

The maven docs[1,2] do not document a specific version of slf4j only that slf4j-api is the abstraction. slf4j-api 2.x is passive[3]. Given those facts, is the version of slf4j an implementation detail that can be passively changed in any version?

[1] https://maven.apache.org/maven-logging.html
[2] https://maven.apache.org/ref/3.9.9/maven-embedder/logging.html
[3] https://www.slf4j.org/faq.html#compatibility

[jira-importer]

Michael Osipov commented

MattNelson, there was a discussion whether Maven 3.x should switch Resolver 2.0 which would justify a bump in the minor version. Any other consideration I would completely leave to Tamas Cservenak.