Commit 08d197f
IGNITE-28821 Protected Classes CI check: report as warning instead of failing the PR build (#13279)
## What
The `Protected Classes` workflow no longer fails the PR build when a
change touches `@Order`-annotated (protected) classes. Instead it
publishes a separate, non-blocking check `Rolling upgrade compatibility`
with the `neutral` conclusion, keeping the existing PR comment and
`compatibility` label.
## Why
A hard failure (`exit 1`) red-flagged PRs even for intentional,
compatible changes, creating friction (the check was disabled manually
on 2026-05-27 for this reason). A non-blocking advisory check surfaces
the rolling-upgrade risk for reviewer attention without failing the
build.
## Why `neutral` (and not `action_required`)
GitHub's Checks API has no dedicated "warning" conclusion.
`action_required` is intended for GitHub Apps that attach a remediation
action: it renders as a red ✕ with a "Resolve" button in the Checks tab
and is dropped from the PR merge-box rollup entirely (so the warning
becomes invisible there). `neutral` is the proper primitive for an
advisory result — it shows in its own non-blocking "neutral" group in
the merge box and as a grey marker in the Checks tab, and it never
blocks merging.
## Notes
- The `Rolling Upgrade check` job now always succeeds.
- The new check is non-blocking unless added to required status checks.
- `checks: write` permission added for the Checks API call.
Jira: https://issues.apache.org/jira/browse/IGNITE-28821
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent a90f44a commit 08d197f
1 file changed
Lines changed: 25 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | | - | |
| 127 | + | |
127 | 128 | | |
128 | | - | |
129 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
0 commit comments