fix: normalize uppercase V in semantic version comparison (#3461)

Signed-off-by: immanuwell <pchpr.00@list.ru>

Author: immanuwell

grype/version/semantic_version.go

@@ -19,7 +19,7 @@ type semanticVersion struct {
 	obj *hashiVer.Version
 }
 
-var versionStartsWithV = regexp.MustCompile(`^v\d+`)
+var versionStartsWithV = regexp.MustCompile(`^[vV]\d+`)
 
 func newSemanticVersion(raw string, strict bool) (semanticVersion, error) {
 	clean := semverPrereleaseNormalizer.Replace(raw)
@@ -29,10 +29,11 @@ func newSemanticVersion(raw string, strict bool) (semanticVersion, error) {
 	if strict {
 		// we still want v-prefix processing
 		if versionStartsWithV.MatchString(clean) {
-			clean = strings.TrimPrefix(clean, "v")
+			clean = trimLeadingV(clean)
 		}
 		verObj, err = hashiVer.NewSemver(clean)
 	} else {
+		clean = trimLeadingV(clean)
 		verObj, err = hashiVer.NewVersion(clean)
 	}
 	if err != nil {

grype/version/semantic_version_test.go

@@ -20,6 +20,7 @@ func TestSemanticVersion_Constraint(t *testing.T) {
 		{version: "0.6.0", constraint: "> 0.1.0, < 0.5.0 || > 1.0.0, < 2.0.0", satisfied: false},
 		{version: "2.5.0", constraint: "> 0.1.0, < 0.5.0 || > 1.0.0, < 2.0.0", satisfied: false},
 		{version: "2.3.1", constraint: "2.3.1", satisfied: true},
+		{version: "1.0.0", constraint: "= V1.0.0", satisfied: true},
 		{version: "2.3.1", constraint: "= 2.3.1", satisfied: true},
 		{version: "2.3.1", constraint: "  =   2.3.1", satisfied: true},
 		{version: "2.3.1", constraint: ">= 2.3.1", satisfied: true},
@@ -227,6 +228,13 @@ func TestSemanticVersion_Compare_Format(t *testing.T) {
 			otherFormat:  SemanticFormat,
 			expectError:  false,
 		},
+		{
+			name:         "same format successful comparison with uppercase V prefix",
+			thisVersion:  "V1.2.3",
+			otherVersion: "1.2.3",
+			otherFormat:  SemanticFormat,
+			expectError:  false,
+		},
 		{
 			name:         "same format successful comparison with prerelease",
 			thisVersion:  "1.2.3-alpha",