Skip to content

Commit ad727f1

Browse files
author
voidborne-d
committed
fix: address review — fail on unknown/error verdicts, capture exit code, add engineering-team paths
- catch-all (*) in verdict case now sets OVERALL_EXIT=1 so auditor crashes/errors block merge instead of silently passing - replace '|| true' with '&& EXIT_CODE=$? || EXIT_CODE=$?' to correctly capture auditor exit code - add 'engineering-team/**' to workflow trigger paths (38 skills)
1 parent cc3dfc8 commit ad727f1

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/skill-security-audit.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ name: Skill Security Audit
66
types: [opened, synchronize, reopened]
77
paths:
88
- 'engineering/**'
9+
- 'engineering-team/**'
910
- 'business-growth/**'
1011
- 'c-level-advisor/**'
1112
- 'documentation/**'
@@ -120,8 +121,7 @@ jobs:
120121
echo "Scanning: $skill_dir"
121122
122123
# Run auditor in strict mode with JSON output
123-
JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) || true
124-
EXIT_CODE=$?
124+
JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) && EXIT_CODE=$? || EXIT_CODE=$?
125125
126126
# Try to parse JSON output
127127
VERDICT=$(echo "$JSON_OUT" | python3 -c "
@@ -145,7 +145,7 @@ jobs:
145145
PASS) ICON="✅" ;;
146146
WARN) ICON="⚠️" ;;
147147
FAIL) ICON="❌"; OVERALL_EXIT=1 ;;
148-
*) ICON="❓" ;;
148+
*) ICON="❓"; OVERALL_EXIT=1 ;;
149149
esac
150150
151151
echo "### $ICON \`$skill_dir\` — $V" >> "$REPORT_FILE"

0 commit comments

Comments
 (0)