etcd-defrag/main_test.go at main · ahrtr/etcd-defrag · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
package main

import (
	"os"
	"testing"

	"github.com/spf13/cobra"
	"github.com/spf13/viper"
	"github.com/stretchr/testify/require"

	"github.com/ahrtr/etcd-defrag/internal/config"
)

func TestValidateConfig_SkipHealthcheckClusterEndpoints(t *testing.T) {
	testCases := []struct {
		name      string
		cfg       config.GlobalConfig
		expectErr bool
	}{
		{
			name: "flag disabled with no endpoints",
			cfg: config.GlobalConfig{
				EtcdStorageQuotaBytes:           2 * 1024 * 1024 * 1024,
				SkipHealthcheckClusterEndpoints: false,
				Endpoints:                       []string{},
			},
			expectErr: false,
		},
		{
			name: "flag disabled with endpoints",
			cfg: config.GlobalConfig{
				EtcdStorageQuotaBytes:           2 * 1024 * 1024 * 1024,
				SkipHealthcheckClusterEndpoints: false,
				Endpoints:                       []string{"127.0.0.1:2379"},
			},
			expectErr: false,
		},
		{
			name: "flag enabled with no endpoints",
			cfg: config.GlobalConfig{
				EtcdStorageQuotaBytes:           2 * 1024 * 1024 * 1024,
				SkipHealthcheckClusterEndpoints: true,
				Endpoints:                       []string{},
			},
			expectErr: true,
		},
		{
			name: "flag enabled with single endpoint",
			cfg: config.GlobalConfig{
				EtcdStorageQuotaBytes:           2 * 1024 * 1024 * 1024,
				SkipHealthcheckClusterEndpoints: true,
				Endpoints:                       []string{"192.168.1.10:2379"},
			},
			expectErr: false,
		},
		{
			name: "flag enabled with multiple endpoints",
			cfg: config.GlobalConfig{
				EtcdStorageQuotaBytes:           2 * 1024 * 1024 * 1024,
				SkipHealthcheckClusterEndpoints: true,
				Endpoints:                       []string{"192.168.1.10:2379", "192.168.1.11:2379"},
			},
			expectErr: false,
		},
	}

	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			cmd := &cobra.Command{}
			err := tc.cfg.Validate(cmd)

			if tc.expectErr {
				require.Error(t, err)
				require.Contains(t, err.Error(), "--skip-healthcheck-cluster-endpoints requires explicit endpoints")
			} else {
				require.NoError(t, err)
			}
		})
	}
}

func TestAllFlags_SkipHealthcheckClusterEndpoints(t *testing.T) {
	testCases := []struct {
		name string
		env  map[string]string
		cli  []string
		want bool
	}{
		{
			name: "default value",
			env:  nil,
			cli:  nil,
			want: false,
		},
		{
			name: "from environment",
			env: map[string]string{
				"ETCD_DEFRAG_SKIP_HEALTHCHECK_CLUSTER_ENDPOINTS": "true",
			},
			cli:  nil,
			want: true,
		},
		{
			name: "from CLI",
			env:  nil,
			cli: []string{
				"--skip-healthcheck-cluster-endpoints=true",
			},
			want: true,
		},
		{
			name: "CLI overrides environment",
			env: map[string]string{
				"ETCD_DEFRAG_SKIP_HEALTHCHECK_CLUSTER_ENDPOINTS": "true",
			},
			cli: []string{
				"--skip-healthcheck-cluster-endpoints=false",
			},
			want: false,
		},
	}

	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			viper.Reset()
			os.Clearenv()
			// Reset globalCfg to defaults before each test
			globalCfg = config.GlobalConfig{}

			for key, val := range tc.env {
				if err := os.Setenv(key, val); err != nil {
					t.Fatalf("failed to set env %s=%s: %v", key, val, err)
				}
			}

			cmd := newDefragCommand()
			cmd.Run = func(cmd *cobra.Command, args []string) {}

			if tc.cli != nil {
				cmd.SetArgs(tc.cli)
			}

			err := cmd.Execute()
			require.NoError(t, err)

			require.Equal(t, tc.want, globalCfg.SkipHealthcheckClusterEndpoints)
		})
	}
}