Commit 729d8f0
DX-1211: fix presence hint capability; move presence/subscribe errors off colliding 93002
Two fixes to the presence.get()/channel.subscribe() missing-mode errors:
- Hint correctness (review feedback): the presence hint named a
"presence-subscribe" capability that does not exist. Presence delivery is
governed by the "subscribe" capability, matching the subscribe-mode hint.
- Error-code collision: 93002 is the canonical server code for "namespace
needs Mutable Messages" (ably-common errors.json, faqs.ably.com/error-code-93002).
presence.get() reused it client-side. Move presence to 91008 (presence
block, next to 91005) and channel.subscribe() to 90009 (channel block);
93xxx is the annotations/mutable-messages block. Both codes are new on this
unreleased branch, so the renumber is non-breaking. Reserved in
ably/ably-common#345. Update the two tests asserting them.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent ff0cf3d commit 729d8f0
4 files changed
Lines changed: 7 additions & 7 deletions
File tree
- src/common/lib/client
- test/realtime
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
520 | 520 | | |
521 | 521 | | |
522 | 522 | | |
523 | | - | |
| 523 | + | |
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
| 254 | + | |
255 | 255 | | |
256 | | - | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2118 | 2118 | | |
2119 | 2119 | | |
2120 | 2120 | | |
2121 | | - | |
| 2121 | + | |
2122 | 2122 | | |
2123 | 2123 | | |
2124 | 2124 | | |
| |||
2132 | 2132 | | |
2133 | 2133 | | |
2134 | 2134 | | |
2135 | | - | |
| 2135 | + | |
2136 | 2136 | | |
2137 | 2137 | | |
2138 | 2138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2501 | 2501 | | |
2502 | 2502 | | |
2503 | 2503 | | |
2504 | | - | |
| 2504 | + | |
2505 | 2505 | | |
2506 | 2506 | | |
2507 | 2507 | | |
| |||
2517 | 2517 | | |
2518 | 2518 | | |
2519 | 2519 | | |
2520 | | - | |
| 2520 | + | |
2521 | 2521 | | |
2522 | 2522 | | |
2523 | 2523 | | |
| |||
0 commit comments