WIP Dispatch API changes in new wayland-rs

WIP WEnum/etc.

downcast

unknown bits

Dispatch bounds

dispatch

Dispatch

WIP registry

registry API changes

`data_as_any`

Not sure why this is different.

WIP lazy init of `cursor_shape_mananger_state`?

Fix deadlock

WIP example

example

WIP update dialog

WIP

WIP

WIP examples

WIP examples

WIP

WIP

update

CursorShapeManagerState

`get_pointer_with_theme()` now takes `GlobalList`. That was the only
this `RegistryHandler::registry()` was needed for.

example

tests

clippy

tests

doc

doc tests

doc test

`SimpleGlobal::bind_singleton()` now takes a `udata` argument

Author: ids1024

Cargo.toml

@@ -61,3 +61,12 @@ pollster = "0.3.0"
 [[example]]
 name = "wgpu"
 required-features = ["system"]
+
+[patch.crates-io]
+wayland-client = { git = "https://github.com/smithay/wayland-rs" }
+wayland-protocols = { git = "https://github.com/smithay/wayland-rs" }
+wayland-protocols-wlr = { git = "https://github.com/smithay/wayland-rs" }
+wayland-protocols-misc = { git = "https://github.com/smithay/wayland-rs" }
+wayland-protocols-experimental = { git = "https://github.com/smithay/wayland-rs" }
+wayland-cursor = { git = "https://github.com/smithay/wayland-rs" }
+wayland-backend = { git = "https://github.com/smithay/wayland-rs" }

examples/data_device.rs

@@ -18,15 +18,13 @@ use smithay_client_toolkit::{
         data_source::{CopyPasteSource, DataSourceHandler, DragSource},
         DataDeviceManagerState, WritePipe,
     },
-    delegate_registry,
     output::{OutputHandler, OutputState},
     primary_selection::{
         device::{PrimarySelectionDevice, PrimarySelectionDeviceHandler},
         offer::PrimarySelectionOffer,
         selection::{PrimarySelectionSource, PrimarySelectionSourceHandler},
         PrimarySelectionManagerState,
     },
-    registry::{ProvidesRegistryState, RegistryState},
     registry_handlers,
     seat::{
         keyboard::{KeyEvent, KeyboardHandler, Keysym, Modifiers, RawModifiers},
@@ -46,7 +44,7 @@ use smithay_client_toolkit::{
     },
 };
 use wayland_client::{
-    globals::registry_queue_init,
+    globals::{registry_queue_init, GlobalListHandler},
     protocol::{
         wl_data_device::WlDataDevice,
         wl_data_device_manager::DndAction,
@@ -117,7 +115,6 @@ fn main() {
 
     let mut simple_window = DataDeviceWindow {
         compositor,
-        registry_state: RegistryState::new(&globals),
         seat_state: SeatState::new(&globals, &qh),
         output_state: OutputState::new(&globals, &qh),
         shm_state: shm,
@@ -163,7 +160,6 @@ fn main() {
 
 struct DataDeviceWindow {
     compositor: CompositorState,
-    registry_state: RegistryState,
     seat_state: SeatState,
     output_state: OutputState,
     shm_state: Shm,
@@ -1064,10 +1060,7 @@ impl PrimarySelectionSourceHandler for DataDeviceWindow {
     }
 }
 
-impl ProvidesRegistryState for DataDeviceWindow {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
+impl GlobalListHandler for DataDeviceWindow {
     registry_handlers![OutputState, SeatState];
 }
 
@@ -1079,8 +1072,6 @@ struct SeatObject {
     primary_device: Option<PrimarySelectionDevice>,
 }
 
-delegate_registry!(DataDeviceWindow);
-
 const SUPPORTED_MIME_TYPES: &[&str; 6] = &[
     "text/plain;charset=utf-8",
     "text/plain;charset=UTF-8",
@@ -1098,5 +1089,3 @@ fn pick_mime(mime_types: &[String]) -> Option<String> {
 
     None
 }
-
-smithay_client_toolkit::delegate_dispatch2!(DataDeviceWindow);

examples/dialog.rs

@@ -4,9 +4,7 @@ use smithay_client_toolkit::seat::{Capability, SeatHandler, SeatState};
 use smithay_client_toolkit::shell::xdg::dialog::{Dialog, DialogHandler};
 use smithay_client_toolkit::{
     compositor::{CompositorHandler, CompositorState, FrameCallbackData},
-    delegate_registry,
     output::{OutputHandler, OutputState},
-    registry::{ProvidesRegistryState, RegistryState},
     registry_handlers,
     shell::{
         xdg::{
@@ -23,7 +21,7 @@ use smithay_client_toolkit::{
 use wayland_client::protocol::wl_keyboard;
 use wayland_client::protocol::wl_seat;
 use wayland_client::{
-    globals::registry_queue_init,
+    globals::{registry_queue_init, GlobalListHandler},
     protocol::{wl_output, wl_shm, wl_surface},
     Connection, QueueHandle,
 };
@@ -53,7 +51,6 @@ struct Viewer {
 }
 
 struct State {
-    registry_state: RegistryState,
     output_state: OutputState,
     compositor_state: CompositorState,
     shm_state: Shm,
@@ -84,7 +81,6 @@ fn main() {
         EventLoop::try_new().expect("Failed to initialize the event loop!");
 
     let mut state = State {
-        registry_state: RegistryState::new(&globals),
         output_state: OutputState::new(&globals, &qh),
         compositor_state: CompositorState::bind(&globals, &qh)
             .expect("wl_compositor not available"),
@@ -540,14 +536,6 @@ impl ShmHandler for State {
     }
 }
 
-delegate_registry!(State);
-
-impl ProvidesRegistryState for State {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
-
+impl GlobalListHandler for State {
     registry_handlers!(OutputState);
 }
-
-smithay_client_toolkit::delegate_dispatch2!(State);

examples/dmabuf_formats.rs

@@ -1,16 +1,15 @@
 use drm_fourcc::{DrmFourcc, DrmModifier};
-use smithay_client_toolkit::{
-    dmabuf::{DmabufFeedback, DmabufFormat, DmabufHandler, DmabufState},
-    registry::{ProvidesRegistryState, RegistryState},
-    registry_handlers,
+use smithay_client_toolkit::dmabuf::{DmabufFeedback, DmabufFormat, DmabufHandler, DmabufState};
+use wayland_client::{
+    globals::{registry_queue_init, GlobalListHandler},
+    protocol::wl_buffer,
+    Connection, QueueHandle,
 };
-use wayland_client::{globals::registry_queue_init, protocol::wl_buffer, Connection, QueueHandle};
 use wayland_protocols::wp::linux_dmabuf::zv1::client::{
     zwp_linux_buffer_params_v1, zwp_linux_dmabuf_feedback_v1,
 };
 
 struct AppData {
-    registry_state: RegistryState,
     dmabuf_state: DmabufState,
     feedback: Option<DmabufFeedback>,
 }
@@ -56,12 +55,7 @@ impl DmabufHandler for AppData {
     }
 }
 
-impl ProvidesRegistryState for AppData {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
-    registry_handlers![,];
-}
+impl GlobalListHandler for AppData {}
 
 fn main() {
     env_logger::init();
@@ -71,11 +65,7 @@ fn main() {
     let (globals, mut event_queue) = registry_queue_init(&conn).unwrap();
     let qh = event_queue.handle();
 
-    let mut app_data = AppData {
-        registry_state: RegistryState::new(&globals),
-        dmabuf_state: DmabufState::new(&globals, &qh),
-        feedback: None,
-    };
+    let mut app_data = AppData { dmabuf_state: DmabufState::new(&globals, &qh), feedback: None };
 
     match app_data.dmabuf_state.version() {
         None => println!("`zwp_linux_dmabuf_v1` version `>3` not supported by compositor."),
@@ -126,6 +116,3 @@ fn print_format(format: &DmabufFormat) {
     }
     println!(", Modifier: {:?}", DrmModifier::from(format.modifier));
 }
-
-smithay_client_toolkit::delegate_registry!(AppData);
-smithay_client_toolkit::delegate_dispatch2!(AppData);

examples/foreign-toplevel-monitor.rs

@@ -1,39 +1,31 @@
 use std::error::Error;
 
-use smithay_client_toolkit::{
-    delegate_registry,
-    foreign_toplevel_list::{ForeignToplevelList, ForeignToplevelListHandler},
-    registry::{ProvidesRegistryState, RegistryState},
-    registry_handlers,
+use smithay_client_toolkit::foreign_toplevel_list::{
+    ForeignToplevelList, ForeignToplevelListHandler,
+};
+use wayland_client::{
+    globals::{registry_queue_init, GlobalListHandler},
+    Connection, QueueHandle,
 };
-use wayland_client::{globals::registry_queue_init, Connection, QueueHandle};
 use wayland_protocols::ext::foreign_toplevel_list::v1::client::ext_foreign_toplevel_handle_v1::ExtForeignToplevelHandleV1;
 
 struct State {
-    registry_state: RegistryState,
     foreign_toplevel_list: ForeignToplevelList,
 }
 
 fn main() -> Result<(), Box<dyn Error>> {
     let conn = Connection::connect_to_env()?;
     let (globals, mut event_queue) = registry_queue_init(&conn)?;
     let qh = event_queue.handle();
-    let registry_state = RegistryState::new(&globals);
     let foreign_toplevel_list = ForeignToplevelList::new(&globals, &qh);
 
-    let mut state = State { registry_state, foreign_toplevel_list };
+    let mut state = State { foreign_toplevel_list };
     loop {
         event_queue.blocking_dispatch(&mut state)?;
     }
 }
 
-impl ProvidesRegistryState for State {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
-
-    registry_handlers! {}
-}
+impl GlobalListHandler for State {}
 
 impl ForeignToplevelListHandler for State {
     fn foreign_toplevel_list_state(&mut self) -> &mut ForeignToplevelList {
@@ -76,6 +68,3 @@ impl ForeignToplevelListHandler for State {
         println!("Close toplevel: {:?}", info);
     }
 }
-
-delegate_registry!(State);
-smithay_client_toolkit::delegate_dispatch2!(State);

examples/generic_list_seats.rs

@@ -1,10 +1,12 @@
 use smithay_client_toolkit::{
-    delegate_registry,
-    registry::{ProvidesRegistryState, RegistryState},
     registry_handlers,
     seat::{Capability, SeatHandler, SeatState},
 };
-use wayland_client::{globals::registry_queue_init, protocol::wl_seat, Connection, QueueHandle};
+use wayland_client::{
+    globals::{registry_queue_init, GlobalListHandler},
+    protocol::wl_seat,
+    Connection, QueueHandle,
+};
 
 fn main() {
     env_logger::init();
@@ -14,11 +16,7 @@ fn main() {
     let (globals, mut event_queue) = registry_queue_init(&conn).unwrap();
     let qh = event_queue.handle();
 
-    let mut list_seats = ListSeats {
-        registry_state: RegistryState::new(&globals),
-        seat_state: SeatState::new(&globals, &qh),
-        _dummy: MyTest {},
-    };
+    let mut list_seats = ListSeats { seat_state: SeatState::new(&globals, &qh), _dummy: MyTest {} };
 
     event_queue.roundtrip(&mut list_seats).unwrap();
 
@@ -43,7 +41,6 @@ impl Test for MyTest {}
 
 struct ListSeats<T: Test + 'static> {
     seat_state: SeatState,
-    registry_state: RegistryState,
     _dummy: T,
 }
 
@@ -81,14 +78,6 @@ impl<T: Test + 'static> SeatHandler for ListSeats<T> {
     }
 }
 
-delegate_registry!(@<T: Test + 'static> ListSeats<T>);
-
-impl<T: Test + 'static> ProvidesRegistryState for ListSeats<T> {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
-
+impl<T: Test + 'static> GlobalListHandler for ListSeats<T> {
     registry_handlers!(SeatState);
 }
-
-smithay_client_toolkit::delegate_dispatch2!(@<T: Test + 'static> ListSeats<T>);

examples/generic_simple_window.rs

@@ -2,9 +2,7 @@ use std::convert::TryInto;
 
 use smithay_client_toolkit::{
     compositor::{CompositorHandler, CompositorState, FrameCallbackData},
-    delegate_registry,
     output::{OutputHandler, OutputState},
-    registry::{ProvidesRegistryState, RegistryState},
     registry_handlers,
     seat::{
         keyboard::{KeyEvent, KeyboardHandler, Modifiers, RawModifiers},
@@ -24,7 +22,7 @@ use smithay_client_toolkit::{
     },
 };
 use wayland_client::{
-    globals::registry_queue_init,
+    globals::{registry_queue_init, GlobalListHandler},
     protocol::{wl_keyboard, wl_output, wl_pointer, wl_seat, wl_shm, wl_surface},
     Connection, QueueHandle,
 };
@@ -72,7 +70,6 @@ fn main() {
     let pool = SlotPool::new(256 * 256 * 4, &shm).expect("Failed to create pool");
 
     let mut simple_window = SimpleWindow {
-        registry_state: RegistryState::new(&globals),
         seat_state: SeatState::new(&globals, &qh),
         output_state: OutputState::new(&globals, &qh),
         shm,
@@ -113,7 +110,6 @@ pub struct MyTest {}
 impl Test for MyTest {}
 
 struct SimpleWindow<T: Test + 'static> {
-    registry_state: RegistryState,
     seat_state: SeatState,
     output_state: OutputState,
     shm: Shm,
@@ -475,13 +471,6 @@ impl<T: Test + 'static> SimpleWindow<T> {
     }
 }
 
-delegate_registry!(@<T: Test + 'static> SimpleWindow<T>);
-
-impl<T: Test + 'static> ProvidesRegistryState for SimpleWindow<T> {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
+impl<T: Test + 'static> GlobalListHandler for SimpleWindow<T> {
     registry_handlers![OutputState, SeatState,];
 }
-
-smithay_client_toolkit::delegate_dispatch2!(@<T: Test + 'static> SimpleWindow<T>);

examples/image_viewer.rs

@@ -2,9 +2,7 @@ use std::env;
 
 use smithay_client_toolkit::{
     compositor::{CompositorHandler, CompositorState, FrameCallbackData},
-    delegate_registry,
     output::{OutputHandler, OutputState},
-    registry::{ProvidesRegistryState, RegistryState},
     registry_handlers,
     shell::{
         xdg::{
@@ -19,7 +17,7 @@ use smithay_client_toolkit::{
     },
 };
 use wayland_client::{
-    globals::registry_queue_init,
+    globals::{registry_queue_init, GlobalListHandler},
     protocol::{wl_output, wl_shm, wl_surface},
     Connection, QueueHandle,
 };
@@ -33,7 +31,6 @@ fn main() {
     let qh = event_queue.handle();
 
     let mut state = State {
-        registry_state: RegistryState::new(&globals),
         output_state: OutputState::new(&globals, &qh),
         compositor_state: CompositorState::bind(&globals, &qh)
             .expect("wl_compositor not available"),
@@ -108,7 +105,6 @@ fn main() {
 }
 
 struct State {
-    registry_state: RegistryState,
     output_state: OutputState,
     compositor_state: CompositorState,
     shm_state: Shm,
@@ -317,14 +313,6 @@ impl State {
     }
 }
 
-delegate_registry!(State);
-
-impl ProvidesRegistryState for State {
-    fn registry(&mut self) -> &mut RegistryState {
-        &mut self.registry_state
-    }
-
+impl GlobalListHandler for State {
     registry_handlers!(OutputState);
 }
-
-smithay_client_toolkit::delegate_dispatch2!(State);