chore: roll out lint to rest of crates

TomAFrench · TomAFrench · commit 50b8f28bb758 · 2025-09-09T22:22:32.000Z
diff --git a/ascon-hash/src/lib.rs b/ascon-hash/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 use core::marker::PhantomData;
 
diff --git a/belt-hash/src/lib.rs b/belt-hash/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 #![forbid(unsafe_code)]
 
 pub use digest::{self, Digest};
diff --git a/fsb/src/lib.rs b/fsb/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 #![allow(non_snake_case)]
 
 pub use digest::{self, Digest};
diff --git a/gost94/src/lib.rs b/gost94/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 #![forbid(unsafe_code)]
 
 pub use digest::{self, Digest};
diff --git a/groestl/src/lib.rs b/groestl/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/jh/src/compressor.rs b/jh/src/compressor.rs
@@ -95,7 +95,7 @@ union X2Bytes<M: Machine> {
 
 #[inline(always)]
 #[doc(hidden)]
-pub fn f8_impl<M: Machine>(mach: M, state: &mut [vec128_storage; 8], data: *const u8) {
+fn f8_impl<M: Machine>(mach: M, state: &mut [vec128_storage; 8], data: *const u8) {
     #[allow(clippy::cast_ptr_alignment)]
     let data: *const M::u128x1 = data.cast();
     let mut y = X8::<M>(
diff --git a/jh/src/lib.rs b/jh/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/k12/src/lib.rs b/k12/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest;
 
diff --git a/kupyna/src/consts.rs b/kupyna/src/consts.rs
@@ -1,4 +1,4 @@
-pub const MDS_MATRIX: [u64; 8] = [
+pub(crate) const MDS_MATRIX: [u64; 8] = [
     0x0101050108060704,
     0x0401010501080607,
     0x0704010105010806,
@@ -9,7 +9,7 @@ pub const MDS_MATRIX: [u64; 8] = [
     0x0105010806070401,
 ];
 
-pub const SBOXES: [[u8; 256]; 4] = [
+pub(crate) const SBOXES: [[u8; 256]; 4] = [
     [
         0xa8, 0x43, 0x5f, 0x06, 0x6b, 0x75, 0x6c, 0x59, 0x71, 0xdf, 0x87, 0x95, 0x17, 0xf0, 0xd8,
         0x09, 0x6d, 0xf3, 0x1d, 0xcb, 0xc9, 0x4d, 0x2c, 0xaf, 0x79, 0xe0, 0x97, 0xfd, 0x6f, 0x4b,
diff --git a/kupyna/src/lib.rs b/kupyna/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/md2/src/lib.rs b/md2/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/md4/src/lib.rs b/md4/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/ripemd/src/c128.rs b/ripemd/src/c128.rs
@@ -1,10 +1,10 @@
 use digest::typenum::U16;
 
-pub const DIGEST_BUF_LEN: usize = 4;
-pub const WORK_BUF_LEN: usize = 16;
-pub type DigestBufByteLen = U16;
+pub(super) const DIGEST_BUF_LEN: usize = 4;
+pub(super) const WORK_BUF_LEN: usize = 16;
+pub(super) type DigestBufByteLen = U16;
 
-pub const H0: [u32; DIGEST_BUF_LEN] = [0x6745_2301, 0xefcd_ab89, 0x98ba_dcfe, 0x1032_5476];
+pub(super) const H0: [u32; DIGEST_BUF_LEN] = [0x6745_2301, 0xefcd_ab89, 0x98ba_dcfe, 0x1032_5476];
 
 macro_rules! round(
     ($a:expr, $b:expr, $c:expr, $d:expr,
@@ -90,7 +90,7 @@ macro_rules! process_block(
     });
 );
 
-pub fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
+pub(crate) fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
     let mut w = [0u32; WORK_BUF_LEN];
     for (o, chunk) in w.iter_mut().zip(data.chunks_exact(4)) {
         *o = u32::from_le_bytes(chunk.try_into().unwrap());
diff --git a/ripemd/src/c160.rs b/ripemd/src/c160.rs
@@ -1,10 +1,10 @@
 use digest::typenum::U20;
 
-pub const DIGEST_BUF_LEN: usize = 5;
-pub const WORK_BUF_LEN: usize = 16;
-pub type DigestBufByteLen = U20;
+pub(super) const DIGEST_BUF_LEN: usize = 5;
+pub(super) const WORK_BUF_LEN: usize = 16;
+pub(super) type DigestBufByteLen = U20;
 
-pub const H0: [u32; DIGEST_BUF_LEN] = [
+pub(super) const H0: [u32; DIGEST_BUF_LEN] = [
     0x6745_2301,
     0xefcd_ab89,
     0x98ba_dcfe,
@@ -112,7 +112,7 @@ macro_rules! process_block(
     });
 );
 
-pub fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
+pub(crate) fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
     let mut w = [0u32; WORK_BUF_LEN];
     for (o, chunk) in w.iter_mut().zip(data.chunks_exact(4)) {
         *o = u32::from_le_bytes(chunk.try_into().unwrap());
diff --git a/ripemd/src/c256.rs b/ripemd/src/c256.rs
@@ -1,11 +1,11 @@
 use digest::typenum::U32;
 
-pub const DIGEST_BUF_LEN: usize = 8;
-pub const HALF_DIGEST_BUF_LEN: usize = DIGEST_BUF_LEN / 2;
-pub const WORK_BUF_LEN: usize = 16;
-pub type DigestBufByteLen = U32;
+pub(super) const DIGEST_BUF_LEN: usize = 8;
+pub(super) const HALF_DIGEST_BUF_LEN: usize = DIGEST_BUF_LEN / 2;
+pub(super) const WORK_BUF_LEN: usize = 16;
+pub(super) type DigestBufByteLen = U32;
 
-pub const H0: [u32; DIGEST_BUF_LEN] = [
+pub(super) const H0: [u32; DIGEST_BUF_LEN] = [
     0x6745_2301,
     0xefcd_ab89,
     0x98ba_dcfe,
@@ -119,7 +119,7 @@ macro_rules! process_block(
     });
 );
 
-pub fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
+pub(crate) fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
     let mut w = [0u32; WORK_BUF_LEN];
     for (o, chunk) in w.iter_mut().zip(data.chunks_exact(4)) {
         *o = u32::from_le_bytes(chunk.try_into().unwrap());
diff --git a/ripemd/src/c320.rs b/ripemd/src/c320.rs
@@ -1,11 +1,11 @@
 use digest::typenum::U40;
 
-pub const HALF_DIGEST_BUF_LEN: usize = 5;
-pub const DIGEST_BUF_LEN: usize = 10;
-pub const WORK_BUF_LEN: usize = 16;
-pub type DigestBufByteLen = U40;
+pub(super) const HALF_DIGEST_BUF_LEN: usize = 5;
+pub(super) const DIGEST_BUF_LEN: usize = 10;
+pub(super) const WORK_BUF_LEN: usize = 16;
+pub(super) type DigestBufByteLen = U40;
 
-pub const H0: [u32; DIGEST_BUF_LEN] = [
+pub(super) const H0: [u32; DIGEST_BUF_LEN] = [
     0x6745_2301,
     0xefcd_ab89,
     0x98ba_dcfe,
@@ -142,7 +142,7 @@ macro_rules! process_block(
     });
 );
 
-pub fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
+pub(crate) fn compress(h: &mut [u32; DIGEST_BUF_LEN], data: &[u8; 64]) {
     let mut w = [0u32; WORK_BUF_LEN];
     for (o, chunk) in w.iter_mut().zip(data.chunks_exact(4)) {
         *o = u32::from_le_bytes(chunk.try_into().unwrap());
diff --git a/ripemd/src/lib.rs b/ripemd/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/shabal/src/lib.rs b/shabal/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/skein/src/lib.rs b/skein/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 #![deny(unsafe_code)]
 
 pub use digest::{
diff --git a/sm3/src/lib.rs b/sm3/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/streebog/src/consts.rs b/streebog/src/consts.rs
@@ -3,10 +3,10 @@
 //! In the code for optimization purposes `table::SHUFFLED_LIN_TABLE` is used
 //! instead of `A` and `P`
 
-pub const BLOCK_SIZE: usize = 64;
+pub(crate) const BLOCK_SIZE: usize = 64;
 
 /// Linear transformation matrix
-pub const A: [u64; BLOCK_SIZE] = [
+pub(crate) const A: [u64; BLOCK_SIZE] = [
     0x641c314b2b8ee083,
     0xc83862965601dd1b,
     0x8d70c431ac02a736,
@@ -74,7 +74,7 @@ pub const A: [u64; BLOCK_SIZE] = [
 ];
 
 /// Substitution table
-pub const P: [u8; 256] = [
+pub(crate) const P: [u8; 256] = [
     252, 238, 221, 17, 207, 110, 49, 22, 251, 196, 250, 218, 35, 197, 4, 77, 233, 119, 240, 219,
     147, 46, 153, 186, 23, 54, 241, 187, 20, 205, 95, 193, 249, 24, 101, 90, 226, 92, 239, 33, 129,
     28, 60, 66, 139, 1, 142, 79, 5, 132, 2, 174, 227, 106, 143, 160, 6, 11, 237, 152, 127, 212,
@@ -91,7 +91,7 @@ pub const P: [u8; 256] = [
 ];
 
 /// Iteration constants
-pub const C: [[u8; BLOCK_SIZE]; 12] = [
+pub(crate) const C: [[u8; BLOCK_SIZE]; 12] = [
     [
         0x07, 0x45, 0xa6, 0xf2, 0x59, 0x65, 0x80, 0xdd, 0x23, 0x4d, 0x74, 0xcc, 0x36, 0x74, 0x76,
         0x05, 0x15, 0xd3, 0x60, 0xa4, 0x08, 0x2a, 0x42, 0xa2, 0x01, 0x69, 0x67, 0x92, 0x91, 0xe0,
@@ -179,7 +179,7 @@ pub const C: [[u8; BLOCK_SIZE]; 12] = [
 ];
 
 /// Iteration constants represented as `[u64; 8]`
-pub const C64: [[u64; 8]; 12] = {
+pub(crate) const C64: [[u64; 8]; 12] = {
     let mut res = [[0u64; 8]; 12];
     let mut i = 0;
     let mut buf = [0u8; 8];
@@ -201,7 +201,7 @@ pub const C64: [[u64; 8]; 12] = {
 
 /// Precomputed, pre-shuffled table for linear transformation using matrix
 /// `const::A` and shuffled using `const::P`
-pub const SHUFFLED_LIN_TABLE: [[u64; 256]; 8] = {
+pub(crate) const SHUFFLED_LIN_TABLE: [[u64; 256]; 8] = {
     let mut table = [[0u64; 256]; 8];
     let mut i = 0;
     while i < 8 {
diff --git a/streebog/src/lib.rs b/streebog/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![forbid(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/tiger/src/lib.rs b/tiger/src/lib.rs
@@ -6,6 +6,7 @@
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
diff --git a/whirlpool/src/consts.rs b/whirlpool/src/consts.rs
@@ -1,8 +1,8 @@
 #![allow(clippy::unreadable_literal)]
 
-pub const R: usize = 10;
+pub(crate) const R: usize = 10;
 
-pub const RC: [u64; R] = [
+pub(crate) const RC: [u64; R] = [
     0x4f01b887e8c62318,
     0x52916f79f5d2a636,
     0x357b0ca38e9bbc60,
@@ -15,7 +15,7 @@ pub const RC: [u64; R] = [
     0x33835aad07bf2dca,
 ];
 
-pub const C0: [u64; 256] = [
+pub(crate) const C0: [u64; 256] = [
     0xd83078c018601818,
     0x2646af05238c2323,
     0xb891f97ec63fc6c6,
@@ -274,7 +274,7 @@ pub const C0: [u64; 256] = [
     0xc211a44486228686,
 ];
 
-pub const C1: [u64; 256] = [
+pub(crate) const C1: [u64; 256] = [
     0x3078c018601818d8,
     0x46af05238c232326,
     0x91f97ec63fc6c6b8,
@@ -533,7 +533,7 @@ pub const C1: [u64; 256] = [
     0x11a44486228686c2,
 ];
 
-pub const C2: [u64; 256] = [
+pub(crate) const C2: [u64; 256] = [
     0x78c018601818d830,
     0xaf05238c23232646,
     0xf97ec63fc6c6b891,
@@ -792,7 +792,7 @@ pub const C2: [u64; 256] = [
     0xa44486228686c211,
 ];
 
-pub const C3: [u64; 256] = [
+pub(crate) const C3: [u64; 256] = [
     0xc018601818d83078,
     0x05238c23232646af,
     0x7ec63fc6c6b891f9,
@@ -1051,7 +1051,7 @@ pub const C3: [u64; 256] = [
     0x4486228686c211a4,
 ];
 
-pub const C4: [u64; 256] = [
+pub(crate) const C4: [u64; 256] = [
     0x18601818d83078c0,
     0x238c23232646af05,
     0xc63fc6c6b891f97e,
@@ -1310,7 +1310,7 @@ pub const C4: [u64; 256] = [
     0x86228686c211a444,
 ];
 
-pub const C5: [u64; 256] = [
+pub(crate) const C5: [u64; 256] = [
     0x601818d83078c018,
     0x8c23232646af0523,
     0x3fc6c6b891f97ec6,
@@ -1569,7 +1569,7 @@ pub const C5: [u64; 256] = [
     0x228686c211a44486,
 ];
 
-pub const C6: [u64; 256] = [
+pub(crate) const C6: [u64; 256] = [
     0x1818d83078c01860,
     0x23232646af05238c,
     0xc6c6b891f97ec63f,
@@ -1828,7 +1828,7 @@ pub const C6: [u64; 256] = [
     0x8686c211a4448622,
 ];
 
-pub const C7: [u64; 256] = [
+pub(crate) const C7: [u64; 256] = [
     0x18d83078c0186018,
     0x232646af05238c23,
     0xc6b891f97ec63fc6,
diff --git a/whirlpool/src/lib.rs b/whirlpool/src/lib.rs
@@ -7,6 +7,7 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 #![deny(unsafe_code)]
 #![warn(missing_docs)]
+#![warn(unreachable_pub)]
 
 pub use digest::{self, Digest};
 
