Removed __extension__, disabled warning for anonymous structs

stefanatwork · stefanatwork · commit 248b3f934f6d · 2026-06-15T09:22:37.000+02:00
diff --git a/common/cmake/clang.cmake b/common/cmake/clang.cmake
@@ -101,6 +101,7 @@ ELSE()
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-float-equal")            # disable: intentional exact-zero checks in normalize_safe
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-shadow")                 # disable: pervasive in vector class constructors
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-nested-anon-types")      # disable: anonymous types in unions for SIMD
+  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-anonymous-struct")   # disable: anonymous structs in unions for SIMD
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sign-compare")           # disable: int/size_t comparisons in template code
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-c++17-attribute-extensions")  # disable: [[fallthrough]] etc in C++11 mode
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")                    # treat all warnings as errors
diff --git a/common/cmake/gnu.cmake b/common/cmake/gnu.cmake
@@ -34,7 +34,6 @@ ENDIF (EMBREE_ARM)
 
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")                       # enables most warnings
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra")                    # enables extra warnings
-SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wpedantic")                 # enables pedantic warnings
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wformat -Wformat-security")  # enables string format vulnerability warnings
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-class-memaccess")        # disables clearing an object of type
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter")      # disables warnings for unused function parameters
@@ -54,6 +53,7 @@ SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cast-align")            # disable:
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-declarations")   # disable: intentional factory pattern without declarations
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-shadow")                 # disable: pervasive in vector class constructors
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-float-equal")            # disable: intentional exact-zero checks in normalize_safe
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-nested-anon-types")      # disable: anonymous types in unions for SIMD
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wredundant-decls")          # warn about redundant declarations
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
 
diff --git a/common/math/color.h b/common/math/color.h
@@ -23,7 +23,7 @@ namespace embree
   {
     union {
       __m128 m128;
-      __extension__ struct { float r,g,b,a; };
+      struct { float r,g,b,a; };
     };
 
     ////////////////////////////////////////////////////////////////////////////////
@@ -91,7 +91,7 @@ namespace embree
   {
     union {
       __m128 m128;
-      __extension__ struct { float r,g,b; };
+      struct { float r,g,b; };
     };
 
     ////////////////////////////////////////////////////////////////////////////////
diff --git a/common/math/vec2.h b/common/math/vec2.h
@@ -17,7 +17,7 @@ namespace embree
   {
     enum { N = 2 };
     union {
-      __extension__ struct { T x, y; };
+      struct { T x, y; };
 #if !(defined(__WIN32__) && _MSC_VER == 1800) // workaround for older VS 2013 compiler
       T components[N];
 #endif
diff --git a/common/math/vec2fa.h b/common/math/vec2fa.h
@@ -26,7 +26,7 @@ namespace embree
     enum { N = 2 };
     union {
       __m128 m128;
-      __extension__ struct { float x,y,az,aw; };
+      struct { float x,y,az,aw; };
     };
 
     ////////////////////////////////////////////////////////////////////////////////
diff --git a/common/math/vec3.h b/common/math/vec3.h
@@ -18,7 +18,7 @@ namespace embree
     enum { N  = 3 };
 
     union {
-      __extension__ struct {
+      struct {
 	T x, y, z;
       };
 #if !(defined(__WIN32__) && _MSC_VER == 1800) // workaround for older VS 2013 compiler
diff --git a/common/math/vec3ba.h b/common/math/vec3ba.h
@@ -24,7 +24,7 @@ namespace embree
     
     union {
       __m128 m128;
-      __extension__ struct { int x,y,z; };
+      struct { int x,y,z; };
     };
 
     typedef int Scalar;
diff --git a/common/math/vec3fa.h b/common/math/vec3fa.h
@@ -26,7 +26,7 @@ namespace embree
     enum { N = 3 };
     union {
       __m128 m128;
-      __extension__ struct { float x,y,z; };
+      struct { float x,y,z; };
     };
 
     ////////////////////////////////////////////////////////////////////////////////
@@ -429,7 +429,7 @@ namespace embree
     enum { N = 3 };
     union {
       __m128 m128;
-      __extension__ struct { float x,y,z; union { int a; unsigned u; float w; }; };
+      struct { float x,y,z; union { int a; unsigned u; float w; }; };
     };
 
     ////////////////////////////////////////////////////////////////////////////////
diff --git a/common/math/vec3ia.h b/common/math/vec3ia.h
@@ -24,7 +24,7 @@ namespace embree
 
     union {
       __m128i m128;
-      __extension__ struct { int x,y,z; };
+      struct { int x,y,z; };
     };
 
     typedef int Scalar;
diff --git a/common/math/vec4.h b/common/math/vec4.h
@@ -16,7 +16,7 @@ namespace embree
   {
     enum { N = 4 };    
     union {
-      __extension__ struct { T x, y, z, w; };
+      struct { T x, y, z, w; };
 #if !(defined(__WIN32__) && _MSC_VER == 1800) // workaround for older VS 2013 compiler
       T components[N];
 #endif
diff --git a/common/simd/vboold4_avx.h b/common/simd/vboold4_avx.h
@@ -24,7 +24,7 @@ namespace embree
     enum  { size = 4 };       // number of SIMD elements
     union {                   // data
       __m256d v;
-      __extension__ struct { __m128d vl,vh; };
+      struct { __m128d vl,vh; };
       long long i[4];
     };
 
diff --git a/common/simd/vboolf8_avx.h b/common/simd/vboolf8_avx.h
@@ -26,7 +26,7 @@ namespace embree
     enum  { size = 8 };       // number of SIMD elements
     union {                   // data
       __m256 v;
-      __extension__ struct { __m128 vl,vh; };
+      struct { __m128 vl,vh; };
       int i[8];
     };  
 
diff --git a/common/simd/vint8_avx.h b/common/simd/vint8_avx.h
@@ -26,7 +26,7 @@ namespace embree
     enum  { size = 8 };        // number of SIMD elements
     union {                    // data
       __m256i v;
-      __extension__ struct { __m128i vl,vh; };
+      struct { __m128i vl,vh; };
       int i[8];
     }; 
 
diff --git a/common/simd/vuint8_avx.h b/common/simd/vuint8_avx.h
@@ -26,7 +26,7 @@ namespace embree
     enum  { size = 8 };        // number of SIMD elements
     union {                    // data
       __m256i v;
-      __extension__ struct { __m128i vl,vh; };
+      struct { __m128i vl,vh; };
       unsigned int i[8];
     }; 
 
diff --git a/kernels/builders/bvh_builder_morton.h b/kernels/builders/bvh_builder_morton.h
@@ -53,7 +53,7 @@ namespace embree
       struct __aligned(8) BuildPrim
       {
         union {
-          __extension__ struct {
+          struct {
             unsigned int code;     //!< morton code
             unsigned int index;    //!< i'th primitive
           };
diff --git a/kernels/bvh/bvh_node_qaabb.h b/kernels/bvh/bvh_node_qaabb.h
@@ -118,7 +118,7 @@ namespace embree
 #endif
     
     union {
-      __extension__ struct {
+      struct {
         T lower_x[N]; //!< 8bit discretized X dimension of lower bounds of all N children
         T upper_x[N]; //!< 8bit discretized X dimension of upper bounds of all N children
         T lower_y[N]; //!< 8bit discretized Y dimension of lower bounds of all N children
diff --git a/kernels/common/geometry.h b/kernels/common/geometry.h
@@ -656,7 +656,7 @@ namespace embree
     unsigned int mask;             //!< for masking out geometry
     unsigned int modCounter_ = 1; //!< counter for every modification - used to rebuild scenes when geo is modified
 
-    __extension__ struct {
+    struct {
       GType gtype : 8;                //!< geometry type
       GSubType gsubtype : 8;          //!< geometry subtype
       RTCBuildQuality quality : 3;    //!< build quality for geometry

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ namespace embree`
`17`	`17`	`{`
`18`	`18`	`enum { N = 2 };`
`19`	`19`	`union {`
`20`		`- __extension__ struct { T x, y; };`
	`20`	`+ struct { T x, y; };`
`21`	`21`	`#if !(defined(__WIN32__) && _MSC_VER == 1800) // workaround for older VS 2013 compiler`
`22`	`22`	`T components[N];`
`23`	`23`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ namespace embree`
`16`	`16`	`{`
`17`	`17`	`enum { N = 4 };`
`18`	`18`	`union {`
`19`		`- __extension__ struct { T x, y, z, w; };`
	`19`	`+ struct { T x, y, z, w; };`
`20`	`20`	`#if !(defined(__WIN32__) && _MSC_VER == 1800) // workaround for older VS 2013 compiler`
`21`	`21`	`T components[N];`
`22`	`22`	`#endif`