Merge pull request #3248 from ProvableHQ/fix/parameter-fetch-ureq-minimal

[Fix] Use `ureq` instead of `reqwest::blocking`

Author: vicsn

.circleci/config.yml

@@ -686,7 +686,7 @@ jobs:
 
   ledger:
     executor: rust-docker
-    resource_class: << pipeline.parameters.xlarge >>
+    resource_class: << pipeline.parameters.twoxlarge >>
     steps:
       - run_test:
           workspace_member: snarkvm-ledger

Cargo.lock

@@ -93,15 +93,13 @@ version = "0.3.64"
 features = ["XmlHttpRequest"]
 optional = true
 
-[target.'cfg(all(any(target_os = "android", target_os = "ios"), not(target_family = "wasm"), not(target_env = "sgx")))'.dependencies.reqwest]
-version = "0.13"
-default-features = false
-features = ["blocking", "native-tls"]
+[target.'cfg(all(any(target_os = "android", target_os = "ios"), not(target_family = "wasm"), not(target_env = "sgx")))'.dependencies.ureq]
+workspace = true
+features = ["native-tls"]
 
-[target.'cfg(all(not(any(target_os = "android", target_os = "ios")), not(target_family = "wasm"), not(target_env = "sgx")))'.dependencies.reqwest]
-version = "0.13"
-default-features = false
-features = ["blocking", "rustls"]
+[target.'cfg(all(not(any(target_os = "android", target_os = "ios")), not(target_family = "wasm"), not(target_env = "sgx")))'.dependencies.ureq]
+workspace = true
+features = ["rustls"]
 
 [dev-dependencies.snarkvm-algorithms]
 path = "../algorithms"

parameters/Cargo.toml

@@ -40,9 +40,9 @@ pub enum ParameterError {
 }
 
 #[cfg(all(not(feature = "wasm"), not(target_env = "sgx")))]
-impl From<reqwest::Error> for ParameterError {
-    fn from(error: reqwest::Error) -> Self {
-        ParameterError::Crate("reqwest", format!("{error}"))
+impl From<ureq::Error> for ParameterError {
+    fn from(error: ureq::Error) -> Self {
+        ParameterError::Crate("ureq", format!("{error}"))
     }
 }
 

parameters/src/errors/parameter.rs

@@ -70,33 +70,32 @@ macro_rules! impl_store_and_remote_fetch {
 
         #[cfg(all(not(feature = "wasm"), not(target_env = "sgx")))]
         fn remote_fetch(buffer: &mut Vec<u8>, url: &str) -> Result<(), $crate::errors::ParameterError> {
+            use std::io::Read;
+
             #[cfg(not(feature = "no_std_out"))]
             {
                 use colored::*;
                 let output = format!("{:>15} - Downloading \"{}\"", "Installation", url);
                 println!("{}", output.dimmed());
             }
 
-            let host = url.split('/').nth(2).unwrap_or_default().to_string();
-            let retry_policy = reqwest::retry::for_host(host)
-                .max_retries_per_request(3)
-                .classify_fn(|req_rep| {
-                    if req_rep.error().is_some() {
-                        return req_rep.retryable();
+            // Retry up to 3 times on transient errors (5xx, 429, IO, timeout).
+            let mut attempts = 3u32;
+            loop {
+                match ureq::get(url).config().max_redirects(10).build().call() {
+                    Ok(mut response) => {
+                        response.body_mut().as_reader().read_to_end(buffer)?;
+                        break;
                     }
-                    match req_rep.status() {
-                        Some(status) if status.is_server_error() || status.as_u16() == 429 => req_rep.retryable(),
-                        _ => req_rep.success(),
+                    Err(ureq::Error::StatusCode(code)) if attempts > 0 && (code >= 500 || code == 429) => {
+                        attempts -= 1;
                     }
-                });
-
-            let client = reqwest::blocking::Client::builder()
-                .redirect(reqwest::redirect::Policy::limited(10)) // Limit to 10 redirects.
-                .retry(retry_policy)
-                .build()?;
-
-            let mut response = client.get(url).send()?.error_for_status()?;
-            response.copy_to(buffer)?;
+                    Err(ureq::Error::Io(_) | ureq::Error::Timeout(_)) if attempts > 0 => {
+                        attempts -= 1;
+                    }
+                    Err(err) => return Err(err.into()),
+                }
+            }
 
             #[cfg(not(feature = "no_std_out"))]
             {