Skip to content

Commit a31971f

Browse files
migrate markdown 404 page test case to markdown plugin
1 parent bc5be5f commit a31971f

9 files changed

Lines changed: 13 additions & 3 deletions

File tree

packages/plugin-markdown/src/index.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ import { unified } from "unified";
1111
// https://github.com/ProjectEvergreen/greenwood/issues/1278
1212
let allHeadingsTracked = false;
1313

14+
const PLUGIN_EXTENSION = ".md";
15+
1416
async function trackAllTocHeadings(compilation) {
1517
for (const idx in compilation.graph) {
1618
const page = compilation.graph[idx];
1719

18-
if (page.pageHref.endsWith(".md")) {
20+
if (page?.pageHref?.endsWith(PLUGIN_EXTENSION)) {
1921
const markdownContents = await fs.readFile(new URL(page.pageHref), "utf-8");
2022

2123
let tocData = {};
@@ -47,7 +49,7 @@ async function trackAllTocHeadings(compilation) {
4749
class MarkdownResource {
4850
constructor(compilation, options = {}) {
4951
this.compilation = compilation;
50-
this.extensions = [".md"];
52+
this.extensions = [PLUGIN_EXTENSION];
5153
this.contentType = "text/html";
5254
this.servePage = "static";
5355
this.options = options;
@@ -60,6 +62,7 @@ class MarkdownResource {
6062
return (
6163
protocol.startsWith("http") &&
6264
hasMatchingPageRoute &&
65+
hasMatchingPageRoute.pageHref &&
6366
hasMatchingPageRoute.pageHref.endsWith(this.extensions[0])
6467
);
6568
}

packages/cli/test/cases/build.default.workspace-404-markdown/build.default.workspace-404-markdown.spec.js renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/build.default.workspace-404-markdown.spec.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
* greenwood build
1010
*
1111
* User Config
12-
* None (Greenwood Default)
12+
* {
13+
* plugins: [greenwoodPluginMarkdown()]
14+
* }
1315
*
1416
* User Workspace
1517
* src/
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { greenwoodPluginMarkdown } from "../../../src/index.js";
2+
3+
export default {
4+
plugins: [greenwoodPluginMarkdown()],
5+
};

packages/cli/test/cases/build.default.workspace-404-markdown/src/layouts/app.html renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/layouts/app.html

File renamed without changes.

packages/cli/test/cases/build.default.workspace-404-markdown/src/pages/404.md renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/pages/404.md

File renamed without changes.

packages/cli/test/cases/build.default.workspace-404-markdown/src/scripts/404.js renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/scripts/404.js

File renamed without changes.

packages/cli/test/cases/build.default.workspace-404-markdown/src/scripts/header.js renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/scripts/header.js

File renamed without changes.

packages/cli/test/cases/build.default.workspace-404-markdown/src/styles/404.css renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/styles/404.css

File renamed without changes.

packages/cli/test/cases/build.default.workspace-404-markdown/src/styles/theme.css renamed to packages/plugin-markdown/test/cases/build.default.workspace-404-markdown/src/styles/theme.css

File renamed without changes.

0 commit comments

Comments
 (0)