[MIG] crm_security_group: Migration to 19.0

Author: bizzappdev

crm_security_group/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 ========================
 CRM Only Security Groups
 ========================
@@ -13,17 +17,17 @@ CRM Only Security Groups
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github
-    :target: https://github.com/OCA/crm/tree/18.0/crm_security_group
+    :target: https://github.com/OCA/crm/tree/19.0/crm_security_group
     :alt: OCA/crm
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_security_group
+    :target: https://translation.odoo-community.org/projects/crm-19-0/crm-19-0-crm_security_group
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -49,7 +53,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_security_group%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_security_group%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -89,6 +93,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-victoralmau| 
 
-This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/18.0/crm_security_group>`_ project on GitHub.
+This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/19.0/crm_security_group>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

crm_security_group/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "CRM Only Security Groups",
     "summary": "Add new group in Sales to show only CRM",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "category": "Customer Relationship Management",
     "website": "https://github.com/OCA/crm",
     "author": "Tecnativa, Odoo Community Association (OCA)",

crm_security_group/security/security.xml

@@ -1,31 +1,31 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <record id="module_category_crm_crm" model="ir.module.category">
+    <record id="module_privilege_crm_crm" model="res.groups.privilege">
         <field name="name">CRM</field>
-        <field name="parent_id" ref="base.module_category_sales" />
+        <field name="category_id" ref="base.module_category_sales" />
     </record>
     <record id="group_crm_own_leads" model="res.groups">
         <field name="name">User: Own Documents Only</field>
-        <field name="category_id" ref="crm_security_group.module_category_crm_crm" />
+        <field name="privilege_id" ref="crm_security_group.module_privilege_crm_crm" />
         <field name="implied_ids" eval="[(4, ref('base.group_user'))]" />
     </record>
     <record id="group_crm_all_leads" model="res.groups">
         <field name="name">User: All Documents</field>
-        <field name="category_id" ref="crm_security_group.module_category_crm_crm" />
+        <field name="privilege_id" ref="crm_security_group.module_privilege_crm_crm" />
         <field
             name="implied_ids"
             eval="[(4, ref('crm_security_group.group_crm_own_leads'))]"
         />
     </record>
     <record id="group_crm_manager" model="res.groups">
         <field name="name">Administrator</field>
-        <field name="category_id" ref="crm_security_group.module_category_crm_crm" />
+        <field name="privilege_id" ref="crm_security_group.module_privilege_crm_crm" />
         <field
             name="implied_ids"
             eval="[(4, ref('crm_security_group.group_crm_all_leads'))]"
         />
         <field
-            name="users"
+            name="user_ids"
             eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
         />
     </record>

crm_security_group/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>CRM Only Security Groups</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="crm-only-security-groups">
-<h1 class="title">CRM Only Security Groups</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="crm-only-security-groups">
+<h1>CRM Only Security Groups</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:ff827f2c5570d1bb578f6a4d533f423854d8a9852c19f93135d98e8844226261
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/18.0/crm_security_group"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_security_group"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/19.0/crm_security_group"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-19-0/crm-19-0-crm_security_group"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds new security options to CRM by creating 3 groups (Own
 Documents Only, All Documents and Administrator) to separate Sales and
 CRM apps permissions</p>
@@ -387,30 +392,30 @@ <h1 class="title">CRM Only Security Groups</h1>
 </ul>
 </div>
 <div class="section" id="known-issues-roadmap">
-<h1><a class="toc-backref" href="#toc-entry-1">Known issues / Roadmap</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Known issues / Roadmap</a></h2>
 <ul class="simple">
 <li>Remove sale_crm dependency (now is not possible), maybe split this
 part in other addon</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/crm/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_security_group%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_security_group%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-3">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-4">Authors</a></h3>
 <ul class="simple">
 <li>Tecnativa</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Contributors</a></h3>
 <ul class="simple">
 <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
 <li>Víctor Martínez</li>
@@ -419,7 +424,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
@@ -429,10 +434,11 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/victoralmau"><img alt="victoralmau" src="https://github.com/victoralmau.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/18.0/crm_security_group">OCA/crm</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/19.0/crm_security_group">OCA/crm</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

crm_security_group/views/crm_team_views.xml

@@ -5,11 +5,14 @@
         <field name="model">crm.team</field>
         <field name="inherit_id" ref="sales_team.crm_team_view_kanban_dashboard" />
         <field name="arch" type="xml">
-            <button name="action_primary_channel_button" position="attributes">
+            <xpath
+                expr="//kanban[@action='action_primary_channel_button']"
+                position="attributes"
+            >
                 <attribute
                     name="groups"
                 >crm_security_group.group_crm_own_leads</attribute>
-            </button>
+            </xpath>
         </field>
     </record>
     <record id="sale_crm_team_view_kanban_dashboard" model="ir.ui.view">
@@ -20,15 +23,6 @@
             <field name="invoiced_target" position="attributes">
                 <attribute name="groups">sales_team.group_sale_salesman</attribute>
             </field>
-            <xpath
-                expr="//div[@t-if='record.quotations_count.raw_value']"
-                position="attributes"
-            >
-                <attribute name="groups">sales_team.group_sale_salesman</attribute>
-            </xpath>
-            <xpath expr="//div[@name='orders_to_invoice']" position="attributes">
-                <attribute name="groups">sales_team.group_sale_salesman</attribute>
-            </xpath>
             <xpath expr="//div[@name='sales_report']" position="attributes">
                 <attribute name="groups">sales_team.group_sale_salesman</attribute>
             </xpath>
@@ -46,23 +40,7 @@
         <field name="inherit_id" ref="crm.crm_team_view_kanban_dashboard" />
         <field name="arch" type="xml">
             <xpath
-                expr="//div[@t-if='record.lead_unassigned_count.raw_value']"
-                position="attributes"
-            >
-                <attribute
-                    name="groups"
-                >crm_security_group.group_crm_own_leads</attribute>
-            </xpath>
-            <xpath
-                expr="//div[@t-if='record.opportunities_count.raw_value']"
-                position="attributes"
-            >
-                <attribute
-                    name="groups"
-                >crm_security_group.group_crm_own_leads</attribute>
-            </xpath>
-            <xpath
-                expr="//div[@t-if='record.opportunities_overdue_count.raw_value']"
+                expr="//a[@name='action_open_unassigned_leads']"
                 position="attributes"
             >
                 <attribute

crm_security_group/views/menu_items.xml

@@ -2,46 +2,46 @@
 <odoo>
     <record id="crm.crm_menu_root" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(6,0,[ref('crm_security_group.group_crm_own_leads')])]"
         />
     </record>
     <record id="sale_crm.sale_order_menu_quotations_crm" model="ir.ui.menu">
-        <field name="groups_id" eval="[(4, ref('sales_team.group_sale_salesman'))]" />
+        <field name="group_ids" eval="[(4, ref('sales_team.group_sale_salesman'))]" />
     </record>
     <record id="crm.crm_lead_menu_my_activities" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(4, ref('crm_security_group.group_crm_own_leads'))]"
         />
     </record>
     <record id="crm.sales_team_menu_team_pipeline" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(4, ref('crm_security_group.group_crm_manager'))]"
         />
     </record>
     <record id="crm.crm_menu_report" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(6,0,[ref('crm_security_group.group_crm_manager')])]"
         />
     </record>
     <record id="crm.crm_menu_config" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(4, ref('crm_security_group.group_crm_manager'))]"
         />
     </record>
     <record id="crm.mail_activity_plan_menu_config_lead" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(6,0,[ref('crm_security_group.group_crm_manager')])]"
         />
     </record>
     <record id="crm.menu_crm_config_lead" model="ir.ui.menu">
         <field
-            name="groups_id"
+            name="group_ids"
             eval="[(6,0,[ref('crm_security_group.group_crm_manager')])]"
         />
     </record>